Your message dated Mon, 21 Mar 2011 21:11:42 +0000
with message-id <[email protected]>
and subject line Bug#597149: fixed in magit 0.8.2+20110220-1
has caused the Debian Bug report #597149,
regarding magit modifies global setting of `line-move-visual'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
597149: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=597149
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: magit
Version: 0.7-1.1
Severity: normal


The `magit-mode' function contains this statement:

  (setq major-mode 'magit-mode
        mode-name "Magit"
        mode-line-process ""
        truncate-lines t
        line-move-visual nil)

Most of those settings are OK, as those variables automatically become
buffer-local upon setting.  However, the `line-move-visual' variable
does _not_ become buffer-local upon setting, so the above ends up
modifying the global value, which is bad.

The correct code might look like:

  (setq major-mode 'magit-mode
        mode-name "Magit"
        mode-line-process ""
        truncate-lines t)
  (set (make-local-variable 'line-move-visual) nil)


Thanks,

-Miles


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages magit depends on:
ii  dpkg                      1.15.8.5       Debian package management system
ii  emacs23 [emacsen]         23.2+1-4       The GNU Emacs editor (with GTK+ us
ii  git [git-core]            1:1.7.1-1.1    fast, scalable, distributed revisi
ii  git-core                  1:1.7.1-1.1    fast, scalable, distributed revisi
ii  install-info              4.13a.dfsg.1-5 Manage installed documentation in 

magit recommends no packages.

magit suggests no packages.

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: magit
Source-Version: 0.8.2+20110220-1

We believe that the bug you reported is fixed in the latest version of
magit, which is due to be installed in the Debian FTP archive:

magit_0.8.2+20110220-1.debian.tar.gz
  to main/m/magit/magit_0.8.2+20110220-1.debian.tar.gz
magit_0.8.2+20110220-1.dsc
  to main/m/magit/magit_0.8.2+20110220-1.dsc
magit_0.8.2+20110220-1_all.deb
  to main/m/magit/magit_0.8.2+20110220-1_all.deb
magit_0.8.2+20110220.orig.tar.gz
  to main/m/magit/magit_0.8.2+20110220.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Teemu Hukkanen <[email protected]> (supplier of updated magit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 21 Mar 2011 21:02:51 +0200
Source: magit
Binary: magit
Architecture: source all
Version: 0.8.2+20110220-1
Distribution: unstable
Urgency: low
Maintainer: Timo Juhani Lindfors <[email protected]>
Changed-By: Teemu Hukkanen <[email protected]>
Description: 
 magit      - A Emacs interface for Git
Closes: 586039 586047 586051 591646 597149
Changes: 
 magit (0.8.2+20110220-1) unstable; urgency=low
 .
   [ Timo Juhani Lindfors ]
   * New upstream release (closes: #586039, #586047, #591646, #591646, #597149).
   * Provide debian/watch file (closes: #586051).
   * Switch to dpkg-source 3.0 (quilt) format.
   * Simplify debian/rules and upstream all debian/patches.
   * Bump Standards-Version to 3.9.1 (no changes needed)
   * Update copyright information in DEP-5 format.
 .
   [ Teemu Hukkanen ]
   * Move package to collab-maint.
   * Add install-info to Build-Depends.
   * Add myself to Uploaders.
Checksums-Sha1: 
 318f53a92a30f7165d23a9d9ed3b9bca907517f4 1326 magit_0.8.2+20110220-1.dsc
 38c82469525b89edd059364d273e21053f60040c 79680 magit_0.8.2+20110220.orig.tar.gz
 f37f5f6cddd0d83bb4c40701e540ca162f1eec46 5255 
magit_0.8.2+20110220-1.debian.tar.gz
 ec9aa28edc627049f191db89f807ba8b74ae4a9e 64700 magit_0.8.2+20110220-1_all.deb
Checksums-Sha256: 
 13d7e2308d622e8d07f7de847d65ed9bec68413b65c978f3ad8e65202c1f06d1 1326 
magit_0.8.2+20110220-1.dsc
 fa95c701efe4b8888541f7740100493eafd60ce6f9c2b154e2cc2131fcd4d041 79680 
magit_0.8.2+20110220.orig.tar.gz
 a43855dee7d1693969df0acd4b29dcb5b958390a87169f624452cb768ce75c80 5255 
magit_0.8.2+20110220-1.debian.tar.gz
 f920d93881b791590d28f9b5386a75190d2df7df531bd4ab20899071f119db06 64700 
magit_0.8.2+20110220-1_all.deb
Files: 
 ca44c3f15d8af17df89c0a4b9fd2a76d 1326 devel optional magit_0.8.2+20110220-1.dsc
 6f1540b9f07f5eb26f2c68a12a84c774 79680 devel optional 
magit_0.8.2+20110220.orig.tar.gz
 bdc461710b35105fa491e506b6629fa1 5255 devel optional 
magit_0.8.2+20110220-1.debian.tar.gz
 0ed417fcbf32db5da14d95704438c67f 64700 devel optional 
magit_0.8.2+20110220-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk2HpAsACgkQVMJPtTsLuakP+QCdFxlJ0q7gbaaLbzmtdY2atVCn
nTAAoMPyZFTBJ4QI33KZV8BhfHKXVwuv
=5g5f
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to