Your message dated Mon, 11 Apr 2011 23:33:26 +0000
with message-id <[email protected]>
and subject line Bug#621832: fixed in lastfm 1:1.5.4.27091+dfsg-4
has caused the Debian Bug report #621832,
regarding lastfm: hard-codes include paths, will FTBFS under multiarch
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
621832: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=621832
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lastfm
Version: 1:1.5.4.27091+dfsg-2
Severity: important
Tags: patch
User: [email protected]
Usertags: multiarch
Hi John,
In an archive rebuild of Ubuntu following the conversion of the base system
to multiarch, it was found that lastfm fails to build because it hard-codes
the include paths used to find various headers. It should instead query
pkg-config for this information, since pkg-config is the authoritative
interface for these libraries.
The attached patch does this, and has been uploaded to Ubuntu with the
following changelog explanation:
* debian/patches/build-fixes.diff: use pkg-config instead of hard-coding
include paths for glib-2.0 and libgpod. LP: #749089.
* debian/patches/build-kfreebsd.diff: drop references to /usr/local, which
have nothing at all to do with a kfreebsd build.
Since multiarch should be coming soon to Debian, please consider applying
this to your package ASAP.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru lastfm-1.5.4.27091+dfsg/debian/control lastfm-1.5.4.27091+dfsg/debian/control
--- lastfm-1.5.4.27091+dfsg/debian/control 2010-12-06 21:34:59.000000000 -0800
+++ lastfm-1.5.4.27091+dfsg/debian/control 2011-04-09 01:19:01.000000000 -0700
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: John Stamp <[email protected]>
Build-Depends: debhelper (>= 7.4.12), libqt4-dev (>= 4.3.0), libgpod-nogtk-dev,
- libmad0-dev, zlib1g-dev, libx11-dev, x11proto-core-dev,
+ libmad0-dev, zlib1g-dev, libx11-dev, x11proto-core-dev, pkg-config,
libasound2-dev (>= 1.0.9) [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386]
Standards-Version: 3.9.1
Homepage: http://www.last.fm/
diff -Nru lastfm-1.5.4.27091+dfsg/debian/patches/build-fixes.diff lastfm-1.5.4.27091+dfsg/debian/patches/build-fixes.diff
--- lastfm-1.5.4.27091+dfsg/debian/patches/build-fixes.diff 2010-12-06 21:34:59.000000000 -0800
+++ lastfm-1.5.4.27091+dfsg/debian/patches/build-fixes.diff 2011-04-09 01:14:28.000000000 -0700
@@ -1,7 +1,9 @@
Don't compile portAudio output plugin on Linux.
-And fix 64 bit builds for some distributions.
---- a/LastFM.pro
-+++ b/LastFM.pro
+And properly detect include paths using pkg-config.
+Index: lastfm-1.5.4.27091+dfsg/LastFM.pro
+===================================================================
+--- lastfm-1.5.4.27091+dfsg.orig/LastFM.pro
++++ lastfm-1.5.4.27091+dfsg/LastFM.pro
@@ -41,8 +41,7 @@
SUBDIRS -= src/Twiddly \
src/Bootstrapper/ITunesDevice
@@ -12,14 +14,16 @@
}
---- a/src/mediadevices/ipod/ipod.pro
-+++ b/src/mediadevices/ipod/ipod.pro
+Index: lastfm-1.5.4.27091+dfsg/src/mediadevices/ipod/ipod.pro
+===================================================================
+--- lastfm-1.5.4.27091+dfsg.orig/src/mediadevices/ipod/ipod.pro
++++ lastfm-1.5.4.27091+dfsg/src/mediadevices/ipod/ipod.pro
@@ -11,7 +11,7 @@
linux* {
LIBS += -lgpod
- INCLUDEPATH += /usr/include/gpod-1.0 /usr/include/glib-2.0 /usr/lib/glib-2.0/include
-+ INCLUDEPATH += /usr/include/gpod-1.0 /usr/include/glib-2.0 /usr/lib/glib-2.0/include /usr/lib64/glib-2.0/include
++ INCLUDEPATH += $$system(pkg-config --cflags-only-I libgpod-1.0 | sed -e's/-I//g')
}
mac {
diff -Nru lastfm-1.5.4.27091+dfsg/debian/patches/build-kfreebsd.diff lastfm-1.5.4.27091+dfsg/debian/patches/build-kfreebsd.diff
--- lastfm-1.5.4.27091+dfsg/debian/patches/build-kfreebsd.diff 2010-12-06 21:34:59.000000000 -0800
+++ lastfm-1.5.4.27091+dfsg/debian/patches/build-kfreebsd.diff 2011-04-09 01:04:38.000000000 -0700
@@ -66,18 +66,6 @@
mac {
DEFINES += MACOSX
}
---- a/src/mediadevices/ipod/ipod.pro
-+++ b/src/mediadevices/ipod/ipod.pro
-@@ -12,7 +12,8 @@
- linux* {
- LIBS += -lgpod
-
-- INCLUDEPATH += /usr/include/gpod-1.0 /usr/include/glib-2.0 /usr/lib/glib-2.0/include /usr/lib64/glib-2.0/include
-+ INCLUDEPATH += /usr/include/gpod-1.0 /usr/include/glib-2.0 /usr/lib/glib-2.0/include /usr/lib64/glib-2.0/include \
-+ /usr/local/include/gpod-1.0 /usr/local/include/glib-2.0
- }
-
- mac {
--- a/src/output/RtAudio/RtAudio.pro
+++ b/src/output/RtAudio/RtAudio.pro
@@ -8,10 +8,6 @@
diff -Nru lastfm-1.5.4.27091+dfsg/debian/patches/dirpaths.diff lastfm-1.5.4.27091+dfsg/debian/patches/dirpaths.diff
--- lastfm-1.5.4.27091+dfsg/debian/patches/dirpaths.diff 2010-12-06 21:34:59.000000000 -0800
+++ lastfm-1.5.4.27091+dfsg/debian/patches/dirpaths.diff 2011-04-09 01:13:55.000000000 -0700
@@ -1,6 +1,8 @@
Fix up icon installation path for Linux packages.
---- a/src/libMoose/MooseCommon.cpp
-+++ b/src/libMoose/MooseCommon.cpp
+Index: lastfm-1.5.4.27091+dfsg/src/libMoose/MooseCommon.cpp
+===================================================================
+--- lastfm-1.5.4.27091+dfsg.orig/src/libMoose/MooseCommon.cpp
++++ lastfm-1.5.4.27091+dfsg/src/libMoose/MooseCommon.cpp
@@ -47,7 +47,7 @@
QString
dataPath( QString file )
--- End Message ---
--- Begin Message ---
Source: lastfm
Source-Version: 1:1.5.4.27091+dfsg-4
We believe that the bug you reported is fixed in the latest version of
lastfm, which is due to be installed in the Debian FTP archive:
lastfm_1.5.4.27091+dfsg-4.debian.tar.gz
to main/l/lastfm/lastfm_1.5.4.27091+dfsg-4.debian.tar.gz
lastfm_1.5.4.27091+dfsg-4.dsc
to main/l/lastfm/lastfm_1.5.4.27091+dfsg-4.dsc
lastfm_1.5.4.27091+dfsg-4_amd64.deb
to main/l/lastfm/lastfm_1.5.4.27091+dfsg-4_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
John Stamp <[email protected]> (supplier of updated lastfm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 11 Apr 2011 16:14:56 -0700
Source: lastfm
Binary: lastfm
Architecture: source amd64
Version: 1:1.5.4.27091+dfsg-4
Distribution: unstable
Urgency: low
Maintainer: John Stamp <[email protected]>
Changed-By: John Stamp <[email protected]>
Description:
lastfm - a music player for Last.fm personalized radio
Closes: 621832
Changes:
lastfm (1:1.5.4.27091+dfsg-4) unstable; urgency=low
.
* debian/patches/build-fixes.diff: use pkg-config instead of hard-coding
include paths for glib-2.0 and libgpod. Closes: #621832, LP: #749089.
* debian/patches/build-kfreebsd.diff: drop references to /usr/local, which
have nothing at all to do with a kfreebsd build.
* Clean the architecture dependent stuff in Build-Depends
Checksums-Sha1:
bea9854787829ac818ed61adb2040a387773fd43 1304 lastfm_1.5.4.27091+dfsg-4.dsc
942a3aa373f58820e6997c19a37bfb260c5ac937 69391
lastfm_1.5.4.27091+dfsg-4.debian.tar.gz
095c9df3ddd28967692887b9774867e56cf347ad 1728252
lastfm_1.5.4.27091+dfsg-4_amd64.deb
Checksums-Sha256:
d1d195ad4aab8faca1c13986793fae83910759d898b60b89d9d100363eae80ed 1304
lastfm_1.5.4.27091+dfsg-4.dsc
f31f332ce99a73fa9fb3e9b4e8929557e10d772e637674a01401142d45a38aa8 69391
lastfm_1.5.4.27091+dfsg-4.debian.tar.gz
4dba599754be62412f8be77bbdfa46d49cbf16fae4198d1000fa232a3cf880db 1728252
lastfm_1.5.4.27091+dfsg-4_amd64.deb
Files:
dad7b9e873731d09b76f2281cecf1cc2 1304 sound optional
lastfm_1.5.4.27091+dfsg-4.dsc
8ef80ca33c1b14f45ffc33fcb4c8d89f 69391 sound optional
lastfm_1.5.4.27091+dfsg-4.debian.tar.gz
1235a6ea9eeac7576e4f166688da317e 1728252 sound optional
lastfm_1.5.4.27091+dfsg-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk2jjbsACgkQbU7/TZgP4UTOOgCeJyTg1Z385R3TTac9qQIH0BRu
IS4AoJaFN+gBTvmld/2Y9SvJHX/wfBfc
=OkfO
-----END PGP SIGNATURE-----
--- End Message ---
