Your message dated Sun, 29 May 2011 11:33:44 +0000
with message-id <[email protected]>
and subject line Bug#627644: fixed in gpdftext 0.1.5-1
has caused the Debian Bug report #627644,
regarding Please add support for newer poppler
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
627644: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=627644
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gpdftext
Version: 0.1.4-1
Severity: important
Tags: patch
User: [email protected]
Usertags: poppler-0.16
Hi Neil,
the current package of gpdftext ftbfs with poppler 0.16.3 from
experimental [1].
It is basically a typo: the configure check uses HAVE_POPPLER_1_4_1 vs
HAVE_POPPLER_0_14_1 in the source code.
As poppler provides a handy version check macro POPPLER_CHECK_VERSION
you can actually get rid of the configure check altogether.
The attached patch uses this macro.
As we would like to start the poppler transition soon we would
appreciate if you could upload a fixed package soon, as this will make
it easier because the package is then binNMUable.
@ Pino: [2] says that y cords don't need to be inverted
for poppler_page_get_selected_text(). So I'm wondering if the existing
code is actually correct in this regard, i.e. can we simply pass
queue->rect to both poppler_page_get_selected_text() and
poppler_page_get_text() or do we need to handle that differently?
I'd appreciate your review, Pino.
Cheers,
Michael
[1] http://www.teco.edu/~biebl/log-poppler-0.16/gpdftext.log
[2]
http://cgit.freedesktop.org/poppler/poppler/commit/?id=b257428150e2c13dcc24fd8f75e4ee2c679ab414
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.39-1-486
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Index: gpdftext-0.1.4/src/pdf.c
===================================================================
--- gpdftext-0.1.4.orig/src/pdf.c 2011-05-23 08:47:44.330188694 +0200
+++ gpdftext-0.1.4/src/pdf.c 2011-05-23 08:51:45.779153271 +0200
@@ -407,10 +407,10 @@
poppler_page_get_size (PDFPage, &width, &height);
queue->rect->x2 = width;
queue->rect->y2 = height;
-#ifdef HAVE_POPPLER_1_4_1
+#if POPPLER_CHECK_VERSION(0, 15, 1)
page = poppler_page_get_selected_text (PDFPage, POPPLER_SELECTION_LINE, queue->rect);
#else
- page = poppler_page_get_text (PDFPage, POPPLER_SELECTION_LINE, queue->rect);
+ page = poppler_page_get_text (PDFPage, POPPLER_SELECTION_LINE, queue->rect);
#endif
set_text (queue->ebook, page, queue->lines, queue->pagenums, queue->hyphens);
g_free (page);
--- End Message ---
--- Begin Message ---
Source: gpdftext
Source-Version: 0.1.5-1
We believe that the bug you reported is fixed in the latest version of
gpdftext, which is due to be installed in the Debian FTP archive:
gpdftext_0.1.5-1.diff.gz
to main/g/gpdftext/gpdftext_0.1.5-1.diff.gz
gpdftext_0.1.5-1.dsc
to main/g/gpdftext/gpdftext_0.1.5-1.dsc
gpdftext_0.1.5-1_amd64.deb
to main/g/gpdftext/gpdftext_0.1.5-1_amd64.deb
gpdftext_0.1.5.orig.tar.gz
to main/g/gpdftext/gpdftext_0.1.5.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Neil Williams <[email protected]> (supplier of updated gpdftext package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 29 May 2011 11:42:49 +0100
Source: gpdftext
Binary: gpdftext
Architecture: source amd64
Version: 0.1.5-1
Distribution: unstable
Urgency: low
Maintainer: Neil Williams <[email protected]>
Changed-By: Neil Williams <[email protected]>
Description:
gpdftext - GTK+ text editor for ebook PDF files
Closes: 627644
Changes:
gpdftext (0.1.5-1) unstable; urgency=low
.
* New upstream release
* Fixes previous poppler version check to use macro from
poppler. (Closes: #627644)
Checksums-Sha1:
662946cc9e07a4b0c5462a7bde7b7c214accc47a 1377 gpdftext_0.1.5-1.dsc
6b3cec05a1d8ee820f086c2cdf6148e3b2530a4e 509924 gpdftext_0.1.5.orig.tar.gz
e03aaa83cce7a09f9b13ea78834aae7b32286dcd 2610 gpdftext_0.1.5-1.diff.gz
41c15e29ef1a18edfab4366f014de4a6c3f1a2e9 86104 gpdftext_0.1.5-1_amd64.deb
Checksums-Sha256:
8a51aac4ffb557fdba64e59bcde7740c89e871fe3c2dd1df3a44832d519362c0 1377
gpdftext_0.1.5-1.dsc
c99f018393796951b07b9e5c50525e6463eb63cdf2ac3ec6ab5eaf9da4641e61 509924
gpdftext_0.1.5.orig.tar.gz
efc48729a6e9743cb9242b547f1bba24b6ae0d249dfab03a74b33109db7c97fd 2610
gpdftext_0.1.5-1.diff.gz
d08c6d16de637c7bea2e87fc20bd27d60d70374ae8f068402a6d93313fde8c5d 86104
gpdftext_0.1.5-1_amd64.deb
Files:
8a9c5dc83aec8926ba7bcb21585048dd 1377 utils optional gpdftext_0.1.5-1.dsc
00414ed284a756dbad5de71925c4735c 509924 utils optional
gpdftext_0.1.5.orig.tar.gz
2044e69f70a86de6a0d9b4fcfc831059 2610 utils optional gpdftext_0.1.5-1.diff.gz
3a61751dfb06d9fb4f6cf320e5e16e03 86104 utils optional
gpdftext_0.1.5-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk3iKWcACgkQiAEJSii8s+OumgCg2VTRtMtXTvYTT/OdQL6JvL8t
tU4An0aJo8lqjAuwWN/RDF4tJNHZiV9Z
=QQ0m
-----END PGP SIGNATURE-----
--- End Message ---
