Your message dated Mon, 27 Jun 2011 14:47:50 +0000
with message-id <[email protected]>
and subject line Bug#573365: fixed in dsniff 2.4b1+debian-21
has caused the Debian Bug report #573365,
regarding dsniff: urlsnarf always shows the current time, even when reading 
from a pcap file.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
573365: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573365
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dsniff
Version: 2.4b1+debian-18
Severity: normal
Tags: patch

Although timestamps are available in pcap files, urlsnarf always uses
the current time for its output. Please apply the included patch that
fixes the behavior.

(The patch should apply cleanly on top of the dpatch stack that is part
of 2.4b1+debian-18.)

Cheers,
-Hilko

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dsniff depends on:
ii  libc6                         2.10.2-6   Embedded GNU C Library: Shared lib
ii  libdb4.6                      4.6.21-16  Berkeley v4.6 Database Libraries [
ii  libnet1                       1.1.4-2    library for the construction and h
ii  libnids1.21                   1.23-1.1   IP defragmentation TCP segment rea
ii  libpcap0.8                    1.0.0-6    system interface for user-level pa
ii  libssl0.9.8                   0.9.8m-2   SSL shared libraries
ii  openssl                       0.9.8m-2   Secure Socket Layer (SSL) binary a

Versions of packages dsniff recommends:
ii  libx11-6                      2:1.3.3-1  X11 client-side library

dsniff suggests no packages.

-- no debconf information
--- urlsnarf.c.orig	2010-03-10 21:40:46.000000000 +0100
+++ urlsnarf.c	2010-03-10 21:43:52.000000000 +0100
@@ -36,6 +36,7 @@
 u_short		Opt_dns = 1;
 int		Opt_invert = 0;
 regex_t	       *pregex = NULL;
+time_t          tt = 0;
 
 static void
 usage(void)
@@ -57,9 +58,12 @@
 {
 	static char tstr[32], sign;
 	struct tm *t, gmt;
-	time_t tt = time(NULL);
 	int days, hours, tz, len;
 	
+	if (!nids_params.filename) {
+		tt = time(NULL);
+	}
+	
 	gmt = *gmtime(&tt);
 	t = localtime(&tt);
 	
@@ -287,14 +291,33 @@
 	
 	nids_register_tcp(sniff_http_client);
 
+	pcap_t *p;
+	char pcap_errbuf[PCAP_ERRBUF_SIZE];
         if (nids_params.pcap_filter != NULL) {
                 if (nids_params.filename == NULL) {
                         warnx("listening on %s [%s]", nids_params.device,
                               nids_params.pcap_filter);
+			p = pcap_open_offline(nids_params.filename, 
+					      pcap_errbuf);
+			if (!p) {
+				fprintf(stderr, "pcap_open_offline(%s): %s\n",
+					nids_params.filename, pcap_errbuf);
+			}
                 }
                 else {
                         warnx("using %s [%s]", nids_params.filename,
                               nids_params.pcap_filter);
+			/* adapted from libnids.c:open_live() */
+			if (strcmp(nids_params.device, "all") == 0)
+				nids_params.device = "any";
+			p = pcap_open_live(nids_params.device, 16384, 
+					   (nids_params.promisc != 0),
+					   0, pcap_errbuf);
+			if (!p) {
+				fprintf(stderr, "pcap_open_live(): %s\n",
+					pcap_errbuf);
+				exit(1);
+			}
                 }
         }
         else {
@@ -312,9 +335,24 @@
 
         nids_register_chksum_ctl(&chksum_ctl, 1);
 
-	nids_run();
-	
-	/* NOTREACHED */
+	struct pcap_pkthdr *h;
+	u_char *d;
+	int rc;
+	while ((rc = pcap_next_ex(p, &h, &d)) == 1) {
+		tt = h->ts.tv_sec;
+		nids_pcap_handler(NULL, h, d);
+	}
+	switch (rc) {
+	case(-2): /* end of pcap file */
+	case(0):  /* timeout on live capture */
+		break;
+	case(-1):
+	default:
+		fprintf(stderr, "rc = %i\n", rc);
+		pcap_perror(p, "pcap_read_ex()");
+		exit(1);
+		break;
+	}
 	
 	exit(0);
 }

--- End Message ---
--- Begin Message ---
Source: dsniff
Source-Version: 2.4b1+debian-21

We believe that the bug you reported is fixed in the latest version of
dsniff, which is due to be installed in the Debian FTP archive:

dsniff_2.4b1+debian-21.debian.tar.gz
  to main/d/dsniff/dsniff_2.4b1+debian-21.debian.tar.gz
dsniff_2.4b1+debian-21.dsc
  to main/d/dsniff/dsniff_2.4b1+debian-21.dsc
dsniff_2.4b1+debian-21_amd64.deb
  to main/d/dsniff/dsniff_2.4b1+debian-21_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
William Vera <[email protected]> (supplier of updated dsniff package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 15 Jun 2011 00:43:02 -0500
Source: dsniff
Binary: dsniff
Architecture: source amd64
Version: 2.4b1+debian-21
Distribution: unstable
Urgency: low
Maintainer: William Vera <[email protected]>
Changed-By: William Vera <[email protected]>
Description: 
 dsniff     - Various tools to sniff network traffic for cleartext insecurities
Closes: 548478 573365
Changes: 
 dsniff (2.4b1+debian-21) unstable; urgency=low
 .
   * Changed patch system to quilt from dpatch.
   * Updated debian/README.source for quilt.
   * Removed lintian override.
   * Cleanup the debian/rules.
   * Build-Depend changed to libdb-dev (>= 4.7) (Closes: #548478).
   * Added urlsnarf patch (Closes: #573365).
      + Thanks Hilko Bengen.
Checksums-Sha1: 
 24079eb7243a6d0e1080fe7cc0fb5c6067f6c75c 1147 dsniff_2.4b1+debian-21.dsc
 1896db7bffa1a5709d14e984bf65b7bd2ba8bf77 24177 
dsniff_2.4b1+debian-21.debian.tar.gz
 7d8a9e1f6269826f3af5ad9d131ec4d826110327 136068 
dsniff_2.4b1+debian-21_amd64.deb
Checksums-Sha256: 
 8bca5e40bf0e3c2503c21ca92a4f864464ea708f698e97d0aab8987bcd78a2c2 1147 
dsniff_2.4b1+debian-21.dsc
 c1766356c404db97c357b81abb9cbf205aab9fcfdd23dcd179a3887a0d4eb3ba 24177 
dsniff_2.4b1+debian-21.debian.tar.gz
 663b8250881e72a356ef8d70e37984fb243c6821fb37273b2eb077461dac5877 136068 
dsniff_2.4b1+debian-21_amd64.deb
Files: 
 6642e6bcc5585cc3a0d003d47ee179b2 1147 net extra dsniff_2.4b1+debian-21.dsc
 5cf3962b6634d4a03abe1d3d116412ee 24177 net extra 
dsniff_2.4b1+debian-21.debian.tar.gz
 d33f6a5bf108ee3824e8962d15263bae 136068 net extra 
dsniff_2.4b1+debian-21_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOCI63vdkzt4X+wX8RAuFeAJ93PsoAgOpnOb3DCdLcmPPLwvvJgACeIIz7
Lmk8EUCfbJSss2WcB6jCbS8=
=SN7C
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to