Your message dated Sun, 24 Jul 2011 05:02:20 +0000
with message-id <[email protected]>
and subject line Bug#538832: fixed in quilt-el 0.48.0-1
has caused the Debian Bug report #538832,
regarding quilt-el: It doesn't byte-compile cleanly.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
538832: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538832
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: quilt-el
Version: 0.45.4-1
Severity: minor
Hi,
I looked at this code in order to see about packaging it, before
realizing that it was already packaged. I have a few suggestions that
you can forward to the upstream maintainer.
It is in general okay, but far from checkdoc clean. Open it in Emacs
and run:
M-x checkdoc
to see where.
Also, it defines `C-c.' keys discouraged by elisp coding conventions. From
the elisp manual:
: D.2 Key Binding Conventions
: ===========================
:
: * Sequences consisting of `C-c' followed by a control character or a
: digit are reserved for major modes.
:
: * Sequences consisting of `C-c' followed by `{', `}', `<', `>', `:'
: or `;' are also reserved for major modes.
:
: * Sequences consisting of `C-c' followed by any other punctuation
: character are allocated for minor modes. Using them in a major
: mode is not absolutely prohibited, but if you do that, the major
: mode binding may be shadowed from time to time by minor modes.
I suggest the prefix `C-cC-c' instead.
It doesn't byte-compile cleanly:
: In quilt-editable:
: quilt.el:125:28:Warning: reference to free variable `quilt-edit-top-only'
:
: In quilt-header-commit:
: quilt.el:399:9:Warning: reference to free variable `quilt-header-directory'
:
: In quilt-edit-header:
: quilt.el:425:23:Warning: assignment to free variable `quilt-header-directory'
: quilt.el:426:23:Warning: assignment to free variable `mode-map'
:
: In end of data:
: quilt.el:500:1:Warning: the following functions are not known to be
: defined: to-alist, editable, revert-or-hook-buffer, revert,
: revert-list
This very last one is more important. The code has many embedded
`defun' function definitions, which won't byte-compile, and which will
pollute emacs once they get evaluated. I would prefix them all with
"quilt-" and place them at top level (i.e. not embbeded in code).
Lastly, /etc/emacs/site-start.d/50quilt-el.el should check that the
package is actually installed prior to setting up the package, since
that config file may be there after a package is removed but not purged.
I suggest to test if /usr/share/emacs/site-lisp/quilt-el/quilt.el is
present.
All of these issues can be easily addressed.
Thanks,
--
Peter S. Galbraith, Debian Developer <[email protected]>
http://people.debian.org/~psg
GPG key 1024/D2A913A1 - 97CE 866F F579 96EE 6E68 8170 35FF 799E
--- End Message ---
--- Begin Message ---
Source: quilt-el
Source-Version: 0.48.0-1
We believe that the bug you reported is fixed in the latest version of
quilt-el, which is due to be installed in the Debian FTP archive:
quilt-el_0.48.0-1.diff.gz
to main/q/quilt-el/quilt-el_0.48.0-1.diff.gz
quilt-el_0.48.0-1.dsc
to main/q/quilt-el/quilt-el_0.48.0-1.dsc
quilt-el_0.48.0-1_all.deb
to main/q/quilt-el/quilt-el_0.48.0-1_all.deb
quilt-el_0.48.0.orig.tar.gz
to main/q/quilt-el/quilt-el_0.48.0.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Satoru Takeuchi <[email protected]> (supplier of updated quilt-el
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 23 Jul 2011 22:49:10 +0900
Source: quilt-el
Binary: quilt-el
Architecture: source all
Version: 0.48.0-1
Distribution: unstable
Urgency: low
Maintainer: Satoru Takeuchi <[email protected]>
Changed-By: Satoru Takeuchi <[email protected]>
Description:
quilt-el - simple Emacs interface of quilt
Closes: 484697 538832
Changes:
quilt-el (0.48.0-1) unstable; urgency=low
.
* New upstream release
* Make it checkdoc clean (Closes: #484697)
* Make it byte-compile clean (Closes: #538832)
* Change upstream URL
* Update Standards-version to 3.9.2
* Build-Depends on debhelper (>= 8)
* Depends on quilt (>= 0.48) and ${misc:Depends}
* Change Section to lisp
* Add "Uploaders" to debian/control
Checksums-Sha1:
123e0b5e74fc2c9811577ec00d218f2444771314 1701 quilt-el_0.48.0-1.dsc
dd4f4bca45a6db055d4b3e2ec25d1cc1cc3621ec 13147 quilt-el_0.48.0.orig.tar.gz
eb28cde360fa90d9a0366d6c701d7e84e60bc3fc 3177 quilt-el_0.48.0-1.diff.gz
e981e64c562a0af4bd3da5095280d44cb10dc372 10822 quilt-el_0.48.0-1_all.deb
Checksums-Sha256:
c0120a686f79c3279fc5dcbeaa43e6b80c612e6ccd3d5cc9215061156ea8cc3b 1701
quilt-el_0.48.0-1.dsc
6c7a80d7f121d4958e989ad98065667d328905b893551f2f3e6f56449506ad24 13147
quilt-el_0.48.0.orig.tar.gz
4dc5506855f8af91ac0edabf9710f46d3169da8984026dcc00af47380402aaf9 3177
quilt-el_0.48.0-1.diff.gz
5504c42a933f4102a55cd7012197dad962ebaa011b40515876c324a3b7281ab3 10822
quilt-el_0.48.0-1_all.deb
Files:
9fe5619b2384f57b97dc45686be04cda 1701 lisp optional quilt-el_0.48.0-1.dsc
a1b9724f81c72bc19d1bdfa5abc1af40 13147 lisp optional
quilt-el_0.48.0.orig.tar.gz
728367dd3e8f5e114cb5f1198b551220 3177 lisp optional quilt-el_0.48.0-1.diff.gz
e229108b19ffbd4f9a34aedbfa788dca 10822 lisp optional quilt-el_0.48.0-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJOK5+oAAoJEOXvq5AIDqY8WXkP/0654G9Ff9lnq9ZFJ/b02x7M
JCNIIzzvPHa++ifG3bb+iqXTTyspE9TAe+jfRB51yXuUBWDCiy0TJvdPqzVr4d+s
ihmDzr14tTgdR510z92AbTreCmhb5Hh1rnznmMDXFkcgq/dA0F8rpcK7igJYsODF
tXa9JpUPcXQxj4FQWVF6Ptfq3pJ46wOfo+Iuy3QJLco1l+/kb7Emo2DdXmYNheyn
gj0/8ZFL9NQC9DA4reqzmCOSBAnuq/7O4d38kVWAm2ySrRJC45TVpov+WHrWO4Tb
bzqpzQryLfVTO2rph03aBT1khqaHqL7lsTzsGzMrXCGf3QafL5VJd/zyZOmd/RkO
CDq83npvfG/+0Ja7MZwN7lENMr3meLTYmpcjbvsv3peOg5oSsw/W4IdvNFMqxBQq
bj0p6ZKoRMqJ3XSfxV2LSTnUFHGvNfXNwNqimbf054FVxGitpv9f3WNeXRKdqMZY
FlRIg2yw0m6BeyEpMo+Vm3Uar+aLSg2rpQeUCYLqjRn8MKItX4IqnAlPLc8SgiO7
t7AwAGmFeX0OvWlqwdhxc/TXw+8aUME2CG2gmf6tF+kH3MCQUEqCRgnQUNRtSYSo
vx3ANtPYNKmqDYR3YpC1XzRWVj/msN8Br8jAqNQwTv7iU58zI2V74PLar4nsQNwh
Xv5kkCQ3fUivRYhmf/5f
=+Pck
-----END PGP SIGNATURE-----
--- End Message ---
