Your message dated Thu, 4 Aug 2011 11:09:45 +0100
with message-id <[email protected]>
and subject line Fixed in 2.0-4
has caused the Debian Bug report #636365,
regarding libnet-jabber-perl: FTBFS with perl 5.14: Debian modification to 
t/2_client.t
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
636365: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=636365
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libnet-jabber-perl
Version: 2.0-3.1
Severity: important
Tags: patch
User: [email protected]
Usertags: perl-5.14-transition

This package FTBFS with perl 5.14:

You tried to run a test without a plan!  Gotta have a plan. at 
t/lib/Test/More.pm line 691
BEGIN failed--compilation aborted at t/2_client.t line 6.
# Looks like your test died before it could output anything.
t/2_client.t .................. 
Dubious, test returned 255 (wstat 65280, 0xff00)

As patched, the Debian version of this test script starts:

use lib "t/lib";
use Test::More;

plan skip_all => 'Disabled for the Debian build';

BEGIN { use_ok( "Net::Jabber" ); }

In perl 5.14, the use_ok happens before the 'plan skip_all', since it
is in a BEGIN block. (This is as I expect. I'm not sure why this doesn't
happen in perl 5.12.)

Instead, skip all tests in the 'use Test::More' line instead.

Patch attached. As I notice this package hasn't had a maintainer
update for a while, do let me know if you would prefer this package
to be adopted by the Debian Perl group instead, or NMUd (or neither).



--- End Message ---
--- Begin Message ---
Version: 2.0-4

   [ Dominic Hargreaves ]
   * Fix FTBFS with perl 5.14 with our patched t/2_client.t: skip tests
     in the Test::More 'use' line rather than later, so that it takes
     effect before the use_ok in the BEGIN block

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)


--- End Message ---

Reply via email to