Your message dated Fri, 12 Aug 2011 17:32:57 +0000
with message-id <[email protected]>
and subject line Bug#637548: fixed in virt-viewer 0.4.1-2
has caused the Debian Bug report #637548,
regarding virt-viewer: should not hardcode SSH port 22, but read from 
~/.ssh/config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
637548: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=637548
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: virt-viewer
Version: 0.4.0-1
Severity: important
Tags: upstream
Usertags: pca-virtualization

Hi there!

0.4.0-1 is supposed to solve this issue thanks to:

  
<http://anonscm.debian.org/gitweb/?p=pkg-libvirt/virt-viewer.git;a=commitdiff;h=2376c067bd80cf68c425d51982deece3e6129e1a>

However, it seems this is not enough, given that I get the following:
=====
luca@gismo:~$ virt-viewer --debug --connect qemu+ssh://mantissa.pca.it/system 
shelob.pca.it
** (virt-viewer:13938): DEBUG: Opening connection to libvirt with URI 
qemu+ssh://mantissa.pca.it/system

** (virt-viewer:13938): DEBUG: Add handle 6 1 0x1b86250
Enter passphrase for key '/home/luca/.ssh/id_rsa':
** (virt-viewer:13938): DEBUG: Add timeout 0x1b88340 -1 0x7f4d89cf4610 
0x1b87fc0 1
** (virt-viewer:13938): DEBUG: Guest shelob.pca.it is running, determining 
display

** (virt-viewer:13938): DEBUG: Guest shelob.pca.it has a vnc display

** (virt-viewer:13938): DEBUG: Guest graphics address is localhost:5900
** (virt-viewer:13938): DEBUG: Opening indirect TCP connection to display at 
localhost:5900

** (virt-viewer:13938): DEBUG: Setting up SSH tunnel via 
(null)@mantissa.pca.it:22

Bad port '0'
** (virt-viewer:13938): DEBUG: Display size request 50x50 (desktop 100x100)
** (virt-viewer:13938): DEBUG: Allocated 1022x739
** (virt-viewer:13938): DEBUG: Child allocate 739x739
** (virt-viewer:13938): DEBUG: Guest shelob.pca.it display has disconnected, 
shutting down

luca@gismo:~$ virt-viewer --debug --connect 
qemu+ssh://mantissa.pca.it:22023/system shelob.pca.it
[...]
** (virt-viewer:13954): DEBUG: Guest graphics address is localhost:5900
** (virt-viewer:13954): DEBUG: Opening indirect TCP connection to display at 
localhost:5900

** (virt-viewer:13954): DEBUG: Setting up SSH tunnel via 
(null)@mantissa.pca.it:22023

** (virt-viewer:13954): DEBUG: Display size request 50x50 (desktop 100x100)
** (virt-viewer:13954): DEBUG: Allocated 1022x739
** (virt-viewer:13954): DEBUG: Child allocate 739x739
** (virt-viewer:13954): DEBUG: desktop resize 720x400
** (virt-viewer:13954): DEBUG: Preparing main window resize
** (virt-viewer:13954): DEBUG: Decided todo 720x400 (desktop is 720x400, 
fullscreen is 1024x768
** (virt-viewer:13954): DEBUG: Display size request 720x400 (desktop 720x400)
** (virt-viewer:13954): DEBUG: Allocated 1022x739
** (virt-viewer:13954): DEBUG: Child allocate 1022x567
** (virt-viewer:13954): DEBUG: Display size request 50x50 (desktop 720x400)
** (virt-viewer:13954): DEBUG: Allocated 1022x739
** (virt-viewer:13954): DEBUG: Child allocate 1022x567

luca@gismo~$
=====

Once again, the error reported is completely misleading, something that
seems to be a constant with libvirt-related packages :-(

Anyway, the same is true for 0.4.1-1, except for the fact that
specifying the SSH port does not work anymore, bingo!  Have I already
said that I hate when someone tries to be smarter than my config files?

Despite myself not being an expert programmer, there are two problems:

1) in src/virt-viewer-app.c:322 the ssh -p switch should be used only if
   the SSH port is defined, reflecting src/virt-viewer-app.c:327.
   Fixing this was enough to have virt-viewer working with my
   ~/.ssh/config, because...

2) in src/virt-viewer-app.c:1093 the SSH port is always set to 0,
   completely ignoring the value specified in the URI.

Together with those, the function virt_viewer_app_open_tunnel_ssh in
src/virt-viewer-app.c is a bit "problematic", given that global
variables like host, port and user, defined for SSH, are actually
redefined for the nc tunnel.

I will send a patch fixing this mess once this bug has got a number.
Feel free to forward it to upstream, as it is or modified.  The license
is the same as virt-viewer ;-)

Thx, bye,
Gismo / Luca

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages virt-viewer depends on:
ii  libc6                       2.13-15      Embedded GNU C Library: Shared lib
ii  libgdk-pixbuf2.0-0          2.23.5-3     GDK Pixbuf library
ii  libglib2.0-0                2.28.6-1     The GLib library of C routines
ii  libgtk-vnc-1.0-0            0.4.3-4.1    VNC viewer widget for GTK+2 (runti
ii  libgtk2.0-0                 2.24.5-4     GTK+ graphical user interface libr
ii  libvirt0                    0.9.4~rc1-1  library for interfacing with diffe
ii  libxml2                     2.7.8.dfsg-4 GNOME XML library

virt-viewer recommends no packages.

Versions of packages virt-viewer suggests:
ii  netcat-openbsd [netcat]       1.89-4     TCP/IP swiss army knife
ii  netcat-traditional [netcat]   1.10-39    TCP/IP swiss army knife

-- no debconf information

Attachment: pgpf1ddvleSp6.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: virt-viewer
Source-Version: 0.4.1-2

We believe that the bug you reported is fixed in the latest version of
virt-viewer, which is due to be installed in the Debian FTP archive:

virt-viewer_0.4.1-2.debian.tar.gz
  to main/v/virt-viewer/virt-viewer_0.4.1-2.debian.tar.gz
virt-viewer_0.4.1-2.dsc
  to main/v/virt-viewer/virt-viewer_0.4.1-2.dsc
virt-viewer_0.4.1-2_i386.deb
  to main/v/virt-viewer/virt-viewer_0.4.1-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <[email protected]> (supplier of updated virt-viewer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 12 Aug 2011 19:16:05 +0200
Source: virt-viewer
Binary: virt-viewer
Architecture: source i386
Version: 0.4.1-2
Distribution: unstable
Urgency: low
Maintainer: Debian Libvirt Maintainers 
<[email protected]>
Changed-By: Guido Günther <[email protected]>
Description: 
 virt-viewer - Displaying the graphical console of a virtual machine
Closes: 637548
Changes: 
 virt-viewer (0.4.1-2) unstable; urgency=low
 .
   * [3c6e6de] Build against GTK+3
   * [599a1e1] Really fix using alternate ssh ports. Many,many thanks to Luca
     Capello for debugging this and for providing a patch. (Closes: #637548)
Checksums-Sha1: 
 30346c7641206abdd0ae57845631897622602137 1461 virt-viewer_0.4.1-2.dsc
 c4d984c195671beb07dca76237b8cd9841dc1c46 4146 virt-viewer_0.4.1-2.debian.tar.gz
 1703dbd19a14a22fe665492c414f2e626b6a9cfc 99624 virt-viewer_0.4.1-2_i386.deb
Checksums-Sha256: 
 f9a5201f81706ceaae0f44782b680990b4e2a087598240a84e266e72fa8c6f91 1461 
virt-viewer_0.4.1-2.dsc
 73bfe0241b19918176daabfa2a5e3a73d88966cdc3bf4a65c56e616a4bec1057 4146 
virt-viewer_0.4.1-2.debian.tar.gz
 ae4d53e22b66ccc07620380dc068f7f13aa73ffe0ae5bfcedda875dc4e8d7ed2 99624 
virt-viewer_0.4.1-2_i386.deb
Files: 
 6c68fd669fc3f63cf9e605745088ff6f 1461 admin extra virt-viewer_0.4.1-2.dsc
 604ddc92a88ba353a93805148ae1d7cf 4146 admin extra 
virt-viewer_0.4.1-2.debian.tar.gz
 181e6e4b757140f8886e4528b1023ddd 99624 admin extra virt-viewer_0.4.1-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFORWHwn88szT8+ZCYRAhzCAJ441QPYO3Pk8MiQPRkic3P5lNoinwCfU8mt
hgXaSl5QlKhLCNgXaGAez4M=
=0Efn
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to