Your message dated Mon, 15 Aug 2011 16:04:32 +0000
with message-id <[email protected]>
and subject line Bug#601758: fixed in yafc 1.1.1.dfsg.1-4.1
has caused the Debian Bug report #601758,
regarding yafc: Resolved FTBFS/porting for GNU/kFreeBSD.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
601758: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601758
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: yafc
Version: 1.1.1.dfsg.1-4
Severity: important
Tags: patch
The building of Yafc for GNU/kFreeBSD fails due to missing
<termio.h> in FreeBSD and GNU/kFreeBSD. The following patch
suggests a migration away from the obsolete <termio.h> also
on GNU/Linux, and it also implements the necessary adaptions
for GNU/kFreeBSD, due to differing ioctl-calls.
Observe also that the manpage termios(3) is inaccurate
on GNU/kFreeBSD, since it mentions the invalid constants
OLCUC and IUCLC, of which the latter has to be covered
for in the present package.
I have tested the executable 'yafc' with 'kfreebsd-i386'
and 'amd64'. It works for FTP as well as for SSH.
Best regards,
Mats Erik Andersson, fil. dr
2459 41E9 C420 3F6D F68B 2E88 F768 4541 F25B 5D41
Description: Use termios for terminal settings.
A migration to <termios.h> will prepare adaptions
for GNU/kFreeBSD. The old <termio.h> is obsolete.
.
The ioctl-calls have different names in GNU/Linux
and GNU/kFreeBSD, so they must be redefined.
.
The implementation in FreeBSD and GNU/kFreeBSD lacks
IUCLC and OLCUC, as they are not POSIX specified.
Author: Mats Erik Andersson <[email protected]>
Forwarded: no
Last-Update: 2010-10-29
--- yafc-1.1.1.dfsg.1/src/input.c.orig
+++ yafc-1.1.1.dfsg.1/src/input.c
@@ -76,7 +76,20 @@
# include <fcntl.h>
# include <sys/ioctl.h>
-# include <termio.h>
+# include <termios.h>
+
+# if __FreeBSD_kernel__
+# ifndef IUCLC
+ /* Not implemented in FreeBSD 8.0! */
+# define IUCLC 0
+# endif
+# ifndef TCGETS
+# define TCGETS TIOCGETA
+# endif
+# ifndef TCSETS
+# define TCSETS TIOCGETA
+# endif
+# endif /* __FreBSD_kernel__ */
char *getpass_hook(const char *prompt)
{
@@ -89,14 +102,14 @@
#else
int c, n = 0;
char tmp[1024];
- struct termio tbuf, tbufsave;
+ struct termios tbuf, tbufsave;
FILE *fd;
if((fd = fopen("/dev/tty", "rb")) == NULL) {
perror("fopen /dev/tty");
return NULL;
}
- if (ioctl(fileno(fd), TCGETA, &tbuf) < 0) {
+ if (ioctl(fileno(fd), TCGETS, &tbuf) < 0) {
perror("ioctl get");
fclose(fd);
return NULL;
@@ -105,7 +118,7 @@
tbuf.c_iflag &= ~(IUCLC | ISTRIP | IXON | IXOFF);
tbuf.c_lflag &= ~(ICANON | ISIG | ECHO);
tbuf.c_cc[4] = 1; /* MIN */
- if (ioctl(fileno(fd), TCSETA, &tbuf) < 0) {
+ if (ioctl(fileno(fd), TCSETS, &tbuf) < 0) {
perror("ioctl set");
fclose(fd);
return NULL;
@@ -132,7 +145,7 @@
fflush(stderr);
}
tmp[n] = '\0';
- if (ioctl(fileno(fd), TCSETA, &tbufsave) < 0) {
+ if (ioctl(fileno(fd), TCSETS, &tbufsave) < 0) {
perror("ioctl restore");
fclose(fd);
return NULL;
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: yafc
Source-Version: 1.1.1.dfsg.1-4.1
We believe that the bug you reported is fixed in the latest version of
yafc, which is due to be installed in the Debian FTP archive:
yafc_1.1.1.dfsg.1-4.1.diff.gz
to main/y/yafc/yafc_1.1.1.dfsg.1-4.1.diff.gz
yafc_1.1.1.dfsg.1-4.1.dsc
to main/y/yafc/yafc_1.1.1.dfsg.1-4.1.dsc
yafc_1.1.1.dfsg.1-4.1_amd64.deb
to main/y/yafc/yafc_1.1.1.dfsg.1-4.1_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sebastian Ramacher <[email protected]> (supplier of updated yafc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 04 Aug 2011 16:55:52 +0200
Source: yafc
Binary: yafc
Architecture: source amd64
Version: 1.1.1.dfsg.1-4.1
Distribution: unstable
Urgency: low
Maintainer: Decklin Foster <[email protected]>
Changed-By: Sebastian Ramacher <[email protected]>
Description:
yafc - yet another FTP client
Closes: 553874 601758 604190
Changes:
yafc (1.1.1.dfsg.1-4.1) unstable; urgency=low
.
* Non-maintainer upload.
* Change Build-Dep libreadline5-dev to libreadline-dev. (Closes: #553874)
* Add patch from Mats Erik Andersson to fix FTBFS on GNU/kFreeBSD. (Closes:
#601758)
* Add patch from Lionel Landwerlin to fix wrong usage of strcpy. (Closes:
#604190)
Checksums-Sha1:
d1f1171f37c28316e3dde5f6c125068da8b6b1f6 1028 yafc_1.1.1.dfsg.1-4.1.dsc
bbc15c06b8d322e729164dfc264708050cf3a739 11446 yafc_1.1.1.dfsg.1-4.1.diff.gz
8fdc755185d1629cbb39a5bfbdd4413c6bf468d9 156076 yafc_1.1.1.dfsg.1-4.1_amd64.deb
Checksums-Sha256:
8db4974f163fb071e2262b642eb504b240f0c606b5862c8cc243e1b6ee0b71be 1028
yafc_1.1.1.dfsg.1-4.1.dsc
766c308aa4cfa4db71c27af4541cbb320efe83658700c7afe50c62e9312b332a 11446
yafc_1.1.1.dfsg.1-4.1.diff.gz
58d049881e3df6f4936e0b6fbc214d14a7a4c6489312b849f6e46b40c5f64f01 156076
yafc_1.1.1.dfsg.1-4.1_amd64.deb
Files:
bc38ae35e1f4b74f5f6df0b643bb5af9 1028 net optional yafc_1.1.1.dfsg.1-4.1.dsc
c12cbdd6f7608e5e6b5fdaa0c416619b 11446 net optional
yafc_1.1.1.dfsg.1-4.1.diff.gz
9ba8e5fa03e35dbf59f6be9ae13ffcc3 156076 net optional
yafc_1.1.1.dfsg.1-4.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFOPAq4vdkzt4X+wX8RAoYkAJ4nFVC7+veSCAMUvFLNy9JzKnCJkACfRF3t
10Hd9oEoR6NxXHYg5H9QEw8=
=0NSX
-----END PGP SIGNATURE-----
--- End Message ---
