Your message dated Thu, 25 Aug 2011 21:07:16 +0000
with message-id <[email protected]>
and subject line Bug#630627: fixed in vdr-plugin-live 0.2.0-14
has caused the Debian Bug report #630627,
regarding vdr-plugin-live IPv6 support correction
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
630627: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=630627
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: vdr-plugin-live
Version: 0.2.0-9
Hello,
I've randomly bumped into the bug report #496936 while seeking IPv6
support in VDR Live.
I don't use Debian's packages (I use VDR development versions), but the
IPv6 patch as seen in that bug report and as actually used in current
vdr-plugin-live packages has a problem.
The problem is it uses IPv6 '::' by default without checking for IPv6
support first - the user may have disabled support for this protocol, in
which case the plugin may not work.
The attached patch serves as a replacement for the previous one. It also
uses inet_pton ("the new API") even for IPv4.
--
Luboš Doležel
--- live-0.2.0/setup.cpp.orig 2008-04-23 01:01:53.000000000 +0200
+++ live-0.2.0/setup.cpp 2011-06-15 19:09:43.766160720 +0200
@@ -151,13 +151,28 @@
bool Setup::CheckServerIps()
{
+ bool v6supported = false;
+ int s = socket(AF_INET6, SOCK_STREAM, 0);
+
+ if (s != -1) {
+ close(s);
+ v6supported = true;
+ }
+
if ( m_serverIps.empty() ) {
- m_serverIps.push_back( "0.0.0.0" );
+ if (v6supported)
+ m_serverIps.push_back( "::" );
+ else
+ m_serverIps.push_back( "0.0.0.0" );
return true;
}
+ union {
+ sockaddr_in in4;
+ sockaddr_in6 in6;
+ };
for ( IpList::const_iterator ip = m_serverIps.begin(); ip != m_serverIps.end(); ++ip ) {
- if ( inet_addr( ip->c_str() ) == static_cast< in_addr_t >( -1 ) ) {
+ if ( !inet_pton(AF_INET, ip->c_str(), &in4) && !inet_pton(AF_INET6, ip->c_str(), &in6) ) {
esyslog( "ERROR: live server ip %s is not a valid ip address", ip->c_str() );
cerr << "ERROR: live server ip " << *ip << " is not a valid ip address" << endl;
return false;
--- End Message ---
--- Begin Message ---
Source: vdr-plugin-live
Source-Version: 0.2.0-14
We believe that the bug you reported is fixed in the latest version of
vdr-plugin-live, which is due to be installed in the Debian FTP archive:
vdr-plugin-live_0.2.0-14.debian.tar.gz
to main/v/vdr-plugin-live/vdr-plugin-live_0.2.0-14.debian.tar.gz
vdr-plugin-live_0.2.0-14.dsc
to main/v/vdr-plugin-live/vdr-plugin-live_0.2.0-14.dsc
vdr-plugin-live_0.2.0-14_amd64.deb
to main/v/vdr-plugin-live/vdr-plugin-live_0.2.0-14_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Tobias Grimm <[email protected]> (supplier of updated vdr-plugin-live package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 25 Aug 2011 22:09:52 +0200
Source: vdr-plugin-live
Binary: vdr-plugin-live
Architecture: source amd64
Version: 0.2.0-14
Distribution: unstable
Urgency: low
Maintainer: Debian VDR Team <[email protected]>
Changed-By: Tobias Grimm <[email protected]>
Description:
vdr-plugin-live - Web administration plugin for VDR
Closes: 630627 639079
Changes:
vdr-plugin-live (0.2.0-14) unstable; urgency=low
.
* Added 04_tntnet-2.0.patch to fix compatibility with Tntnet 2.0
(Closes: #639079)
.
vdr-plugin-live (0.2.0-13) unstable; urgency=low
.
* Build-depend on vdr-dev (>= 1.7.20)
* Standards-Version: 3.9.2
* Updated 01_ipv6.patch to the version provide by Luboš Doležel to support
IPV4-only systems (Closes: #630627)
Checksums-Sha1:
bdc90da6ed81bb667ac48c701d2756049e802416 1495 vdr-plugin-live_0.2.0-14.dsc
9978d1b304e49713b79e14841577c45ba189970a 8954
vdr-plugin-live_0.2.0-14.debian.tar.gz
3f90a219f26d30aad693a6eaee84173ce77fd11b 932186
vdr-plugin-live_0.2.0-14_amd64.deb
Checksums-Sha256:
6e0a07c40ac197c8f5b9bc208b107186c2a1e35fa72bd8503ff616a243b0b11a 1495
vdr-plugin-live_0.2.0-14.dsc
125cfa5d0d51ac32deba519ac58249aadd76ed0178d2c6016ee467f9e1540502 8954
vdr-plugin-live_0.2.0-14.debian.tar.gz
07a72dd6f3a73ee0968e587658e94e798b394f647fa3edfbff767f85fb2a7494 932186
vdr-plugin-live_0.2.0-14_amd64.deb
Files:
267e2eaab8237c1dd98c9b5355260ab5 1495 video extra vdr-plugin-live_0.2.0-14.dsc
f4d95e7c59d4dec431f5238ca94f3e86 8954 video extra
vdr-plugin-live_0.2.0-14.debian.tar.gz
d01d3bfe23bd7bc99618f771d00e07d9 932186 video extra
vdr-plugin-live_0.2.0-14_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk5WriIACgkQ9xgNJq7apkIGJwCfT7/sn4d+z3k/z1jsQu9Q6Bjf
mAYAniN1s4HIi5G0uS8R8Q/SZUqYFDab
=+8ac
-----END PGP SIGNATURE-----
--- End Message ---
