Your message dated Sat, 27 Aug 2011 04:03:07 +0000
with message-id <[email protected]>
and subject line Bug#638901: fixed in pidgin-libnotify 0.14-6
has caused the Debian Bug report #638901,
regarding [pidgin-libnotify] Make check for presence of my nick in chat message
optional
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
638901: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638901
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pidgin-libnotify
Version: 0.14-5+b1
Severity: normal
Tags: patch
--- Please enter the report below this line. ---
Upon receiving a new chat message, pidgin-libnotify checks whether my nick is
present in the message body
and only then lets the notification popup to be displayed. This is useful in
chatrooms with many
participants and high message traffic, buy might not be desirable in every
usage scenario.
As I often miss important messages because of this feature, I would really like
to make it optional.
Attached patch adds to the plugin two new configuration options, one for
disabling the check-for-a-nick and
second allowing to separately disable all notifications for chat messages, as
there was no such option before
(as a counterpart for disabling IM notifications).
Default values of both switches are set so that there will be no changes in
behavior of existing
installations, until user explicitly modifies the settings.
--- System information. ---
Architecture: amd64
Kernel: Linux 3.0.0-1-amd64
Debian Release: wheezy/sid
500 unstable ftp.cz.debian.org
500 unstable emdebian.org
500 testing www.debian-multimedia.org
500 testing security.debian.org
500 testing ftp.cz.debian.org
1 experimental ftp.debian.org
--- Package information. ---
Depends (Version) | Installed
==================================-+-============
libatk1.0-0 (>= 1.12.4) | 2.0.1-2
libc6 (>= 2.2.5) | 2.13-16
libcairo2 (>= 1.2.4) | 1.10.2-6.1
libfontconfig1 (>= 2.8.0) | 2.8.0-3
libfreetype6 (>= 2.2.1) | 2.4.6-1
libgdk-pixbuf2.0-0 (>= 2.22.0) | 2.23.5-3
libglib2.0-0 (>= 2.16.0) | 2.28.6-1
libgtk2.0-0 (>= 2.8.0) | 2.24.4-3
libnotify4 (>= 0.7.0) | 0.7.3-2
libpango1.0-0 (>= 1.14.0) | 1.28.4-1
pidgin (<< 3.0) | 2.9.0-3
pidgin (>= 2.9) | 2.9.0-3
Package's Recommends field is empty.
Package's Suggests field is empty.
From: Jakub Adam <[email protected]>
Date: Sat, 20 Aug 2011 22:16:09 +0200
Subject: chat-nick-test-optional.diff
Made check for nick in chat message optional
Signed-off-by: Jakub Adam <[email protected]>
---
src/pidgin-libnotify.c | 44 +++++++++++++++++++++++++++++++-------------
1 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/src/pidgin-libnotify.c b/src/pidgin-libnotify.c
index ab166d1..3317610 100644
--- a/src/pidgin-libnotify.c
+++ b/src/pidgin-libnotify.c
@@ -58,7 +58,17 @@ get_plugin_pref_frame (PurplePlugin *plugin)
ppref = purple_plugin_pref_new_with_name_and_label (
"/plugins/gtk/libnotify/newmsg",
- _("New messages"));
+ _("New IM messages"));
+ purple_plugin_pref_frame_add (frame, ppref);
+
+ ppref = purple_plugin_pref_new_with_name_and_label (
+ "/plugins/gtk/libnotify/newchat",
+ _("New chat messages"));
+ purple_plugin_pref_frame_add (frame, ppref);
+
+ ppref = purple_plugin_pref_new_with_name_and_label (
+ "/plugins/gtk/libnotify/chat_check_nick",
+ _("Notify chat only when someone says my username"));
purple_plugin_pref_frame_add (frame, ppref);
ppref = purple_plugin_pref_new_with_name_and_label (
@@ -466,20 +476,26 @@ notify_new_message_cb (PurpleAccount *account,
}
static void
-notify_chat_nick (PurpleAccount *account,
- const gchar *sender,
- const gchar *message,
- PurpleConversation *conv,
- gpointer data)
+notify_new_chat_cb (PurpleAccount *account,
+ const gchar *sender,
+ const gchar *message,
+ PurpleConversation *conv,
+ gpointer data)
{
- gchar *nick;
- nick = (gchar *)purple_conv_chat_get_nick (PURPLE_CONV_CHAT(conv));
- if (nick && !strcmp (sender, nick))
+ if (!purple_prefs_get_bool ("/plugins/gtk/libnotify/newchat"))
return;
- if (!g_strstr_len (message, strlen(message), nick))
- return;
+ if (purple_prefs_get_bool ("/plugins/gtk/libnotify/chat_check_nick")) {
+ gchar *nick;
+
+ nick = (gchar *)purple_conv_chat_get_nick (PURPLE_CONV_CHAT(conv));
+ if (nick && !strcmp (sender, nick))
+ return;
+
+ if (!g_strstr_len (message, strlen(message), nick))
+ return;
+ }
notify_msg_sent (account, sender, message);
}
@@ -510,7 +526,7 @@ plugin_load (PurplePlugin *plugin)
PURPLE_CALLBACK(notify_new_message_cb), NULL);
purple_signal_connect (conv_handle, "received-chat-msg", plugin,
- PURPLE_CALLBACK(notify_chat_nick), NULL);
+ PURPLE_CALLBACK(notify_new_chat_cb), NULL);
/* used just to not display the flood of guifications we'd get */
purple_signal_connect (conn_handle, "signed-on", plugin,
@@ -538,7 +554,7 @@ plugin_unload (PurplePlugin *plugin)
PURPLE_CALLBACK(notify_new_message_cb));
purple_signal_disconnect (conv_handle, "received-chat-msg", plugin,
- PURPLE_CALLBACK(notify_chat_nick));
+ PURPLE_CALLBACK(notify_new_chat_cb));
purple_signal_disconnect (conn_handle, "signed-on", plugin,
PURPLE_CALLBACK(event_connection_throttle));
@@ -595,6 +611,8 @@ init_plugin (PurplePlugin *plugin)
purple_prefs_add_none ("/plugins/gtk/libnotify");
purple_prefs_add_bool ("/plugins/gtk/libnotify/newmsg", TRUE);
+ purple_prefs_add_bool ("/plugins/gtk/libnotify/newchat", TRUE);
+ purple_prefs_add_bool ("/plugins/gtk/libnotify/chat_check_nick", TRUE);
purple_prefs_add_bool ("/plugins/gtk/libnotify/blocked", TRUE);
purple_prefs_add_bool ("/plugins/gtk/libnotify/newconvonly", FALSE);
purple_prefs_add_bool ("/plugins/gtk/libnotify/signon", TRUE);
--
--- End Message ---
--- Begin Message ---
Source: pidgin-libnotify
Source-Version: 0.14-6
We believe that the bug you reported is fixed in the latest version of
pidgin-libnotify, which is due to be installed in the Debian FTP archive:
pidgin-libnotify_0.14-6.debian.tar.gz
to main/p/pidgin-libnotify/pidgin-libnotify_0.14-6.debian.tar.gz
pidgin-libnotify_0.14-6.dsc
to main/p/pidgin-libnotify/pidgin-libnotify_0.14-6.dsc
pidgin-libnotify_0.14-6_amd64.deb
to main/p/pidgin-libnotify/pidgin-libnotify_0.14-6_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Varun Hiremath <[email protected]> (supplier of updated pidgin-libnotify package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 26 Aug 2011 23:35:52 -0400
Source: pidgin-libnotify
Binary: pidgin-libnotify
Architecture: source amd64
Version: 0.14-6
Distribution: unstable
Urgency: low
Maintainer: Varun Hiremath <[email protected]>
Changed-By: Varun Hiremath <[email protected]>
Description:
pidgin-libnotify - display notification bubbles in pidgin
Closes: 549265 635614 638899 638901 638902
Changes:
pidgin-libnotify (0.14-6) unstable; urgency=low
.
* debian/patches
- chat-nick-test-optional.diff, make nick presence optional (Closes:
#638901)
- fix-printf-warnings.diff , fix compiler warnings (Closes: #638899)
- fix-notify-osd.diff, fix notify issues (Closes: #635614, #549265)
- add-cs-translation.diff, add Czech translation (Closes: #638902)
* Thanks to Jakub Adam <[email protected]> for providing the above patches
Checksums-Sha1:
13658a7a5a8c5992003c45cd5162bbd53546a58f 1953 pidgin-libnotify_0.14-6.dsc
d5b1b0af946e9151fbd6b40c9d72ee6515d90c45 7877
pidgin-libnotify_0.14-6.debian.tar.gz
eaa4b74229ad7aa17c52fc2e0b1720fb1cb9640e 20944
pidgin-libnotify_0.14-6_amd64.deb
Checksums-Sha256:
23541f57237edd4aa3b3fc7bfeb272c104d0b12b6b0649b1f5e150070eb86e6d 1953
pidgin-libnotify_0.14-6.dsc
c32d1170476a3f2a76237ed8157b88af3f24145e2a362e09a153e820dc3874e5 7877
pidgin-libnotify_0.14-6.debian.tar.gz
3f8fd637a4234a00fc34e0e208927b3fe9476ca800776eb4e389f2d1dd38f1e6 20944
pidgin-libnotify_0.14-6_amd64.deb
Files:
b2a364fb8a3308d2821b3125614c7cfd 1953 net optional pidgin-libnotify_0.14-6.dsc
650f0e74d55247b4b0ba3429b964c71a 7877 net optional
pidgin-libnotify_0.14-6.debian.tar.gz
861bc5197c9c2c34e07b09c71e036fcc 20944 net optional
pidgin-libnotify_0.14-6_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIcBAEBCgAGBQJOWGqYAAoJEHA3PPEpDbnOk0oP/0FtFCfwpDKCGiaFkQyR+5Ri
Sswv6NJ50PlRkoXd0DA6x4+mdd1FrdJHsYblN/QbGXi0Qv6xcsK+Ik+N4yeWtxab
sUkb2+ZM7Hwd6POCYRXz+1qSM9TTq+OS6A3CPiZdwUMTHKEdJQhJEks0PqjdyuDf
BebX60qu3DatLhHVmRb+3Y5PhQru8c4dOOlPEC+JL0Dsb1YxvUJyTSAIOUgJniOn
7CFTuzSxBUhTjJ/Xezo9s1TRZerWnEJxIKmZlSAzMACc3QnEoeGIflKbn8y4pMPk
mGfP2e96AkyP81ilAQYJ4OGcYPdAFfNuK3lM/ccqPURJHPrSkkME2xB2vKo+rzkg
8BetM+Db8/KXgDrucX3w7kwV50w3DtifHVH15oJNATxzWaRaps7ySoliH0IE3K2C
dWxAPLdgGFheAEUrXZhWEI9lijby83Z3Iq3OhroWbIaV4GNSt3g1e8QHtQv+bA2P
i1z1Nd04Kj0g+xNOrPV0AoSjp2/x0rPvAlG7tJPQJH3I/ttpp5GNzbKmDBAnja8M
B3sdVK4/dQUp03rurEgfXanuQggOV8tcSGVrkLlRMgK1MlPHr882msq6Y9XLDuDe
tOInNY2ZuZXxZcK0EIT5cKiqS4QsgaGb08/N5yNYJgXfTInDhOT9i3BuEHTsPVtY
OEhbP2Y7ZgbyRtOV7K+d
=TpHR
-----END PGP SIGNATURE-----
--- End Message ---
