Your message dated Sun, 04 Sep 2011 19:48:34 +0000
with message-id <[email protected]>
and subject line Bug#637132: fixed in nss-pam-ldapd 0.8.4
has caused the Debian Bug report #637132,
regarding nslcd: wrong output when restarting the service
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
637132: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=637132
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: nslcd
Version: 0.7.13
Severity: minor
Tags: patch

Hi there!

The title includes everything, let us see the example:
=====
root@gismo:/etc# service nslcd stop
Stopping LDAP connection daemon: nslcd.
root@gismo:/etc# service nslcd start
Starting LDAP connection daemon: nslcd.
root@gismo:/etc# service nslcd restart
Restarting LDAP connection daemon: nslcd.
.
root@gismo:/etc#
=====

Obviously, the last command output is wrong, the fix is trivial:

--8<---------------cut here---------------start------------->8---
--- nslcd.~1~   2011-08-08 19:37:32.000000000 +0200
+++ nslcd       2011-08-08 19:39:50.976755090 +0200
@@ -142,7 +142,6 @@
   start-stop-daemon --stop --quiet --retry 10 \
                     --pidfile $NSLCD_PIDFILE \
                     --name nslcd
-  log_end_msg $?
   [ -n "$NSLCD_PIDFILE" ] && rm -f $NSLCD_PIDFILE
   k5start_stop
   k5start_start
--8<---------------cut here---------------end--------------->8---

While we are at it, however, I would go even futher and simplifies the
restart option (as in acpid, cron or samba, for example), because there
is no point in duplicating code for nothing [1]:

--8<---------------cut here---------------start------------->8---
--- nslcd.~1~   2011-08-08 19:37:32.000000000 +0200
+++ nslcd       2011-08-08 19:45:27.540859372 +0200
@@ -136,20 +136,9 @@
   k5start_stop
   ;;
 restart|force-reload)
-  [ -d "$NSLCD_STATEDIR" ] || ( mkdir -m 755 "$NSLCD_STATEDIR" ; \
-                                chown nslcd:nslcd "$NSLCD_STATEDIR" )
-  log_daemon_msg "Restarting $NSLCD_DESC" "nslcd"
-  start-stop-daemon --stop --quiet --retry 10 \
-                    --pidfile $NSLCD_PIDFILE \
-                    --name nslcd
-  log_end_msg $?
-  [ -n "$NSLCD_PIDFILE" ] && rm -f $NSLCD_PIDFILE
-  k5start_stop
-  k5start_start
-  start-stop-daemon --start \
-                    --pidfile $NSLCD_PIDFILE \
-                    --startas $NSLCD_BIN
-  log_end_msg $?
+  $0 stop
+  sleep 1
+  $0 start
   ;;
 status)
   if [ -f "$NSLCD_PIDFILE" ]
--8<---------------cut here---------------end--------------->8---

[1] BTW, technically speaking, the -d test at the beginning of the
    restart option is wrongly placed, given that it is not needed to
    stop the daemon, but only to start it ;-)

Thx, bye,
Gismo / Luca

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages nslcd depends on:
ii  adduser                  3.113           add and remove users and groups
ii  debconf [debconf-2.0]    1.5.41          Debian configuration management sy
ii  libc6                    2.13-14         Embedded GNU C Library: Shared lib
ii  libgssapi-krb5-2         1.9.1+dfsg-1+b1 MIT Kerberos runtime libraries - k
ii  libldap-2.4-2            2.4.25-1.1      OpenLDAP libraries

Versions of packages nslcd recommends:
ii  libnss-ldapd [libnss-ldap]    0.7.13     NSS module for using LDAP as a nam
ii  libpam-ldapd [libpam-ldap]    0.7.13     PAM module for using LDAP as an au
ii  nscd                          2.13-14    Embedded GNU C Library: Name Servi

Versions of packages nslcd suggests:
pn  kstart                        <none>     (no description available)

-- debconf information:
* nslcd/ldap-starttls: false
  nslcd/ldap-reqcert:
* nslcd/ldap-uris: ldap://ldap.pca.it
  nslcd/ldap-binddn:
  nslcd/ldap-base:

Attachment: pgpiexCGCxTQg.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: nss-pam-ldapd
Source-Version: 0.8.4

We believe that the bug you reported is fixed in the latest version of
nss-pam-ldapd, which is due to be installed in the Debian FTP archive:

libnss-ldapd_0.8.4_i386.deb
  to main/n/nss-pam-ldapd/libnss-ldapd_0.8.4_i386.deb
libpam-ldapd_0.8.4_i386.deb
  to main/n/nss-pam-ldapd/libpam-ldapd_0.8.4_i386.deb
nslcd_0.8.4_i386.deb
  to main/n/nss-pam-ldapd/nslcd_0.8.4_i386.deb
nss-pam-ldapd_0.8.4.dsc
  to main/n/nss-pam-ldapd/nss-pam-ldapd_0.8.4.dsc
nss-pam-ldapd_0.8.4.tar.gz
  to main/n/nss-pam-ldapd/nss-pam-ldapd_0.8.4.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Arthur de Jong <[email protected]> (supplier of updated nss-pam-ldapd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 04 Sep 2011 21:00:00 +0200
Source: nss-pam-ldapd
Binary: nslcd libnss-ldapd libpam-ldapd
Architecture: source i386
Version: 0.8.4
Distribution: unstable
Urgency: low
Maintainer: Arthur de Jong <[email protected]>
Changed-By: Arthur de Jong <[email protected]>
Description: 
 libnss-ldapd - NSS module for using LDAP as a naming service
 libpam-ldapd - PAM module for using LDAP as an authentication service
 nslcd      - Daemon for NSS and PAM lookups using LDAP
Closes: 637132 637751 637756 637759 637863 638195 638872 639026 639107 639236 
640185
Changes: 
 nss-pam-ldapd (0.8.4) unstable; urgency=low
 .
   * Upload to unstable
   * switch to using the member attribute by default instead of
     uniqueMember (backwards incompatible change)
   * only return "x" as a password hash when the object has the shadowAccount
     objectClass and nsswitch.conf is configured to do shadow lookups using
     LDAP (this avoids some problems with pam_unix)
   * fix problem with partial attribute name matches in DN (thanks Timothy
     White)
   * fix a problem with objectSid mappings with recent versions of OpenLDAP
     (patch by Wesley Mason)
   * set the socket timeout in a connection callback to avoid timeout
     issues during the SSL handshake (patch by Stefan Völkel)
   * check for unknown variables in pam_authz_search
   * only check password expiration when authenticating, only check account
     expiration when doing authorisation
   * make buffer sizes consistent and grow all buffers holding string
     representations of numbers to be able to hold 64-bit numbers
   * update AX_PTHREAD from autoconf-archive
   * support querying DNS SRV records from a different domain than the current
     one (based on a patch by James M. Leddy)
   * fix a problem with uninitialised memory while parsing the tls_ciphers
     option (closes: #638872) (but doesn't work yet due to #640384)
   * implement bounds checking of numeric values read from LDAP (patch by
     Jakub Hrozek)
   * correctly support large uid and gid values from LDAP (patch by Jakub
     Hrozek)
   * improvements to the configure script (patch by Jakub Hrozek)
   * switch to dh for debian/rules and bump debhelper compatibility to 8
   * build Debian packages with multiarch support
   * ship shlibs (but still no symbol files) for libnss-ldapd since that was
     the easiest way to support multiarch
   * fix output in init script when restarting nslcd (closes: #637132)
   * correctly handle leading and trailing spaces in preseeded debconf uri
     option (patch by Andreas B. Mundt) (closes: #637863)
   * support spaces around database names in /etc/nsswitch.conf while
     configuring package (closes: #640185)
   * updated Russian debconf translation by Yuri Kozlov (closes: #637751)
   * updated French debconf translation by Christian Perrier (closes: #637756)
   * added Slovak debconf translation by Slavko (closes: #637759)
   * updated Danish debconf translation by Joe Hansen (closes :#637763)
   * updated Brazilian Portuguese debconf translation by Denis Doria
   * updated Portuguese debconf translation by Américo Monteiro
   * updated Japanese debconf translation by Kenshi Muto (closes: #638195)
   * updated Czech debconf translation by Miroslav Kure (closes: #639026)
   * updated German debconf translation by Chris Leick (closes: #639107)
   * updated Spanish debconf translation by Francisco Javier Cuadrado
     (closes: #639236)
   * updated Dutch debconf translation by Arthur de Jong with help from Paul
     Gevers and Jeroen Schot
Checksums-Sha1: 
 23105e345bb4878f672bc284ec6d6531c5811988 1106 nss-pam-ldapd_0.8.4.dsc
 9939f846b0414b47a3ffc5fee67d88dbc707b9ba 544551 nss-pam-ldapd_0.8.4.tar.gz
 619b7f8db0e7a445f43602b3a248cf4b1837fe85 150060 nslcd_0.8.4_i386.deb
 9d150811d9abe3aa56e54ca4ed71cc28881a5905 49368 libnss-ldapd_0.8.4_i386.deb
 b811c9d5505e9f5335b2d0c9b95f347f3dfa63ed 41942 libpam-ldapd_0.8.4_i386.deb
Checksums-Sha256: 
 edcae8bd4c5e8fa1ae9891b68d9f390321528903ab646a3602e6c381adb76b72 1106 
nss-pam-ldapd_0.8.4.dsc
 294815467b730ee0238a2014221e7b9e862b1f98d83c86f775f33527ab179b46 544551 
nss-pam-ldapd_0.8.4.tar.gz
 e26fdce7aff5707598acc2c9f9246a4bd1de6e5b634a152e84c34244dcff54eb 150060 
nslcd_0.8.4_i386.deb
 1cbfd324a6508921b74a5992d6f76e90e63951cd4bb47ebfe3d65633341cedba 49368 
libnss-ldapd_0.8.4_i386.deb
 18a5a7f60f1a97107871951300d3d47f3cf74c9d6cb07655fbbab184ca5aaa1c 41942 
libpam-ldapd_0.8.4_i386.deb
Files: 
 d018b52d3a3091ba8a4d665396437d8f 1106 admin extra nss-pam-ldapd_0.8.4.dsc
 ff9559cdc553a87114d2fb2fb0d42d59 544551 admin extra nss-pam-ldapd_0.8.4.tar.gz
 eb8d882abdfbe0784ca5b8e3ab79d327 150060 admin extra nslcd_0.8.4_i386.deb
 a8f1da21e8ccfb753910848344148303 49368 admin extra libnss-ldapd_0.8.4_i386.deb
 ab0166e2dee49c4f74a9f4ff3494362a 41942 admin extra libpam-ldapd_0.8.4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk5jz6EACgkQVYan35+NCKdbuwCgrkmza9vpcx8sbXFv6ZU4h02+
c0YAni65dzh3CzAaLh7lLU7PhnUTxGcY
=eJT/
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to