Your message dated Tue, 20 Sep 2011 10:17:29 +0000
with message-id <[email protected]>
and subject line Bug#635014: fixed in ltpanel 0.2-2
has caused the Debian Bug report #635014,
regarding ltpanel: Please support building with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
635014: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635014
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ltpanel
Version: 0.2-1
Severity: minor
Tags: patch
User: [email protected]
Usertags: ld-as-needed
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
*** /tmp/tmpStvqgM
In Ubuntu, the attached patch was applied to achieve the following:
* Libs should come after objects to fix build failure with --as-needed
(LP: #770834)
Ubuntu passes ld --as-needed per default to the linker, ltpanel FTBFS with:
gcc -g -Xlinker -L/usr/X11R6/lib -lX11 -lXpm lpanel.o drawing.o -o lpanel
lpanel.o: In function `get_prop_data':
/build/buildd/ltpanel-0.2/src/lpanel.c:108: undefined reference to
`XGetWindowProperty'
lpanel.o: In function `get_task_hinticon':
/build/buildd/ltpanel-0.2/src/lpanel.c:138: undefined reference to `XFree'
lpanel.o: In function `get_task_kdeicon':
/build/buildd/ltpanel-0.2/src/lpanel.c:156: undefined reference to `XFree'
lpanel.o: In function `find_desktop':
/build/buildd/ltpanel-0.2/src/lpanel.c:168: undefined reference to `XFree'
lpanel.o: In function `is_hidden':
/build/buildd/ltpanel-0.2/src/lpanel.c:182: undefined reference to `XFree'
lpanel.o: In function `is_iconified':
/build/buildd/ltpanel-0.2/src/lpanel.c:197: undefined reference to `XFree'
lpanel.o: In function `add_task':
/build/buildd/ltpanel-0.2/src/lpanel.c:221: undefined reference to
`XSelectInput'
lpanel.o: In function `gui_sync':
/build/buildd/ltpanel-0.2/src/lpanel.c:243: undefined reference to `XSync'
lpanel.o: In function `set_prop':
/build/buildd/ltpanel-0.2/src/lpanel.c:248: undefined reference to
`XChangeProperty'
lpanel.o: In function `gui_create_taskbar':
[...]
collect2: ld returned 1 exit status
make[2]: *** [lpanel] Error 1
make[2]: Leaving directory `/build/buildd/ltpanel-0.2/src'
make[1]: *** [override_dh_auto_build] Error 2
(Full buildlog at
https://launchpadlibrarian.net/70321007/buildlog_ubuntu-natty-amd64.ltpanel_0.2-1_FAILEDTOBUILD.txt.gz)
The libraries are clearly in the wrong place on the link line for
- - --as-needed (http://wiki.debian.org/ToolChain/DSOLinking). This
probably doesn't affect Debian right now because --as-needed is a
positional option and only affects those libraries listed after it, but
Ubuntu's linker defaults to --as-needed right out of the gate.
Nevertheless, I believe that the debian-gcc team is tracking these
problems and wants to make Debian packages work cleanly with such a
linker.
Thanks for considering the patch.
- -- System Information:
Debian Release: wheezy/sid
APT prefers oneiric
APT policy: (500, 'oneiric')
Architecture: amd64 (x86_64)
Kernel: Linux 3.0.0-999-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBAgAGBQJOKGcyAAoJEGHzRCZ03mYkgLkQANJxIXrmsw932sNqnwKfiqxu
eKPa0OWgdYnQTcjYPSUkD/HUDsGOyHSgEe0uriWm1QIaD10aUg5OQ0s/VpsJReWD
prY0ZetoHFTsmKp/lUw5czYcWYPhM/MyWDQHk8lQj+S0R0AaCHG44y7zkcgY+xwh
lvxucupHYBEL+vvRVAZdGIgNx7eZk3NHlr5Apc+8BAWdFi9+s5Gm8ok784I27ZcG
s5oS1P8BulZdmHvX8utSxje6QvPxrsOjT4cqH4LrtP4ON84fr9+zzZx6b5/aEGCp
XXrBqqFDMYYCYQjIEZPg2XUo2at0j5QKT5Q/88ojUp1+cFTphNu364T4sE7Lce88
2hvtOu/Fei/ZQwEBlpRfdMP/Ec24c7ZuE9KgQbbEByswyDhRNseHaBUwK7o/7LPc
6I8irv2XyrKLRAeUNoQYPPSBHZpqoOpF3CPxbFecoGcQIBrq0hLgZwhojOWxkwcH
5YufYhr1h0gQcAUjYtmI1PsWVK+AwyYrXO9KyrbMNwf9dUempcbVWOsHFlOnhmeD
NdyGjjm3cqWwccXPD7hutwRaEPyFipJv6o8ulLlmeYd6zCQLYKiOnSolmC0gzda6
axGWTASYXL5YfykjL0dPKKSw2Gov/OkY4fdUqP+DJLOA5LNIrRPK5dl/d6VV8aPo
Ucg8jC+Zr3SU/xinCz4q
=s3wT
-----END PGP SIGNATURE-----
=== added file 'debian/patches/fix-as-needed'
--- debian/patches/fix-as-needed 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-as-needed 2011-07-21 17:46:02 +0000
@@ -0,0 +1,24 @@
+Description: With ld --as-needed, objects and sources need to come
+ before libraries so the symbols are recorded as 'needed'.
+Author: Andreas Moog <[email protected]>
+Bug-Ubuntu: pad.lv/770834
+Last-Update: 2011-07-21
+
+--- ltpanel-0.2.orig/src/Makefile
++++ ltpanel-0.2/src/Makefile
+@@ -1,12 +1,13 @@
+ CC = gcc
+ C_FLAGS = -g -c -DHAVE_XPM -Wall -pedantic -I/usr/X11R6/include
+ # L_FLAGS = -O3 -s -Xlinker -L/usr/X11R6/lib -lX11 -lXpm
+-L_FLAGS = -g -Xlinker -L/usr/X11R6/lib -lX11 -lXpm
++L_FLAGS = -g -Xlinker -L/usr/X11R6/lib
++L_LIBS = -lX11 -lXpm
+ PROGNAME = lpanel
+ OBJS = lpanel.o drawing.o
+
+ $(PROGNAME): Makefile lpanel.o drawing.o
+- $(CC) $(L_FLAGS) $(OBJS) -o $(PROGNAME)
++ $(CC) $(L_FLAGS) $(OBJS) $(L_LIBS) -o $(PROGNAME)
+ @ls -l $(PROGNAME)
+
+ lpanel.o: lpanel.c lpanel.h ../icon.xpm
=== added file 'debian/patches/series'
--- debian/patches/series 1970-01-01 00:00:00 +0000
+++ debian/patches/series 2011-07-21 17:44:08 +0000
@@ -0,0 +1 @@
+fix-as-needed
--- End Message ---
--- Begin Message ---
Source: ltpanel
Source-Version: 0.2-2
We believe that the bug you reported is fixed in the latest version of
ltpanel, which is due to be installed in the Debian FTP archive:
ltpanel_0.2-2.debian.tar.gz
to main/l/ltpanel/ltpanel_0.2-2.debian.tar.gz
ltpanel_0.2-2.dsc
to main/l/ltpanel/ltpanel_0.2-2.dsc
ltpanel_0.2-2_amd64.deb
to main/l/ltpanel/ltpanel_0.2-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jari Aalto <[email protected]> (supplier of updated ltpanel package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 20 Sep 2011 00:17:25 +0300
Source: ltpanel
Binary: ltpanel
Architecture: source amd64
Version: 0.2-2
Distribution: unstable
Urgency: low
Maintainer: Jari Aalto <[email protected]>
Changed-By: Jari Aalto <[email protected]>
Description:
ltpanel - lightweight tasklist panel for minimalist WMs
Closes: 635014
Changes:
ltpanel (0.2-2) unstable; urgency=low
.
* debian/compat
- Update to 8.
* debian/control
- (Build-Depends): debhelper 8.
- (Standards-Version): Update to 3.9.2.
* debian/copyright
- Update to DEP 5.
* debian/patches
(10): New. Fix build with "ld --as-needed". Patch thanks to
Andreas Moog <[email protected]> (LP #770834; Closes: #635014).
Checksums-Sha1:
50bd0689dcddff5989ee4e2ebcd5b919348ee58e 1164 ltpanel_0.2-2.dsc
3cdbf6afe843a9949a1076473460125775181d6f 2620 ltpanel_0.2-2.debian.tar.gz
b227c06f018e79d920e0ce483e8faa55ccd7f5ad 12922 ltpanel_0.2-2_amd64.deb
Checksums-Sha256:
4af70bba604e2914b5a4b20ca8ada4f727fbc611e3c6b66c2a2f58adec60d29c 1164
ltpanel_0.2-2.dsc
31a38ca9228a6dd50852426a1b2095dd36e24546528c55a10bbfba80258363a4 2620
ltpanel_0.2-2.debian.tar.gz
5a95d3775612bdceb186d00a5c1a843d878348e3875a57f13cf0517a52aa742a 12922
ltpanel_0.2-2_amd64.deb
Files:
f734e9a1ae095492c51ad415ab573c8f 1164 x11 optional ltpanel_0.2-2.dsc
626194c8772bee275e4645cc0002506f 2620 x11 optional ltpanel_0.2-2.debian.tar.gz
93548ab44b43913c074e254c40fe27ce 12922 x11 optional ltpanel_0.2-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk54ZP4ACgkQLARVQsm1XayzAwCff8dRswP0+JEUHBB1AB13vrlK
3TwAoLmEu1wswzvG9PJp0oIoB3hewU19
=epWO
-----END PGP SIGNATURE-----
--- End Message ---
