Your message dated Sun, 09 Oct 2011 21:09:22 +0000
with message-id <[email protected]>
and subject line Bug#610722: fixed in thinkfan 0.7.3-1
has caused the Debian Bug report #610722,
regarding thinkfan: dies setting fan to disengaged
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
610722: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610722
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: thinkfan
Version: 0.7.1-2
Severity: important
Tags: patch
I have a lenovo thinkpad x201. I am able to make the cpu
overheat if I run processes that are very intensive.
This is because the "level 7" fan speed (~4500RPM)
is much lower than "level disengaged" speed (~5500RPM).
It is not possible to specify explicitly in thinkfan.conf
something like:
(disengaged, 75, 32767)
However, on my machine, I can enter disengaged mode by:
echo level 127 >/proc/acpi/ibm/fan
thinkfan does accept the definition:
(127, 75, 32767)
but if the temperature ever rises sufficiently so that it
gets called, it dies with the error:
/proc/acpi/ibm/fan: Invalid argument
When I echo "level 127" directly from the commandline I do not
get this error, so I think thinkfan is actually sending some
other string.
My C is very rusty, but in system.c:setfan_ibm(), I see that
write is hardwired to be precisely 8 bytes. Won't this also
have a problem when buf contains "level disengaged" ?
I guess there are two bugs/problems:
1. It should be possible to set maximum fan speed, either by
"level disengaged" (preferred) or something like "level 127".
2. thinkfan dies instead of just warning about this error.
A fix for the first problem seems to be to change system.c:
--- system.c 2010-06-14 00:31:18.000000000 +0100
+++ system.c.new 2011-01-21 17:50:38.000000000 +0000
@@ -83,7 +83,7 @@
else {
if (unlikely(cur_lvl == INT_MIN)) strcpy(buf, "level
disengaged\n");
else snprintf(buf, 10, "level %d\n", cur_lvl);
- if (unlikely(write(ibm_fan, buf, 8) != 8)) {
+ if (unlikely(write(ibm_fan, buf, strlen(buf)) != strlen(buf))) {
showerr(IBM_FAN);
message(LOG_ERR, MSG_ERR_FANCTRL);
errcnt++;
After I recompile with this change, thinkfan no longer dies
when I use the "127" config line and the cpu gets hot, and if I
"cat /proc/acpi/ibm/fan", level is reported as "disengaged".
(This is also obvious from the increased fan volume.)
-jonathan
-- System Information:
Debian Release: 6.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages thinkfan depends on:
hi libc6 2.11.2-9 Embedded GNU C Library: Shared lib
thinkfan recommends no packages.
thinkfan suggests no packages.
-- Configuration Files:
/etc/default/thinkfan changed:
START=yes
DAEMON_ARGS="-q"
/etc/thinkfan.conf changed:
(0, 0, 45)
(1, 40, 50)
(2, 45, 54)
(3, 49, 58)
(4, 53, 61)
(5, 56, 63)
(6, 58, 65)
(7, 60, 80)
(127, 75, 32767)
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: thinkfan
Source-Version: 0.7.3-1
We believe that the bug you reported is fixed in the latest version of
thinkfan, which is due to be installed in the Debian FTP archive:
thinkfan_0.7.3-1.diff.gz
to main/t/thinkfan/thinkfan_0.7.3-1.diff.gz
thinkfan_0.7.3-1.dsc
to main/t/thinkfan/thinkfan_0.7.3-1.dsc
thinkfan_0.7.3-1_amd64.deb
to main/t/thinkfan/thinkfan_0.7.3-1_amd64.deb
thinkfan_0.7.3.orig.tar.gz
to main/t/thinkfan/thinkfan_0.7.3.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Evgeni Golov <[email protected]> (supplier of updated thinkfan package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 09 Oct 2011 20:23:45 +0200
Source: thinkfan
Binary: thinkfan
Architecture: source amd64
Version: 0.7.3-1
Distribution: unstable
Urgency: low
Maintainer: Evgeni Golov <[email protected]>
Changed-By: Evgeni Golov <[email protected]>
Description:
thinkfan - simple and lightweight fan control program
Closes: 610722 635750
Changes:
thinkfan (0.7.3-1) unstable; urgency=low
.
* New upstream release.
+ Don't cut buffer to length 8 in setfan_ibm().
Closes: #610722
* Update debian/copyright:
+ Update years.
+ thinkfan is now GPLv3 licensed.
+ Update to latest dep5 spec.
* Standards-Version: 3.9.2
* Add systemd service file.
Thanks: Michael Stapelberg <[email protected]>
Closes: #635750
Checksums-Sha1:
7794cb438cf50832711d88aa85d24b26912e0cf4 1164 thinkfan_0.7.3-1.dsc
9438d21efe4abc3220d1390052419c1dd40bf62c 22488 thinkfan_0.7.3.orig.tar.gz
66db567d6989bade60f90ca50e7d6d8502e8251e 3431 thinkfan_0.7.3-1.diff.gz
9a7037611d7fae4a3ed4bc2f1bead32239772c41 29028 thinkfan_0.7.3-1_amd64.deb
Checksums-Sha256:
6acd2bc7c13d30fedd313b7662947c162258336337de595058b17a1088af0320 1164
thinkfan_0.7.3-1.dsc
88374dd89af073f658b507942cdb569ef8cd2810e39cbf71da17455282a4b32e 22488
thinkfan_0.7.3.orig.tar.gz
d18ada4f971e6ff4e67ce5cb857872b75ea3c96aded7375b01eaa2e3fd12c67e 3431
thinkfan_0.7.3-1.diff.gz
7c589b089b9570ef9d696d39920bafdb19bac0a1b0f5ede27ef1934d48781b19 29028
thinkfan_0.7.3-1_amd64.deb
Files:
f8508727a163d1cab4d89cad71c05e79 1164 misc extra thinkfan_0.7.3-1.dsc
d1b0d7a05b37cce412ee227cf759a9f6 22488 misc extra thinkfan_0.7.3.orig.tar.gz
32fc6082f7dd0da857cfa26bdc9d1fe8 3431 misc extra thinkfan_0.7.3-1.diff.gz
bbd8091c388d1433fc81080f4f1cfbbd 29028 misc extra thinkfan_0.7.3-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk6SCW8ACgkQJKAUGKwVtQx8uQCeJ1eoxoe4WwNNOHOcrqKGUzkc
pUcAn33FPInycFjGjoPInz3rdKcDIC8f
=2UxT
-----END PGP SIGNATURE-----
--- End Message ---
