Your message dated Thu, 13 Oct 2011 15:03:00 +0000
with message-id <[email protected]>
and subject line Bug#641416: fixed in gmanedit 0.4.2-5
has caused the Debian Bug report #641416,
regarding gmanedit: Update for deprecated symbols in current GTK+
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
641416: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641416
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gmanedit
Version: 0.4.2-4
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch oneiric
gmanedit failed to build on Ubuntu amd64 because it builds with
-DGTK_DISABLE_DEPRECATED but uses symbols that have since been
deprecated in GTK+:
https://launchpadlibrarian.net/70216621/buildlog_ubuntu-natty-amd64.gmanedit_0.4.2-4_FAILEDTOBUILD.txt.gz
This fails specifically on amd64 because unprototyped functions
implicitly return int, and ints and pointers have different sizes on
amd64, so we force those particular compiler warnings to cause build
failures since they may well lead to crashes at runtime.
The following patch fixes this. It should be suitable for forwarding
upstream with a little rearrangement; the "Internet browser" preference
has been removed, but it looks as though the rest of it should still
pretty much apply.
* Update for deprecated symbols in current GTK+ (LP: #771093).
diff -Nru gmanedit-0.4.2/debian/patches/gtk_deprecated
gmanedit-0.4.2/debian/patches/gtk_deprecated
--- gmanedit-0.4.2/debian/patches/gtk_deprecated 1970-01-01
01:00:00.000000000 +0100
+++ gmanedit-0.4.2/debian/patches/gtk_deprecated 2011-09-13
11:08:24.000000000 +0100
@@ -0,0 +1,100 @@
+Description: Update for deprecated symbols in current GTK+
+ gtk_set_locale is already called by gtk_init and so unnecessary. The other
+ symbols have straightforward replacements.
+Author: Colin Watson <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/771093
+Forwarded: no
+Last-Update: 2009-09-13
+
+Index: b/src/callbacks.c
+===================================================================
+--- a/src/callbacks.c
++++ b/src/callbacks.c
+@@ -830,7 +830,11 @@
+ entry=lookup_widget(prefs,"entry_command");
+ entry_text=gtk_entry_get_text(GTK_ENTRY(entry));
+ ch = lookup_widget(prefs, "combo2");
++#if !GTK_CHECK_VERSION(2,24,0)
+ browser = gtk_combo_box_get_active_text (GTK_COMBO_BOX (ch));
++#else
++ browser = gtk_combo_box_text_get_active_text (GTK_COMBO_BOX_TEXT (ch));
++#endif
+ snprintf(buf, sizeof buf, "# File created by gmanedit preferences
option\n\nCOMMAND=%s\nINTERNET_BROWSER=%s", entry_text, browser);
+ g_free(browser);
+
+Index: b/src/interface.c
+===================================================================
+--- a/src/interface.c
++++ b/src/interface.c
+@@ -507,14 +507,26 @@
+ label17 = gtk_label_new (_("Internet browser"));
+ gtk_widget_show (label17);
+ gtk_box_pack_start (GTK_BOX (hbox4), label17, FALSE, FALSE, 0);
++#if !GTK_CHECK_VERSION(2,24,0)
+ combo2 = gtk_combo_box_entry_new_text ();
++#else
++ combo2 = gtk_combo_box_text_new_with_entry ();
++#endif
+ gtk_widget_show (combo2);
+ gtk_box_pack_start (GTK_BOX (hbox4), combo2, TRUE, TRUE, 0);
++#if !GTK_CHECK_VERSION(2,24,0)
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo2), "mozilla");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo2), "firefox");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo2), "galeon");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo2), "epiphany");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo2), "konqueror");
++#else
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo2), "mozilla");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo2), "firefox");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo2), "galeon");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo2), "epiphany");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo2), "konqueror");
++#endif
+ HOOKUP_OBJECT (wpreferences, combo2, "combo2");
+
+ // gtk_tooltips_set_tip (tooltips, cbinet, _("Select your internet browser
from this list"), NULL);
+@@ -721,10 +733,15 @@
+ gtk_widget_show (label2);
+ gtk_fixed_put (GTK_FIXED (fixed2), label2, 56, 168);
+
++#if !GTK_CHECK_VERSION(2,24,0)
+ combo1 = gtk_combo_box_new_text ();
++#else
++ combo1 = gtk_combo_box_text_new ();
++#endif
+ gtk_widget_show (combo1);
+ gtk_fixed_put (GTK_FIXED (fixed2), combo1, 240, 168);
+ gtk_widget_set_size_request (combo1, 175, 26);
++#if !GTK_CHECK_VERSION(2,24,0)
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "1");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "2");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "3");
+@@ -733,6 +750,16 @@
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "6");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "7");
+ gtk_combo_box_append_text (GTK_COMBO_BOX(combo1), "8");
++#else
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "1");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "2");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "3");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "4");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "5");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "6");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "7");
++ gtk_combo_box_text_append_text (GTK_COMBO_BOX_TEXT(combo1), "8");
++#endif
+ gtk_combo_box_set_active (GTK_COMBO_BOX(combo1), 0);
+ HOOKUP_OBJECT (wizard, combo1, "combo1");
+
+Index: b/src/main.c
+===================================================================
+--- a/src/main.c
++++ b/src/main.c
+@@ -53,7 +53,6 @@
+
+ add_pixmap_directory (DATADIR G_DIR_SEPARATOR_S "pixmaps");
+
+- gtk_set_locale ();
+ gtk_init (&argc, &argv);
+
+ /*
diff -Nru gmanedit-0.4.2/debian/patches/series
gmanedit-0.4.2/debian/patches/series
--- gmanedit-0.4.2/debian/patches/series 2011-02-23 07:55:32.000000000
+0000
+++ gmanedit-0.4.2/debian/patches/series 2011-09-13 10:15:02.000000000
+0100
@@ -4,3 +4,4 @@
spanish_translation
desktop_utf8
file_save_dialog
+gtk_deprecated
Thanks,
--
Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---
Source: gmanedit
Source-Version: 0.4.2-5
We believe that the bug you reported is fixed in the latest version of
gmanedit, which is due to be installed in the Debian FTP archive:
gmanedit_0.4.2-5.debian.tar.gz
to main/g/gmanedit/gmanedit_0.4.2-5.debian.tar.gz
gmanedit_0.4.2-5.dsc
to main/g/gmanedit/gmanedit_0.4.2-5.dsc
gmanedit_0.4.2-5_amd64.deb
to main/g/gmanedit/gmanedit_0.4.2-5_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ralf Treinen <[email protected]> (supplier of updated gmanedit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 13 Oct 2011 16:10:01 +0200
Source: gmanedit
Binary: gmanedit
Architecture: source amd64
Version: 0.4.2-5
Distribution: unstable
Urgency: low
Maintainer: Ralf Treinen <[email protected]>
Changed-By: Ralf Treinen <[email protected]>
Description:
gmanedit - GTK+ man pages editor
Closes: 641416
Changes:
gmanedit (0.4.2-5) unstable; urgency=low
.
* Patch gtk_deprecated: Update for deprecated symbols in current GTK+.
Thanks a lot to Colin Watson for the patch! (closes: #641416)
* Standards-Version 3.9.2 (no change)
* debian/rules: add targets build-arch and build-indep
Checksums-Sha1:
71e676985771f11fd051af468c5a7edfb6c1e9c2 1155 gmanedit_0.4.2-5.dsc
b19b8c92ffdd1b87052ce88c5080f2dc8f6bb0c5 16130 gmanedit_0.4.2-5.debian.tar.gz
1ce61512d27ed49a03620d13769c2b1b3920dde3 53658 gmanedit_0.4.2-5_amd64.deb
Checksums-Sha256:
cbe04447b04fe00260616c254002167fabd0e57770f179fce95986b7435cf9a0 1155
gmanedit_0.4.2-5.dsc
b01332ebf1f85a9bbbcba58d19fcec00bbfb01326b4c0de0f037767158a1bcc9 16130
gmanedit_0.4.2-5.debian.tar.gz
8f147e88ce1cfaccec9863c025cb1704d3f88e7183fe0488708cd3ebfd877b7f 53658
gmanedit_0.4.2-5_amd64.deb
Files:
b6ff69e7d406860c2485523693e39ab6 1155 gnome optional gmanedit_0.4.2-5.dsc
169d2558e1e1f587f64a7e73675c0c73 16130 gnome optional
gmanedit_0.4.2-5.debian.tar.gz
7c1bddbfc9bbcfa45b89cff61cc2fc6e 53658 gnome optional
gmanedit_0.4.2-5_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk6W8fcACgkQtzWmSeC6BMGjagCgoiPhdqbaHKeXJ58LpJNiYsZv
a8UAoMg/xXc6jUp++FpV/za3UK/IpDfs
=yPwT
-----END PGP SIGNATURE-----
--- End Message ---
