Your message dated Mon, 17 Oct 2011 12:32:05 +0200
with message-id <[email protected]>
and subject line Re: [Pkg-puppet-devel] Bug#645497: puppet-common: Have
etckeeper-commit-{pre, post} scripts check etckeeper unclean
has caused the Debian Bug report #645497,
regarding puppet-common: Have etckeeper-commit-{pre, post} scripts check
etckeeper unclean
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
645497: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=645497
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: puppet-common
Version: 2.7.5-3
Severity: wishlist
I would like to suggest an addition to the
/etc/puppet/etckeeper-commit-{pre,post} helper scripts.
The existens of uncommitted changes can be checked for by running
"etckeeper unclean", which returns true if there are changes to be
commited. Hence it might be slightly tidier to have something like
this, before running the etckeeper commit command.
etckeeper unclean || exit 0
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.0.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=sv_SE.UTF-8, LC_CTYPE=sv_SE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages puppet-common depends on:
ii adduser 3.113
ii facter 1.6.2-1
ii libaugeas-ruby1.8 0.3.0-1.1
ii libopenssl-ruby <none>
ii libruby [libxmlrpc-ruby] 4.8
ii libshadow-ruby1.8 1.4.1-8
ii lsb-base 3.2-28
ii ruby1.8 1.8.7.352-2
ii sysv-rc 2.88dsf-13.12
Versions of packages puppet-common recommends:
ii debconf-utils 1.5.41
ii lsb-release 3.2-28
Versions of packages puppet-common suggests:
pn librrd-ruby1.8 <none>
pn libselinux-ruby1.8 <none>
-- no debconf information
--- End Message ---
--- Begin Message ---
tag 645497 wontfix
thanks
Andreas Olsson <[email protected]> writes:
> Hence it might be slightly tidier to have something like this, before
> running the etckeeper commit command.
>
> etckeeper unclean || exit 0
That would prevent the etckeeper hooks from running altogether, if /etc
has uncommitted changes.
Puppet currently does one etckeeper commit before running, and one
after. If this does not make sense for your site, you could add the
"etckeeper unclean" check to your hooks, but I fear it would not be
suitable for the default package hooks.
--
Stig Sandbeck Mathisen <[email protected]>
--- End Message ---
