Your message dated Mon, 17 Oct 2011 18:03:16 +0000
with message-id <[email protected]>
and subject line Bug#645509: fixed in gtk-vector-screenshot 0.3.2-1
has caused the Debian Bug report #645509,
regarding Causes gnome-panel to abort due to BadWindow X11 protocol error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
645509: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=645509
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gtk-vector-screenshot
Version: 0.3.1-1
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


After switching from a different VT back to a GNOME3 fallback session,
gnome-panel dies with

(gnome-panel:4174): Gdk-WARNING **: The program 'gnome-panel' received an X
Window System error.
This probably reflects a bug in the program.
The error was 'BadWindow (invalid Window parameter)'.
  (Details: serial 10210 error_code 3 request_code 18 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)


I painstakingly tracked this down to the XSetTextProperty() call in
pdfscreenshot_event_filter(). The attached patch fixes the problem by
replacing XSetErrorHandler() calls with
gdk(_x11_display)_error_trap_push/pop_ignored() calls, which also ignore
asynchronous errors which arrive later (there's no reason why
XSetTextProperty() would force errors to arrive synchronously).


- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (102, 'experimental')
Architecture: powerpc (ppc)

Kernel: Linux 3.0.6+
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gtk-vector-screenshot depends on:
ii  libatk1.0-0         2.2.0-2   
ii  libc6               2.13-21   
ii  libcairo-gobject2   1.10.2-6.1
ii  libcairo2           1.10.2-6.1
ii  libfontconfig1      2.8.0-3   
ii  libfreetype6        2.4.6-2   
ii  libgdk-pixbuf2.0-0  2.24.0-1  
ii  libglib2.0-0        2.28.6-1  
ii  libgtk-3-0          3.0.12-2  
ii  libgtk2.0-0         2.24.6-2  
ii  libpango1.0-0       1.29.4-1  
ii  libx11-6            2:1.4.4-2 

gtk-vector-screenshot recommends no packages.

gtk-vector-screenshot suggests no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOmuQnWoGvjmrbsgARAiUcAJ9j9X4kYUAQyoSquE/ZdktXN5YSZACbBZGs
kq+UUF4VcmWYPaRbV8QNZlU=
=GJI7
-----END PGP SIGNATURE-----
diff -up -ru gtk-vector-screenshot-0.3.1.orig/gtk-vector-screenshot.c gtk-vector-screenshot-0.3.1/gtk-vector-screenshot.c
--- gtk-vector-screenshot-0.3.1.orig/gtk-vector-screenshot.c	2011-08-27 10:48:39.000000000 +0200
+++ gtk-vector-screenshot-0.3.1/gtk-vector-screenshot.c	2011-10-16 15:47:27.000000000 +0200
@@ -311,14 +311,22 @@ pdfscreenshot_event_filter (GdkXEvent *x
 
     if (ev->type == MapNotify) {
         XTextProperty supported;
+        GdkDisplay *display = gdk_x11_lookup_xdisplay(ev->xmap.display);
+
         XStringListToTextProperty(&supported_str, 1, &supported);
 
-        old_handler = XSetErrorHandler (silent_error_handler);
+        if (display)
+            gdk_x11_display_error_trap_push(display);
+        else
+            gdk_error_trap_push();
         XSetTextProperty(ev->xmap.display,
             ev->xmap.window,
             &supported,
             gdk_x11_atom_to_xatom(pdfscreenshot_atom));
-        (void) XSetErrorHandler (old_handler);
+        if (display)
+            gdk_x11_display_error_trap_pop_ignored(display);
+        else
+            gdk_error_trap_pop_ignored();
     } else if (ev->type == ClientMessage &&
             ev->xclient.message_type == gdk_x11_atom_to_xatom(pdfscreenshot_atom)) {
         if (event->any.window != NULL) {

--- End Message ---
--- Begin Message ---
Source: gtk-vector-screenshot
Source-Version: 0.3.2-1

We believe that the bug you reported is fixed in the latest version of
gtk-vector-screenshot, which is due to be installed in the Debian FTP archive:

gtk-vector-screenshot_0.3.2-1.debian.tar.gz
  to main/g/gtk-vector-screenshot/gtk-vector-screenshot_0.3.2-1.debian.tar.gz
gtk-vector-screenshot_0.3.2-1.dsc
  to main/g/gtk-vector-screenshot/gtk-vector-screenshot_0.3.2-1.dsc
gtk-vector-screenshot_0.3.2-1_amd64.deb
  to main/g/gtk-vector-screenshot/gtk-vector-screenshot_0.3.2-1_amd64.deb
gtk-vector-screenshot_0.3.2.orig.tar.gz
  to main/g/gtk-vector-screenshot/gtk-vector-screenshot_0.3.2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joachim Breitner <[email protected]> (supplier of updated 
gtk-vector-screenshot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 17 Oct 2011 19:45:09 +0200
Source: gtk-vector-screenshot
Binary: gtk-vector-screenshot
Architecture: source amd64
Version: 0.3.2-1
Distribution: unstable
Urgency: low
Maintainer: Joachim Breitner <[email protected]>
Changed-By: Joachim Breitner <[email protected]>
Description: 
 gtk-vector-screenshot - takes screenshots of applications as PDF or SVG files
Closes: 645509
Changes: 
 gtk-vector-screenshot (0.3.2-1) unstable; urgency=low
 .
   * New upstream version
     + The BadWindow error situation was futher improved by Michel Dänzer.
       (Closes: # 645509)
Checksums-Sha1: 
 9391a811766eed2ec8f2abfcf21bc6957b907e8c 1380 gtk-vector-screenshot_0.3.2-1.dsc
 02bac1b2448cca82b61d3c12b113ad4f3d01a213 319214 
gtk-vector-screenshot_0.3.2.orig.tar.gz
 78e6f131510d58ba26e215b8aef35f005e89fd8d 2570 
gtk-vector-screenshot_0.3.2-1.debian.tar.gz
 b444811273068f5a3ec6e13cec3c0f0ef20c45d4 22260 
gtk-vector-screenshot_0.3.2-1_amd64.deb
Checksums-Sha256: 
 77e307c426fb867a07d3b314f917dde348b6fe296093933c50b2885a39aa5204 1380 
gtk-vector-screenshot_0.3.2-1.dsc
 555785772ffa5a7269d008cb616ea81eda83b826eca6247da12b2ca464d862b7 319214 
gtk-vector-screenshot_0.3.2.orig.tar.gz
 e4eb8183376c4e976a49d7e3057b8c3e3521eaa15cb17b4954f0fa5ef80e77be 2570 
gtk-vector-screenshot_0.3.2-1.debian.tar.gz
 dda4f2274656bcd68901d7890422f5be362572abf085d6a091194f98a41c4772 22260 
gtk-vector-screenshot_0.3.2-1_amd64.deb
Files: 
 7665dfd8176a417f80e25f4cedaffde5 1380 gnome optional 
gtk-vector-screenshot_0.3.2-1.dsc
 177e9cf7cc7d6ad2f8e81f9ac9d9e4fe 319214 gnome optional 
gtk-vector-screenshot_0.3.2.orig.tar.gz
 650addc2107d121a42b85192de78019e 2570 gnome optional 
gtk-vector-screenshot_0.3.2-1.debian.tar.gz
 9af29d715c9d16527c446023548a73dd 22260 gnome optional 
gtk-vector-screenshot_0.3.2-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6cacIACgkQ9ijrk0dDIGz0OgCeJpGRa2WqlqQHQQNOyHgkXZff
zK8An0adRAQ9EXk3JQog6inKqY9VUszP
=Qdr/
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to