Your message dated Sun, 23 Oct 2011 20:50:16 +0000
with message-id <[email protected]>
and subject line Bug#646291: fixed in ifupdown 0.7~alpha5+really0.6.16
has caused the Debian Bug report #646291,
regarding please use FreeBSD route on Debian GNU/kFreeBSD
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
646291: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=646291
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ifupdown
Version: 0.6.10
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: kfreebsd

Debian GNU/kFreeBSD provides two route implementations, /lib/freebsd/route
which is the FreeBSD version of route, and /sbin/route which is a shell
wrapper that attempts to provide a Linux-like CLI.

As the /sbin/route wrapper is very incomplete / unreliable, and applications
tend to expect /sbin/route to provide FreeBSD CLI more often than not, in
the near future we're going to install FreeBSD route into /sbin/route (and
remove the wrapper or put it elsewhere). See:
  http://lists.debian.org/debian-bsd/2011/10/msg00242.html

Attached patch adjusts ifupdown to use FreeBSD route CLI when running on
GNU/kFreeBSD, and to use /lib/freebsd/route instead of /sbin/route.  The
latter is meant to be temporary and allow us to do this switch without
causing any breakage.

-- System Information:
Debian Release: 6.0.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 8.1-1-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ifupdown depends on:
ii  freebsd-net-tools [net- 8.1-5            FreeBSD networking tools
ii  libc0.1                 2.11.2-10        Embedded GNU C Library: Shared lib
ii  lsb-base                3.2-23.2squeeze1 Linux Standard Base 3.2 init scrip

ifupdown recommends no packages.

Versions of packages ifupdown suggests:
pn  iproute             <none>               (no description available)
ii  isc-dhcp-client [dh 4.1.1-P1-15+squeeze3 ISC DHCP client
pn  ppp                 <none>               (no description available)

-- no debconf information
=== modified file 'ifupdown.nw'
--- ifupdown.nw 2011-10-22 21:18:54 +0000
+++ ifupdown.nw 2011-10-22 21:49:51 +0000
@@ -107,13 +107,13 @@ We shall begin with the template for the
 <<Makefile>>=
 <<make options>>
 
-CFILES := addrfam.c execute.c config.c main.c archlinux.c
-HFILES := header.h archlinux.h
+CFILES := addrfam.c execute.c config.c main.c archlinux.c archkfreebsd.c
+HFILES := header.h archlinux.h archkfreebsd.h
 PERLFILES := defn2c.pl defn2man.pl
 DEFNFILES := inet.defn ipx.defn inet6.defn
 
 OBJ := main.o addrfam.o execute.o config.o \
-       $(patsubst %.defn,%.o,$(DEFNFILES)) archlinux.o
+       $(patsubst %.defn,%.o,$(DEFNFILES)) archlinux.o archkfreebsd.o
 
 MAN := $(patsubst %.defn,%.man,$(DEFNFILES))
 
@@ -3818,6 +3818,7 @@ interfaces up and down.
 unsigned int mylinuxver();
 unsigned int mylinux(int,int,int);
 int execable(char *);
+int islinux();
 @
 
 <<archlinux.c>>=
@@ -3863,6 +3864,30 @@ int execable(char *program) {
        }
        return 0;
 }
+
+int islinux() {
+#ifdef __linux__
+       return 1;
+#else
+       return 0;
+#endif
+}
+@ 
+
+<<archkfreebsd.h>>=
+int iskfreebsd();
+@
+
+<<archkfreebsd.c>>=
+#include "archkfreebsd.h"
+
+int iskfreebsd() {
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
+       return 1;
+#else
+       return 0;
+#endif
+}
 @ 
 
 \subsection{IPv4 Address Family}
@@ -3878,6 +3903,7 @@ extern address_family addr_inet;
 <<inet.defn>>=
 address_family inet
 architecture linux
+architecture kfreebsd
 
 <<inet methods>>
 @ 
@@ -3925,10 +3951,17 @@ method static
        up
     route add -net %network%  \
         if ( mylinuxver() < mylinux(2,1,100) )
-    [[ route add default gw %gateway% [[metric %metric%]] %iface% ]]
+    [[ /lib/freebsd/route add default %gateway% ]] \
+        if ( iskfreebsd() )
+    [[ route add default gw %gateway% [[metric %metric%]] %iface% ]] \
+        elsif ( 1 )
+
 
   down
-    [[ route del default gw %gateway% [[metric %metric%]] %iface% ]]
+    [[ /lib/freebsd/route del default %gateway% ]] \
+        if ( iskfreebsd() )
+    [[ route del default gw %gateway% [[metric %metric%]] %iface% ]] \
+        elsif ( 1 )
     ifconfig %iface% down
 @
 
@@ -4058,6 +4091,7 @@ extern address_family addr_inet6;
 <<inet6.defn>>=
 address_family inet6
 architecture linux
+architecture kfreebsd
 
 method loopback
   description
@@ -4086,7 +4120,10 @@ method static
     modprobe -q net-pf-10 > /dev/null 2>&1 || true # ignore failure.
     ifconfig %iface% [[media %media%]] [[hw %hwaddress%]] [[mtu %mtu%]] up
     ifconfig %iface% add %address%/%netmask%
-    [[ route -A inet6 add ::/0 gw %gateway% %iface% ]] 
+    [[ /lib/freebsd/route add -inet6 ::/0 %gateway% ]] \
+        if ( iskfreebsd() )
+    [[ route -A inet6 add ::/0 gw %gateway% %iface% ]] \
+        elsif ( 1 )
 
   down
     ifconfig %iface% down


--- End Message ---
--- Begin Message ---
Source: ifupdown
Source-Version: 0.7~alpha5+really0.6.16

We believe that the bug you reported is fixed in the latest version of
ifupdown, which is due to be installed in the Debian FTP archive:

ifupdown_0.7~alpha5+really0.6.16.dsc
  to main/i/ifupdown/ifupdown_0.7~alpha5+really0.6.16.dsc
ifupdown_0.7~alpha5+really0.6.16.tar.gz
  to main/i/ifupdown/ifupdown_0.7~alpha5+really0.6.16.tar.gz
ifupdown_0.7~alpha5+really0.6.16_amd64.deb
  to main/i/ifupdown/ifupdown_0.7~alpha5+really0.6.16_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrew O. Shadura <[email protected]> (supplier of updated ifupdown package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Format: 1.8
Date: Sun, 23 Oct 2011 21:10:44 +0300
Source: ifupdown
Binary: ifupdown
Architecture: source amd64
Version: 0.7~alpha5+really0.6.16
Distribution: unstable
Urgency: low
Maintainer: Andrew O. Shadura <[email protected]>
Changed-By: Andrew O. Shadura <[email protected]>
Description: 
 ifupdown   - high level tools to configure network interfaces
Closes: 646291
Changes: 
 ifupdown (0.7~alpha5+really0.6.16) unstable; urgency=low
 .
   * Use FreeBSD version of route, thanks to Robert Millan
     for the patch (Closes: #646291).
Checksums-Sha1: 
 cd985b68f27e2a9a6d392395c41ea0caf2510404 942 
ifupdown_0.7~alpha5+really0.6.16.dsc
 83abe6bd5e1b077695aa92ba3fcc30db49524c8c 98295 
ifupdown_0.7~alpha5+really0.6.16.tar.gz
 965efc1697624a7a9ebc1b4627857141c95e550d 48876 
ifupdown_0.7~alpha5+really0.6.16_amd64.deb
Checksums-Sha256: 
 343e740f845a5ffa324604599789ca346e12175c997dd01cdd4b782489b178e0 942 
ifupdown_0.7~alpha5+really0.6.16.dsc
 ecf7d8e445be96b975732546e0c5578dd711c830aee73c5cf956ca3689a36439 98295 
ifupdown_0.7~alpha5+really0.6.16.tar.gz
 dc3e53593f2850f55d62dac557febd38ee4abd75ea90950a60432968a2af222d 48876 
ifupdown_0.7~alpha5+really0.6.16_amd64.deb
Files: 
 54d0557fee449f1b117d6ded0eb5ee62 942 admin important 
ifupdown_0.7~alpha5+really0.6.16.dsc
 1e221c00de69d9d66565d22b9897305f 98295 admin important 
ifupdown_0.7~alpha5+really0.6.16.tar.gz
 bd6630daba4305bac5e7213113ab8b2d 48876 admin important 
ifupdown_0.7~alpha5+really0.6.16_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEAREDAAYFAk6kdFYACgkQVcFcaSW/uEhWqACbB27eEbw9f1I2/MwVIQmumvsu
Z5gAn0kg2yCUUNb14sZ3Axxoun6KWfjg
=M1lk
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to