Your message dated Sun, 06 Nov 2011 10:17:31 +0000
with message-id <[email protected]>
and subject line Bug#647100: fixed in lebiniou 3.13-1
has caused the Debian Bug report #647100,
regarding lebiniou: FTBFS with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
647100: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647100
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: lebiniou
Version: 3.12-1
Severity: normal
Tags: upstream patch
User: [email protected]
Usertags: ld-as-needed
Hello Olivier,
lebiniou fails to build when --as-needed linker option is enabled. Here's
a log of failed build in Ubuntu, where this option is on by default:
https://launchpad.net/ubuntu/+source/lebiniou/3.12-1/+build/2881998/+files/buildlog_ubuntu-precise-i386.lebiniou_3.12-1_FAILEDTOBUILD.txt.gz
There are two problems:
1. Executable is not linked with -lm, while a function from math library is
used.
2. Configure script puts detected libraries in LDFLAGS variable. When linking
the executable, LDFLAGS are passed before the object files, which leads to an
error with --as-needed.
Attached patch puts library flags to correct LIBS variable. It was applied in
Ubuntu:
https://launchpad.net/ubuntu/+source/lebiniou/3.12-1ubuntu1
See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
-- System Information:
Debian Release: wheezy/sid
APT prefers oneiric-updates
APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500,
'oneiric-proposed'), (500, 'oneiric'), (100, 'oneiric-backports')
Architecture: i386 (i686)
Kernel: Linux 3.0.0-13-generic (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: fix build with --as-needed linker option
Put all library flags in LIBS instead of LDFLAGS.
Author: Ilya Barygin <[email protected]>
--- lebiniou-3.12.orig/configure.ac
+++ lebiniou-3.12/configure.ac
@@ -50,20 +50,17 @@
# glib-2.0
PKG_CHECK_MODULES([GLIB], [glib-2.0], , [AC_MSG_ERROR([You must have libglib2.0-dev installed])])
CPPFLAGS="$CPPFLAGS `pkg-config glib-2.0 --cflags`"
-LDFLAGS="$LDFLAGS `pkg-config glib-2.0 --libs`"
# fftw3
PKG_CHECK_MODULES([FFTW3], [fftw3], , [AC_MSG_ERROR([You must have libfftw3-dev installed])])
CPPFLAGS="$CPPFLAGS `pkg-config fftw3 --cflags`"
-LDFLAGS="$LDFLAGS `pkg-config fftw3 --libs`"
# libxml-2.0
PKG_CHECK_MODULES([XML2], [libxml-2.0 >= 2.6.0], , [AC_MSG_ERROR([You must have libxml2-dev >= 2.6 installed])])
CPPFLAGS="$CPPFLAGS `pkg-config libxml-2.0 --cflags`"
-LDFLAGS="$LDFLAGS `pkg-config libxml-2.0 --libs`"
# zlib - we assume it's installed on most systems
-LDFLAGS="$LDFLAGS -lz"
+LIBS="${GLIB_LIBS} ${FFTW3_LIBS} ${XML2_LIBS} -lz -lm"
# We need to know which prefix we used to find some default values
if test "x${prefix}" = "xNONE"; then
@@ -257,13 +254,14 @@
*)
os_family=linux
os_netbsd_or_openbsd=false
- LDFLAGS="$LDFLAGS -ldl"
+ LIBS="$LIBS -ldl"
DEFAULT_INPUT_PLUGIN=alsa
esac
AC_MSG_RESULT([$os_family])
AM_CONDITIONAL([OS_LINUX_FAMILY], [test x"$os_family" = x"linux"])
AM_CONDITIONAL([OS_NETBSD_OR_OPENBSD], [test x"$os_netbsd_or_openbsd" = x"true"])
AC_DEFINE_UNQUOTED([DEFAULT_INPUT_PLUGIN], ["$DEFAULT_INPUT_PLUGIN"], [Default input plugin])
+AC_SUBST(LIBS)
dnl ------------------------------------------------------------------
dnl Options
--- End Message ---
--- Begin Message ---
Source: lebiniou
Source-Version: 3.13-1
We believe that the bug you reported is fixed in the latest version of
lebiniou, which is due to be installed in the Debian FTP archive:
lebiniou_3.13-1.debian.tar.gz
to main/l/lebiniou/lebiniou_3.13-1.debian.tar.gz
lebiniou_3.13-1.dsc
to main/l/lebiniou/lebiniou_3.13-1.dsc
lebiniou_3.13-1_amd64.deb
to main/l/lebiniou/lebiniou_3.13-1_amd64.deb
lebiniou_3.13.orig.tar.gz
to main/l/lebiniou/lebiniou_3.13.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Olivier Girondel <[email protected]> (supplier of updated lebiniou package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 22 Oct 2011 21:04:28 +0200
Source: lebiniou
Binary: lebiniou
Architecture: source amd64
Version: 3.13-1
Distribution: unstable
Urgency: low
Maintainer: Olivier Girondel <[email protected]>
Changed-By: Olivier Girondel <[email protected]>
Description:
lebiniou - displays images that evolve with sound
Closes: 647100
Changes:
lebiniou (3.13-1) unstable; urgency=low
.
* New upstream release 3.13.
* Put all library flags in LIBS instead of LDFLAGS. (Closes: #647100)
Checksums-Sha1:
785568fd5f5a43d99989f3f50cc3fd102e130ea5 1146 lebiniou_3.13-1.dsc
8179dcfd6fccc37015c6869db0b2fd74d7a1a5fc 532038 lebiniou_3.13.orig.tar.gz
3d2209c1b09a9f2c86564884b59b2497b6c037f0 2913 lebiniou_3.13-1.debian.tar.gz
22f0fb2f5faacc28b8c637eabe4da4efdc6df583 383826 lebiniou_3.13-1_amd64.deb
Checksums-Sha256:
d43ed73a06be383c22e16e670e70ef55f7876467620d33b7491d72428835f333 1146
lebiniou_3.13-1.dsc
378e6933efd91b66dfd0ba953544061ef048dff0c5475ae91de7763ef297d91c 532038
lebiniou_3.13.orig.tar.gz
2777b6774c27a0ba9fa9a79b60ef273b953a485c99146ae863df16180e8dd63a 2913
lebiniou_3.13-1.debian.tar.gz
6312fe2842d95a460ae49d35b3f0c8e846c2d732d2ea9ad45def19589a18c7c3 383826
lebiniou_3.13-1_amd64.deb
Files:
f9c9aa9a540118b67a57140d9ce37234 1146 graphics extra lebiniou_3.13-1.dsc
6ae8547eea84febab6eeda30e380873f 532038 graphics extra
lebiniou_3.13.orig.tar.gz
bde452db1ed39af5dd5dd40bdbba3dcd 2913 graphics extra
lebiniou_3.13-1.debian.tar.gz
9148435c82737839c5a5395c59350b65 383826 graphics extra
lebiniou_3.13-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iD8DBQFOtl3dvdkzt4X+wX8RAk8bAJ9oWljWAmMmfmtU56ef9GvUXUKlhACdFgVm
cFWpB9OlRWfoyOtA5GMI6tM=
=kUai
-----END PGP SIGNATURE-----
--- End Message ---
