Your message dated Sun, 18 Dec 2011 15:05:52 +0000
with message-id <[email protected]>
and subject line Bug#615138: fixed in ngrep 1.45.ds2-10
has caused the Debian Bug report #615138,
regarding ngrep uses incorrect ipv6 offsets
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
615138: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=615138
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ngrep
Version: 1.45.ds2-9
Severity: important
Tags: patch ipv6
It is known from LP #567286 in [1], since April, 2010, that ngrep
is incorrectly handling IPv6 packet lengths. A patch written by
Simon Engelsman was included as an attachment [2].
This correction should really have gone into the package well before
the development freeze of Squeeze. Now the time is ripe again.
I include here a trivial variation of the original patch.
The code alterations have been tried and tested with ICPMv6,
as well as TCP and UDP transported by IPv6.
Best regards,
Mats Erik Andersson, DM
[1] https://bugs.launchpad.net/ubuntu/+source/ngrep/+bug/567286
[2] http://launchpadlibrarian.net/44952147/ngrep-fix-ipv6-support.patch
-------------------------------------------------------------------
--- ngrep-1.45.ds2.debian/ngrep.c 2011-02-24 23:53:37.000000000 +0100
+++ ngrep-1.45.ds2/ngrep.c 2011-02-26 01:01:41.000000000 +0100
@@ -711,11 +711,6 @@
data = (unsigned char *)(tcp_pkt) + tcphdr_offset;
len -= link_offset + ip_hl + tcphdr_offset;
-#if USE_IPv6
- if (ip_ver == 6)
- len -= ntohs(ip6_pkt->ip6_plen);
-#endif
-
if ((int32_t)len < 0)
len = 0;
@@ -731,11 +726,6 @@
data = (unsigned char *)(udp_pkt) + udphdr_offset;
len -= link_offset + ip_hl + udphdr_offset;
-#if USE_IPv6
- if (ip_ver == 6)
- len -= ntohs(ip6_pkt->ip6_plen);
-#endif
-
if ((int32_t)len < 0)
len = 0;
@@ -769,7 +759,7 @@
uint16_t icmp6hdr_offset = (frag_offset) ? 0 : 4;
data = (unsigned char *)(icmp6_pkt) + icmp6hdr_offset;
- len -= link_offset + ip_hl + ntohs(ip6_pkt->ip6_plen) +
icmp6hdr_offset;
+ len -= link_offset + ip_hl + icmp6hdr_offset;
if ((int32_t)len < 0)
len = 0;
--- End Message ---
--- Begin Message ---
Source: ngrep
Source-Version: 1.45.ds2-10
We believe that the bug you reported is fixed in the latest version of
ngrep, which is due to be installed in the Debian FTP archive:
ngrep_1.45.ds2-10.debian.tar.gz
to main/n/ngrep/ngrep_1.45.ds2-10.debian.tar.gz
ngrep_1.45.ds2-10.dsc
to main/n/ngrep/ngrep_1.45.ds2-10.dsc
ngrep_1.45.ds2-10_amd64.deb
to main/n/ngrep/ngrep_1.45.ds2-10_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Romain Francoise <[email protected]> (supplier of updated ngrep package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 18 Dec 2011 14:45:36 +0100
Source: ngrep
Binary: ngrep
Architecture: source amd64
Version: 1.45.ds2-10
Distribution: unstable
Urgency: low
Maintainer: Romain Francoise <[email protected]>
Changed-By: Romain Francoise <[email protected]>
Description:
ngrep - grep for network traffic
Closes: 615138
Changes:
ngrep (1.45.ds2-10) unstable; urgency=low
.
* Enable hardening via dpkg-buildflags.
* Bump Standards-Version to 3.9.2.
* Cherry-pick commit ca90da66ac from upstream Git to fix dumping of IPv6
traffic (closes: #615138) (LP: #567286).
Checksums-Sha1:
4e3217f299117a03ae42b7a0fb6bd661d14bdee2 1258 ngrep_1.45.ds2-10.dsc
302a087cd490831d429e307156f01df223d9eb5b 11546 ngrep_1.45.ds2-10.debian.tar.gz
e0837e031d425fba47f9f4c4a100a8a53af18bc1 33990 ngrep_1.45.ds2-10_amd64.deb
Checksums-Sha256:
9d6fce7d40cf963f21d73c6e19c33bf596c33e9ee1ff7da1b7b6c62b560c9dac 1258
ngrep_1.45.ds2-10.dsc
e78fed526c8450d35a79a68a1879b99b346432b7ea069773fe1c157d0c268d95 11546
ngrep_1.45.ds2-10.debian.tar.gz
48e6210647425b7c97083b0ab6699c59594cc7bdf9b3e2cc09233fea18074eba 33990
ngrep_1.45.ds2-10_amd64.deb
Files:
282cc1ca92617dd292999943510cc27a 1258 net optional ngrep_1.45.ds2-10.dsc
b28c4245f8e80b445412e9d09eb9315d 11546 net optional
ngrep_1.45.ds2-10.debian.tar.gz
7f6685f554da865a73e30f0d4fdae2ad 33990 net optional ngrep_1.45.ds2-10_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iD8DBQFO7e9sogN2vsA8Vt8RAvDFAJ99GFdCKTVfIuEu9vRqQAa92Tmt7ACfXfga
g3tZ4ZqFSGU+E4Fpq2oqLo0=
=eYeu
-----END PGP SIGNATURE-----
--- End Message ---
