Your message dated Fri, 23 Dec 2011 10:17:59 +0000
with message-id <[email protected]>
and subject line Bug#648423: fixed in piuparts 0.42
has caused the Debian Bug report #648423,
regarding piuparts: --minimize has no effect
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
648423: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=648423
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: piuparts
Version: 0.41
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The --minimize option has no effect.
>From my understanding of the code, skip_minimize is always True, and
therefore the minimize() function always returns.

One possibility to re-enable --minimize could be to set skip_minimize
to False when --minimize is set; patch attached that works for me.

(Other options might be to think about the default values.)

Cheers,
gregor

- -- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'experimental'), (500, 'testing'), (500, 
'stable'), (500, 'oldstable')
Architecture: i386 (i686)

Kernel: Linux 3.1.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=de_AT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages piuparts depends on:
ii  apt            0.8.15.9     
ii  debootstrap    1.0.37       
ii  lsb-release    3.2-28       
ii  lsof           4.81.dfsg.1-1
ii  python         2.7.2-9      
ii  python-debian  0.1.21       
ii  python2.6      2.6.7-4      
ii  python2.7      2.7.2-6      

piuparts recommends no packages.

Versions of packages piuparts suggests:
pn  ghostscript  9.04~dfsg-2
pn  python-rpy   <none>     

- -- no debconf information

- -- debsums errors found:
debsums: changed file /usr/sbin/piuparts (from piuparts package)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOvSX9AAoJELs6aAGGSaoGLwQQALdHMkcpSSsz/eEWscOn9nRc
s7u1oGHIzc6boIWS0LAiLOB/gBPeqT5dWwW4FtOMTrxajJUAC8cHvk7umJz5eNYz
F/KdR2BQ4B/486MxOdTCslzS8I3rZDRLIPRVpdSor/6YZK//tLuJKnpiZZ4pDdZS
YqPJZDWY1bhmLBuTPrHZV95Z/psqF+UEaPMMce9dIUAH7eSENW22P2OGrofqaYZo
AooXUuym03pidcKUVmxfx5THH96j4ErwZoHCo16fsZv/h1DNCs3lnvDADpYLwMvA
gXPAF/D9P+IJP6SQH/Wm64/pw/PbeXAKnq9Yq91xTJ76CTcu+Xb2XC1rmXDa41GR
gBibANmCyA8pqAAOl5B+o4iIMebq7CxqRGhaMc2yY/No4j3l5gLq1AoABNFy7PbM
RkWkQwk4D3GDXNmNlwWnoWg8FYb9WkweB1Q6OSZsxal40WG4Mq8A2Mlh2NXWPbmE
r6a453IftXwSjYgiX5a8E5z6d4i1uYb3M6wzHtMNeSWgBviS9ak2sEx/FOnSsBPx
3QbfVrovrY7gs3JD1Jh4+6Jme1cranDJk5l6cUA8FQBRC0yzgZAXU9m2h4AcSNZ+
crYqIv98L6JMNkzBUUG1UoS3olOLlvMP4t9ZlfHmbSdALMMKBfYoGDRb6A+pB31e
Sv0+R+lASWsrWkIJ0/aK
=xkTQ
-----END PGP SIGNATURE-----
>From 399f45fa10ff2454f8d7de36a9a7b88dc1d50feb Mon Sep 17 00:00:00 2001
From: gregor herrmann <[email protected]>
Date: Fri, 11 Nov 2011 14:37:08 +0100
Subject: [PATCH] Turn off skip_minimize if minimize is set.

---
 piuparts.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/piuparts.py b/piuparts.py
index 3c11676..d4f5046 100644
--- a/piuparts.py
+++ b/piuparts.py
@@ -2131,6 +2131,8 @@ def parse_command_line():
     settings.keep_sources_list = opts.keep_sources_list
     settings.skip_minimize = opts.skip_minimize
     settings.minimize = opts.minimize
+    if settings.minimize:
+      settings.skip_minimize = False
     settings.list_installed_files = opts.list_installed_files
     settings.no_install_purge_test = opts.no_install_purge_test
     settings.no_upgrade_test = opts.no_upgrade_test
-- 
1.7.7.2


--- End Message ---
--- Begin Message ---
Source: piuparts
Source-Version: 0.42

We believe that the bug you reported is fixed in the latest version of
piuparts, which is due to be installed in the Debian FTP archive:

piuparts_0.42.dsc
  to main/p/piuparts/piuparts_0.42.dsc
piuparts_0.42.tar.gz
  to main/p/piuparts/piuparts_0.42.tar.gz
piuparts_0.42_all.deb
  to main/p/piuparts/piuparts_0.42_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <[email protected]> (supplier of updated piuparts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 23 Dec 2011 10:51:28 +0100
Source: piuparts
Binary: piuparts
Architecture: source all
Version: 0.42
Distribution: unstable
Urgency: low
Maintainer: piuparts developers team <[email protected]>
Changed-By: Holger Levsen <[email protected]>
Description: 
 piuparts   - .deb package installation, upgrading, and removal testing tool
Closes: 387428 522918 588313 589498 628077 638831 638832 640121 640646 640647 
640648 647752 648162 648177 648193 648423 648707 648708 648784 649335 649967
Changes: 
 piuparts (0.42) unstable; urgency=low
 .
   [ Holger Levsen ]
   * piuparts.py:
     - add to self.ignored_files: /etc/blkid.tab (Closes: #638831)
     - add to self.ignored_patterns: /var/lib/apt/lists/.*
     - apply patch by Gregor Herrmann to fix --minimize. (Closes: #648423)
   * Remove Debian.NEWS entry about source in git. (Closes: #640121)
   * piuparts.py, piuparts-report.py, ChangeLog: Expand tabs to spaces.
   * Remove whitespaces from whitespace-only lines.
   * piuparts-report:
     - create maintainer subdirs if they don't exist.
     - detect tests being terminated due to excessive output.
   * Add git to Build-Depends-Indep: as git describe is used to generate
     part of the version string for development builds.
   * Add debian/.gitignore
 .
   [ Mika Pflüger ]
   * piuparts-analyze.py:
     - Rewrite to use python-debianbts to analyze if bugs are filed already.
     - The BTS only tracks source versions, so remove binNMU-part from
       package versions when comparing with versions from the BTS.
     - Reduce noise in the output by only printing one action/advise per
       package.
     - Fix extraction of package versions from bug reports. Thanks to
       Andreas Beckmann for catching and solving the error.
   * debian/control: Add python-apt and python-debianbts to piuparts depends.
 .
   [ Scott Schaefer ]
   * debian/copyright: Make it compliant with DEP-5.
   * piuparts-slave.py:
     - Replace deprecated os.popen2 with subprocess.Popen. (Closes: #640646)
     - Add some more logging.
     - Kill children (hard-coded value, 45 minutes) to ensure test doesn't
       run "forever" (Closes: #640647, #387428)
   * piuparty.py:
     - Kill leftover processes (via SIGTERM, then if that fails, via SIGKILL).
       (Closes: #522918)
     - Test for incorrect diversion handling:  (Closes: #588313)
       a) Existing diversions removed/modified, and/or
       b) Installed diversions not removed by purge.
   * piupartslib/packagesdb.py: Modify several functions in PackagesDB class
     to use python 'set' type, instead of a list.  This permitted replacing
     inefficient combination of unique() function and random.shuffle() with
     python set.pop() method.  Since python prohibits storing non-hashable
     object in a set, minor modifications to piuparts-report and to
     piuparts-master required. (Closes: #640648)
 .
   [ Andreas Beckmann ]
   * *.py: Add vim modeline.
   * piuparts.py:
     - Add unittests for misbehaving symlinks.
     - Fix resolving absolute symlinks of intermediate directory components,
       i.e. /var/run -> /run while checking /etc/motd -> /var/run/motd.
       Solves about 30000 false positives of
       'Broken symlinks: /etc/motd -> /var/run/motd'.  (Closes: #648784)
     - When running commands in the chroot, redirect stdin from /dev/null.
     - Stop using Popen.communicate() as it may run out of memory.
     - Terminate commands producing more than 2 MB of output. (Closes: #649335)
     - Create /etc/dpkg/dpkg.cfg.d/ if missing inside the chroot (e.g. on
       lenny).  (Closes: #647752)
     - Remove logrotate and its dependencies only once.
     - Only run 'apt-get update' after updating the sources.list.
     - Only run 'apt-get clean' before creating tarballs or saving meta data.
     - Do the same checks for running processes and broken symlinks in all
       tests.  (Closes: #648708)
     - Create piupart's apt config in the chroot as /etc/apt.conf.d/piuparts
       instead of /etc/apt.conf in order to allow overriding the settings from
       custom scripts by just dropping new config bits in e.g.
       /etc/apt/apt.conf.d/piuparts-foobar.
     - Integrate diversion checks with Chroot.check_result().
     - Use 'apt-get remove' to remove all packages at once with proper
       dependency ordering.  (Closes: #648162)
     - Purge all packages at once instead of doing it one-by-one.
     - Make restore_selections() reinstall missing packages.  (Closes: #648707)
     - Set more environment variables to let custom scripts know where and
       when they are being run: PIUPARTS_TEST, PIUPARTS_PHASE,
       PIUPARTS_DISTRIBUTION{,_PREV,_NEXT}.  See the README for details.
       (Closes: #589498)
     - Add missing post_install_* custom scripts to install_packages_by_name().
       (Closes: #628077)
     - Remove pre_upgrade_* custom scripts, they can be replaced with
       pre_install_* scripts that check for PIUPARTS_PHASE=upgrade.
     - Add pre_test_* custom scripts.  These are run exactly once at the
       beginning of each test (after recording the initial chroot state).
     - Allow multiple --scriptsdir options, the contents will be merged.
     - Exclude /tmp/scripts when creating a tarball.
     - Use --one-file-system when creating a tarball to exclude bindmounts etc.
     - Restore base system from temp_tgz instead of running debootstrap again.
       (Closes: #648193)
     - Do not fail upgrade/distupgrade tests for a set of packages where not
       all packages exist in the start distribution.  This happens e.g. when
       testing .changes files and packages were split/added. Only install the
       old packages that actually exist according to 'apt-cache show'.
     - Add --extra-old-packages option to intall additional old packages that
       are not in the set of new packages to be tested.  Useful for testing
       upgrades with Conflicts/Replaces relationships, e.g. in package renames
       or merges.
     - Use consistent variable names for package lists.  (Closes: #648177)
     - Compute the changes in restore_selections().
     - Check for settings.scriptsdir inside run_scripts().
     - Consistently use chroot.relative() to build filenames inside the chroot.
   * piupartslib/packagesdb.py:
     - Handle 'unknown-preferred-alternative' state correctly.
     - Add 'does-not-exist' state for dependency resolution to distinguish this
       from 'unknown' state so that the latter only indicates 'unresolvable' or
       'not yet resolved'.
     - Handle virtual packages separately from real packages.
     - Use get_package_state() internally which 'resolves' (purely) virtual
       packages by default (can be disabled).
   * piuparts-master.py:
     - Add a 'status' command that reports package counts for all states.
   * piuparts-slave.py:
     - Fix triggering tarball recreation.
     - Check tarball age regularily.
     - Log tarball creation in *.tgz.log.
     - Request and print package counts from master.
     - Reload section config every time a section is being run.
     - Add precedence attribute to allow prioritizing different sections and to
       suspend processing of low priority ones while there are packages waiting
       in more important sections.
   * piuparts-report.py:
     - state-*.html: Sort package lists by name, display state of all
       alternative dependencies and packages providing a virtual dependency.
     - source/?/*.html: Sort binary packages by name.
     - maintainer/?/*.html: Sort source packages by name.
     - Update list of error states to be highlighted.
     - Archive logs of packages that were removed from the distribution.
     - Speedup generating maintainer summaries.
   * Makefile: Use 'git describe' to get an exact stamp for development
     versions.
 .
   [ Dave Steele ]
   * piuparts-slave.py: make Section.run() report the number of packages
     processed and use this to decide whether a slave should sleep.
     (Closes: #649967)
 .
   [ Stefano Rivera ]
   * piuparts.py:
     - Properly install and remove logrotate.  (Closes: #638832)
     - Use eatmydata by default, add option --no-eatmydata. (This was discussed
       in #633033.)
Checksums-Sha1: 
 d3cd7494c9a52439a5cc90b0e3f017088f79adf2 1672 piuparts_0.42.dsc
 7a9654f7a333f1110b84e95c799f936c13e69e56 88394 piuparts_0.42.tar.gz
 e7d56a58c228fe95214e89c906d7413c47270854 100664 piuparts_0.42_all.deb
Checksums-Sha256: 
 617dacf440620f22ac782979d238e11189d34cff94240f658afa436e619ea74e 1672 
piuparts_0.42.dsc
 0d20f6a6caa071870cdfb2f0359c74ad5a27be6a201349afb87db5b06dcc9334 88394 
piuparts_0.42.tar.gz
 d00b7b6308bf4751ab041a482ee738726e0a80ae19c2be3a4403c5855f4833e2 100664 
piuparts_0.42_all.deb
Files: 
 0c6e07f7d48236dd978888d28b53a166 1672 devel extra piuparts_0.42.dsc
 6e8fdf936068b9beba580f0b9f548052 88394 devel extra piuparts_0.42.tar.gz
 dee2702ded5d2e6cc4052d8e718d3ed0 100664 devel extra piuparts_0.42_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIVAwUBTvRTmwkauFYGmqocAQiI5w//dyIkENEQT+lTeSG8vCtaxhjQYdv1/XZv
IMd+1mcEfNhwVUYZ8oc6mByK5GzUmCDIHd/9sBHoEdYQqwGJFNj16aLV7TpGKf2M
y+Jscltw7W2yo2ydKgJG2PVbiMUXo7tHASVRLRTi9jPxyt+e3l7q1pVYqQE95FNk
+tizo6aXvgMftouj/6Zf6M+ZDGEOJYKu48HXgVW4dLu11dwwwgUAI1oM9URMHw66
jiEwPj+M5kZFZBZWCVA/AjALd2AlvdhuYn5HjgxxMubQyimmd2yr122v4wNVcK3y
owZHltHNQqTwA/fh5rP9skgeuIJdu3mxBleY0eYloVBqRoLH7rZF1hVz+VdIXSZ0
A/389BI22seUHyWMIPNXjfkdrLdGq03Eqd8huXaCwRgcrtHPMCJRmxGzMyPwuyzV
mqpLlxzgnFnAmELa8nE1+GUVDhiSATI9dNj3BW4pW1scN0TQ0uhS4BofKeEuTA1u
0Bot8FPLq8OEWpMdppaSAX2rcfdPGLFErgTAhzm4HEaTNvY4z07tJMgPh37JEKcT
LgIETxH042kyyja7k6eVsTh57nORHd5awzXZweC0mIUq76vCgsQzuCONejpwaRow
ZfDHHq5OzRQsvI2XrQK+3ZV5EVNjbJXneVnwIJl3mF+OwrIBxvVRBdcmmyxEzvYl
G9kd9vPGTyo=
=ieNq
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to