Your message dated Sun, 2 Oct 2005 10:09:54 +0200
with message-id <[EMAIL PROTECTED]>
and subject line Fixed in upload of aptitude 0.3.4-1 to experimental
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Oct 2004 09:49:11 +0000
>From [EMAIL PROTECTED] Wed Oct 06 02:49:11 2004
Return-path: <[EMAIL PROTECTED]>
Received: from postfix4-1.free.fr [213.228.0.62]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CF8Q3-0005tZ-00; Wed, 06 Oct 2004 02:49:11 -0700
Received: from bee.dooz.org (levallois.dooz.org [81.57.180.178])
by postfix4-1.free.fr (Postfix) with ESMTP id 0890B1F3399;
Wed, 6 Oct 2004 11:49:08 +0200 (CEST)
Received: by bee.dooz.org (Postfix, from userid 1000)
id 1A87D680763C; Wed, 6 Oct 2004 11:49:08 +0200 (CEST)
Date: Wed, 6 Oct 2004 11:49:07 +0200
From: =?iso-8859-1?Q?Lo=EFc?= Minier <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: make action on automatic removal customizable
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="wRRV7LY7NUeQGEoC"
Content-Disposition: inline
X-Reportbug-Version: 2.99.5
Content-Transfer-Encoding: 7bit
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
REMOVE_IN_QUOTES autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: aptitude
Version: 0.2.15.8-1
Severity: wishlist
Hi,
I wish I could ask aptitude to purge (and not simply remove) packages
that were installed automatically.
Attached patch proposes a new configuration variable,
Aptitude::Delete-Unused::Purge, which is a boolean defaulting to false.
Long story:
I've starred at the source for a while, and I've found
"pkg_unused_remove" to be the pkg_action_state of packages that are
going to be removed because they were pulled in automatically
(src/generic/apt.cc:find_pkg_state()).
However, I could not see where the package state was updated for
deletion instead of purge. The pkg_action_state is only used after the
decision to remove the package has been taken as far as I can tell.
I've also found where "purge" versus "remove" can be called on a
pkg_item (pkg_item::purge or pkg_item::remove), but that didn't help me
much.
Finally, I've grepped for Delete-Unused, and I think I found what I
wanted to around line 1217 in src/generic/aptcache.cc. The actual
deletion request is done with mark_delete() (at line 1278) which takes
its second argument, "Purge", as a boolean. Now, I only had to make
that argument configurable.
I hope I did not forget anything to update.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED]
Versions of packages aptitude depends on:
ii apt [libapt-pkg-libc6.3-5-3 0.5.27 Advanced front-end for dpkg
ii libc6 2.3.2.ds1-17 GNU C Library: Shared librar=
ies an
ii libgcc1 1:3.4.2-2 GCC support library
ii libncurses5 5.4-4 Shared libraries for termina=
l hand
ii libsigc++-1.2-5c102 1.2.5-1 Type-safe Signal Framework f=
or C++
ii libstdc++5 1:3.3.4-13 The GNU Standard C++ Library=
v3
-- no debconf information
--=20
Lo=EFc Minier <[EMAIL PROTECTED]>
--wRRV7LY7NUeQGEoC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
filename="aptitude-0.2.15.8-1_delete-unused-purge.patch"
diff -ur aptitude-0.2.15.8-orig/doc/en/aptitude.xml
aptitude-0.2.15.8/doc/en/aptitude.xml
--- aptitude-0.2.15.8-orig/doc/en/aptitude.xml 2004-09-28 20:28:07.000000000
+0200
+++ aptitude-0.2.15.8/doc/en/aptitude.xml 2004-10-06 11:33:02.000000000
+0200
@@ -6468,6 +6468,20 @@
</seg>
</seglistitem>
+ <seglistitem id='configDelete-Unused-Purge'>
+ <seg><literal>Aptitude::Delete-Unused::Purge</literal></seg>
+ <seg><literal>false</literal></seg>
+ <seg>
+ If this option is <literal>true</literal>,
+ packages removed because they are no longer
+ required will be completely purged: any
+ remaining files (such as configuration
+ files) related to the package will be removed.
+ For more information, see <xref
+ linkend='secAutoInstall'/>.
+ </seg>
+ </seglistitem>
+
<seglistitem id='configDelete-Unused-Pattern'>
<seg><literal>Aptitude::Delete-Unused-Pattern</literal></seg>
<seg></seg>
diff -ur aptitude-0.2.15.8-orig/src/apt_options.cc
aptitude-0.2.15.8/src/apt_options.cc
--- aptitude-0.2.15.8-orig/src/apt_options.cc 2004-08-18 15:48:12.000000000
+0200
+++ aptitude-0.2.15.8/src/apt_options.cc 2004-10-06 10:21:38.000000000
+0200
@@ -134,6 +134,8 @@
PACKAGE "::Recommends-Important", true),
option_item(N_("Remove unused packages automatically"),
PACKAGE "::Delete-Unused", true),
+ option_item(N_("Purge automatically removed packages"),
+ PACKAGE "::Delete-Unused::Purge", false),
option_item(N_("Automatically remove unused packages matching this filter"),
PACKAGE "::Delete-Unused-Pattern", ""),
option_item()
diff -ur aptitude-0.2.15.8-orig/src/generic/aptcache.cc
aptitude-0.2.15.8/src/generic/aptcache.cc
--- aptitude-0.2.15.8-orig/src/generic/aptcache.cc 2004-08-18
15:48:16.000000000 +0200
+++ aptitude-0.2.15.8/src/generic/aptcache.cc 2004-10-06 10:27:26.000000000
+0200
@@ -1215,6 +1215,7 @@
}
bool delete_unused=aptcfg->FindB(PACKAGE "::Delete-Unused", true);
+ bool delete_unused_purge=aptcfg->FindB(PACKAGE "::Delete-Unused::Purge",
false);
for(pkgCache::PkgIterator p=PkgBegin(); !p.end(); ++p)
{
@@ -1275,7 +1276,7 @@
}
if(do_delete)
- mark_delete(p, false, true, undo);
+ mark_delete(p, delete_unused_purge, true, undo);
}
}
}
--wRRV7LY7NUeQGEoC--
---------------------------------------
Received: (at 275150-done) by bugs.debian.org; 2 Oct 2005 08:09:59 +0000
>From [EMAIL PROTECTED] Sun Oct 02 01:09:59 2005
Return-path: <[EMAIL PROTECTED]>
Received: from 5301d.unt0.torres.l21.ma.zugschlus.de (torres.zugschlus.de)
[217.151.83.1] (Debian-exim)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1ELyv0-0006b5-00; Sun, 02 Oct 2005 01:09:58 -0700
Received: from lefler.int.l21.ma.zugschlus.de ([192.168.130.38])
by torres.zugschlus.de with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
(Exim 4.53)
id 1ELyux-0005qo-0N; Sun, 02 Oct 2005 10:09:55 +0200
Received: from mh by lefler.int.l21.ma.zugschlus.de with local (Exim 4.52)
id 1ELyuw-00080G-FN; Sun, 02 Oct 2005 10:09:54 +0200
Date: Sun, 2 Oct 2005 10:09:54 +0200
From: Marc Haber <[EMAIL PROTECTED]>
To: Daniel Burrows <[EMAIL PROTECTED]>
Cc: Marc Haber <[EMAIL PROTECTED]>,
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Subject: Re: Fixed in upload of aptitude 0.3.4-1 to experimental
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
User-Agent: Mutt/1.5.10i
X-Spam-Score: (-----) -5.9
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 24
Version: 0.3.4-1
tagging bugs as fixed in 0.3.4-1, as cleared with dburrows on IRC.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
