Your message dated Thu, 19 Jan 2012 00:33:30 +0000
with message-id <[email protected]>
and subject line Bug#648741: fixed in libgii 1:1.0.2-4.1
has caused the Debian Bug report #648741,
regarding libgii: FTBFS on armhf, add gcc atomics support
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
648741: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=648741
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libgii
Version: 1.0.2-4
Severity: important
Tags: patch
Hi,
libgii fails on armhf, because of thumb2 problems:
http://buildd.debian-ports.org/status/fetch.php?pkg=libgii&arch=armhf&ver=1%3A1.0.2-4&stamp=1300235163
(armel passes because it does not use thumb2). However, I added a
patch which uses the gcc atomics intrinsics, which should work on all
platforms where asm routines are not available. It passes the
regression tests in libgii and I've tested it with libggi (and vlc)
and it worked. I've only enabled it for armhf in the rules file, but
if you think it should apply to other arches, it might be worth it.
Regards
Konstantinos
diff -ruN libgii-1.0.2/debian/rules libgii-1.0.2.armhf/debian/rules
--- libgii-1.0.2/debian/rules 2011-11-03 17:58:44.000000000 +0200
+++ libgii-1.0.2.armhf/debian/rules 2011-10-01 19:52:39.000000000 +0300
@@ -2,6 +2,7 @@
include /usr/share/quilt/quilt.make
+DEB_HOST_ARCH ?= $(shell dpkg-architecture -qDEB_HOST_ARCH)
DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
@@ -17,6 +18,10 @@
CXXFLAGS += -O2
endif
+ifneq (,$(findstring armhf,$(DEB_HOST_ARCH)))
+ CFLAGS += -DHAVE_GCC_ATOMICS
+endif
+
configure: patch configure-stamp
configure-stamp:
dh_testdir
diff -ruN libgii-1.0.2/gg/gglock.c libgii-1.0.2.armhf/gg/gglock.c
--- libgii-1.0.2/gg/gglock.c 2004-03-08 08:36:28.000000000 +0200
+++ libgii-1.0.2.armhf/gg/gglock.c 2011-10-31 17:51:32.829637818 +0200
@@ -90,7 +90,8 @@
void ggUnlock(void *lock)
{
- *((int*)lock) = 0;
+ int *lck = lock;
+ lockrelease(lck);
return;
}
diff -ruN libgii-1.0.2/gg/gglock.h libgii-1.0.2.armhf/gg/gglock.h
--- libgii-1.0.2/gg/gglock.h 2005-07-31 18:31:10.000000000 +0300
+++ libgii-1.0.2.armhf/gg/gglock.h 2011-10-31 17:51:23.719633940 +0200
@@ -32,6 +32,33 @@
#ifdef __GNUC__
+#ifdef HAVE_GCC_ATOMICS
+
+static inline int
+testandset(int *lock)
+{
+ int ret;
+
+ ret = __sync_lock_test_and_set(lock, 1);
+
+ return ret;
+}
+
+static inline int
+lockrelease(int *lock)
+{
+ __sync_lock_release(lock);
+}
+#define HAVE_TESTANDSET
+
+#else // HAVE_GCC_ATOMICS
+
+static inline int
+lockrelease(int *lock)
+{
+ *lock = 0;
+}
+
#if defined(__i386__) || defined(__i386) || defined(i386) || \
defined(__i486__) || defined(__i486) || defined(i486) || \
defined(__i586__) || defined(__i586) || defined(i586) || \
@@ -185,7 +212,7 @@
}
#define HAVE_TESTANDSET
#endif /* Supported platforms */
-
+#endif /* HAVE_GCC_ATOMICS */
#endif /* __GNUC__ */
--- End Message ---
--- Begin Message ---
Source: libgii
Source-Version: 1:1.0.2-4.1
We believe that the bug you reported is fixed in the latest version of
libgii, which is due to be installed in the Debian FTP archive:
libgii1-dev_1.0.2-4.1_armhf.deb
to main/libg/libgii/libgii1-dev_1.0.2-4.1_armhf.deb
libgii1-target-x_1.0.2-4.1_armhf.deb
to main/libg/libgii/libgii1-target-x_1.0.2-4.1_armhf.deb
libgii1_1.0.2-4.1_armhf.deb
to main/libg/libgii/libgii1_1.0.2-4.1_armhf.deb
libgii_1.0.2-4.1.diff.gz
to main/libg/libgii/libgii_1.0.2-4.1.diff.gz
libgii_1.0.2-4.1.dsc
to main/libg/libgii/libgii_1.0.2-4.1.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Konstantinos Margaritis <[email protected]> (supplier of updated libgii package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 11 Jan 2012 23:16:48 +0000
Source: libgii
Binary: libgii1 libgii1-target-x libgii1-dev
Architecture: source armhf
Version: 1:1.0.2-4.1
Distribution: unstable
Urgency: low
Maintainer: Bradley Smith <[email protected]>
Changed-By: Konstantinos Margaritis <[email protected]>
Description:
libgii1 - General Input Interface runtime libraries
libgii1-dev - General Input Interface development package
libgii1-target-x - General Input Interface X input target
Closes: 648741
Changes:
libgii (1:1.0.2-4.1) unstable; urgency=low
.
* NMU, add support for gcc atomics, enable it on armhf. (Closes: #648741)
Checksums-Sha1:
75feb49e33d833f24cd7907162f7c7e2fca0fe34 1947 libgii_1.0.2-4.1.dsc
ec4c14fd2d87a032b717dc2e560311207ad08818 22583 libgii_1.0.2-4.1.diff.gz
4b85f48d810b5d4e4207028f4b915658040754d0 271794 libgii1_1.0.2-4.1_armhf.deb
ae727bf24cda780a03db60e4e85ad55bb4490b12 83086
libgii1-target-x_1.0.2-4.1_armhf.deb
12a9cba565810bf66293432b2551b81ab053670a 191006 libgii1-dev_1.0.2-4.1_armhf.deb
Checksums-Sha256:
a0582bc054471221cc362c97dc811acf31b5aceda11543b8ea778371d572c6f4 1947
libgii_1.0.2-4.1.dsc
e0838ca5f3dea92cffa85ef449bb12f4d0be4670e998e520297aaf54b8de6941 22583
libgii_1.0.2-4.1.diff.gz
15b158f805aa86346450e3572f19fa37de8953c86ec1e1aabefd01af5005a659 271794
libgii1_1.0.2-4.1_armhf.deb
b4d93a7e232a53767e5abd5327510adf7252f3540b180a9eeb18effd57dd0e01 83086
libgii1-target-x_1.0.2-4.1_armhf.deb
691d5a3ab66bf538c6711810eb405fdce2a80372c9462adfe1febd6eb20e6eb3 191006
libgii1-dev_1.0.2-4.1_armhf.deb
Files:
fbdc2c1301974fb80b989e204ac63a6a 1947 libs optional libgii_1.0.2-4.1.dsc
a4773d51a1feda21a0e6403061a08700 22583 libs optional libgii_1.0.2-4.1.diff.gz
846cfc8f0fb98fe5d4502ff32c21df22 271794 libs optional
libgii1_1.0.2-4.1_armhf.deb
14bcfae939adf49b21afdcb17794d317 83086 libs optional
libgii1-target-x_1.0.2-4.1_armhf.deb
574d821351d563a7c096c42fb9f90880 191006 libdevel optional
libgii1-dev_1.0.2-4.1_armhf.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJPDlB8AAoJEGYGAn9kNxJM4rAQAICG8NJwTEompJDKDwvECcIg
vIRj8jYDoTGXY5eyg4Bh5OQCXVc/Ccq6JD1rHFtJnsyaJOq/K/WbuIvfvqxppvcU
DIR4KPEOId4zaVQ4N7aqYodehQ4FZMErRLP4KLc3GGJJZ9eKZNq9U4cpCrZaMLej
pSstJiGbioknQDYUdfj7hhsZyrygvyiHa6mg+UR5Tk1x6KhY/XzkzLQfB7DzpZa5
qrfXX2OECWNkvewhvsnoZ3j4DXekBWVZUCVdcZtSzIa4XcoAStQn44hREvulOhEv
TH650o4T7+E1uHbdj+8qmt1zaAz+F5ja5UvtytMfum+ISmuR8yfXB1UqudZmRhCJ
c8gYkvO3WlVh74olvcFir+tr9k4S2PrySPVYoV7PTw8nuw5lIPoA0HO+HqGFZA7Y
uUYH8WYFQDgKrNLstkganmY3xJ0++GTEBxQJ7sVq9HhBd332A6tcCHDHeXCOqvEI
C3tZ6gGdyVYy9Y6MHkCYFKkJ+bJW7auORvCWhD8GZIAc/joi7PDf5HyL0I0pxfzN
P0RmPc9QYhldZ1dnvG31EUKXXVCSIahtMQUiefDXz9sRYzBWZFqHHdQo0EM44ZxO
3kCRZecWLB02RJxLSe60E03SdZedExuNMnkDKpzbCn7Rq+ep5ifOJRW3v7VVvRoM
WamVWfCXdm0UALmZWzCB
=oKNR
-----END PGP SIGNATURE-----
--- End Message ---
