Your message dated Sun, 19 Feb 2012 00:03:44 +0000
with message-id <[email protected]>
and subject line Bug#659792: fixed in stella 3.5.5-2
has caused the Debian Bug report #659792,
regarding stella: use dh_installdeb maintscript support
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
659792: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659792
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: stella
Version: 3.5-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before stella.
This seems generally undesirable; it would be better to enforce a single
code path. (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all. Here's a patch:
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
diff -Nru stella-3.5/debian/control stella-3.5/debian/control
--- stella-3.5/debian/control 2011-12-29 22:45:07.000000000 +0000
+++ stella-3.5/debian/control 2012-02-13 18:42:55.000000000 +0000
@@ -5,13 +5,14 @@
Uploaders: Stephen Kitt <[email protected]>
DM-Upload-Allowed: yes
Standards-Version: 3.9.2
-Build-Depends: debhelper (>= 7.0.50), libsdl1.2-dev, zlib1g-dev, libpng12-dev,
autotools-dev
+Build-Depends: debhelper (>= 8.1.0~), libsdl1.2-dev, zlib1g-dev, libpng12-dev,
autotools-dev
Homepage: http://stella.sf.net
Vcs-Git: git://git.debian.org/git/pkg-games/stella.git
Vcs-Browser: http://git.debian.org/?p=pkg-games/stella.git
Package: stella
Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Atari 2600 Emulator for SDL & the X Window System
Stella is a portable emulator of the old Atari 2600 video-game
diff -Nru stella-3.5/debian/maintscript stella-3.5/debian/maintscript
--- stella-3.5/debian/maintscript 1970-01-01 01:00:00.000000000 +0100
+++ stella-3.5/debian/maintscript 2012-02-13 18:41:45.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/stella.pro 3.2-1
diff -Nru stella-3.5/debian/postinst stella-3.5/debian/postinst
--- stella-3.5/debian/postinst 2011-06-15 22:48:02.000000000 +0100
+++ stella-3.5/debian/postinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,43 +0,0 @@
-#!/bin/sh
-# postinst script for stella
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-# * <postinst> `configure' <most-recently-configured-version>
-# * <old-postinst> `abort-upgrade' <new version>
-# * <conflictor's-postinst> `abort-remove' `in-favour' <package>
-# <new-version>
-# * <postinst> `abort-remove'
-# * <deconfigured's-postinst> `abort-deconfigure' `in-favour'
-# <failed-install-package> <version> `removing'
-# <conflicting-package> <version>
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile /etc/stella.pro 3.2-1 stella -- "$@"
-fi
-
-case "$1" in
- configure)
- ;;
-
- abort-upgrade|abort-remove|abort-deconfigure)
- ;;
-
- *)
- echo "postinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
diff -Nru stella-3.5/debian/postrm stella-3.5/debian/postrm
--- stella-3.5/debian/postrm 2011-06-15 22:48:02.000000000 +0100
+++ stella-3.5/debian/postrm 1970-01-01 01:00:00.000000000 +0100
@@ -1,41 +0,0 @@
-#!/bin/sh
-# postrm script for stella
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-# * <postrm> `remove'
-# * <postrm> `purge'
-# * <old-postrm> `upgrade' <new-version>
-# * <new-postrm> `failed-upgrade' <old-version>
-# * <new-postrm> `abort-install'
-# * <new-postrm> `abort-install' <old-version>
-# * <new-postrm> `abort-upgrade' <old-version>
-# * <disappearer's-postrm> `disappear' <overwriter>
-# <overwriter-version>
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile /etc/stella.pro 3.2-1 stella -- "$@"
-fi
-
-case "$1" in
- purge|remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
- ;;
-
- *)
- echo "postrm called with unknown argument \`$1'" >&2
- exit 1
- ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
diff -Nru stella-3.5/debian/preinst stella-3.5/debian/preinst
--- stella-3.5/debian/preinst 2011-06-15 22:48:02.000000000 +0100
+++ stella-3.5/debian/preinst 1970-01-01 01:00:00.000000000 +0100
@@ -1,39 +0,0 @@
-#!/bin/sh
-# preinst script for stella
-#
-# see: dh_installdeb(1)
-
-set -e
-
-# summary of how this script can be called:
-# * <new-preinst> `install'
-# * <new-preinst> `install' <old-version>
-# * <new-preinst> `upgrade' <old-version>
-# * <old-preinst> `abort-upgrade' <new-version>
-# for details, see http://www.debian.org/doc/debian-policy/ or
-# the debian-policy package
-
-
-if dpkg-maintscript-helper supports rm_conffile; then
- dpkg-maintscript-helper rm_conffile /etc/stella.pro 3.2-1 stella -- "$@"
-fi
-
-case "$1" in
- install|upgrade)
- ;;
-
- abort-upgrade)
- ;;
-
- *)
- echo "preinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
-esac
-
-# dh_installdeb will replace this with shell code automatically
-# generated by other debhelper scripts.
-
-#DEBHELPER#
-
-exit 0
Thanks,
--
Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---
Source: stella
Source-Version: 3.5.5-2
We believe that the bug you reported is fixed in the latest version of
stella, which is due to be installed in the Debian FTP archive:
stella_3.5.5-2.debian.tar.gz
to main/s/stella/stella_3.5.5-2.debian.tar.gz
stella_3.5.5-2.dsc
to main/s/stella/stella_3.5.5-2.dsc
stella_3.5.5-2_i386.deb
to main/s/stella/stella_3.5.5-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated stella package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 19 Feb 2012 00:39:23 +0100
Source: stella
Binary: stella
Architecture: source i386
Version: 3.5.5-2
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Description:
stella - Atari 2600 Emulator for SDL & the X Window System
Closes: 659792
Changes:
stella (3.5.5-2) unstable; urgency=low
.
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend
on a new enough version of dpkg rather than using 'dpkg-maintscript-
helper supports' guards, leading to more predictable behaviour on
upgrades. Thanks to Colin Watson for the patch (closes: #659792).
* Update documentation with last-minute fix from upstream.
Checksums-Sha1:
0192142dc6665d0755ad9e9fb7860ee3c8612127 1947 stella_3.5.5-2.dsc
c04796b13130d021f2a1679c176248acb9636362 13598 stella_3.5.5-2.debian.tar.gz
ef1e952daadcde64381899784d3aadb8e96a9825 1403256 stella_3.5.5-2_i386.deb
Checksums-Sha256:
ad178fb5fac0b77eef7244464b53f1af19f1b17d0aeb3f475face5cb3450bdd7 1947
stella_3.5.5-2.dsc
0599385b02f57f046f6a29dedb901a0b21f1ea0dfe65fc413bf587ddc459cb25 13598
stella_3.5.5-2.debian.tar.gz
74c8b67d5be5bfb9e5303265dda42f46d3804f3ac6f3cdcb378404d90a558e1c 1403256
stella_3.5.5-2_i386.deb
Files:
beea8e9e4e11d0e3136cb27cded87ef4 1947 otherosfs optional stella_3.5.5-2.dsc
d0de4e2c4cbd311a9dfda7845aef51a6 13598 otherosfs optional
stella_3.5.5-2.debian.tar.gz
9ac047e033e584ef072ddd0dad1673d7 1403256 otherosfs optional
stella_3.5.5-2_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJPQDkcAAoJEHWXeKmja0lPmEEP/3iCqMHzYPQFXh1xh5MoWvbH
ZKXoqni4U4FRF72CpITJuY9yYcwx5ai4k7gVID7xSLS68FxBDq6/MYTP0/4V2iZ8
Gk3HiwDVOZfaE7B5MHVTf7lK67aJ0NW7WDy5mkFrThGC9DIU+bihpCcaREsEWG1p
U3KnPG6dZCY2O78GdEja0lRwbWZdmDqwBEIcQVG/PHDRUcdU4iVZHXkghH3M6xGW
oeNqK61KIAqMXwLZLGycmBFq3NKGygcuWsDf4yEVLs8tyGhv1GNHYw1q/FstnVBJ
nmbnXLjerkwHvp0DMSzogD9qB+iFraYRv0TkKSDMtZYVGto4iNz4vu0ZLMO1HRAp
7StH1zRW9R3qYbwxntILdvKJO6CJFUXrmlcgZKh8QJbRHe8EdNiH+2Xn5elUpfcJ
lulHae8hsTUuQKLFxKqxUc6orWRAXk/oraCtKEGXX6US4co/j0VXNmx9KtjaGtMc
vEbALTccczKtA4SPIYEIasmfa8oTPikXiAsYyRQ0WJVh01xwx/wUL1DmY9Ub9OUg
UbYCTpR+7XgpC+xUvNcUvt79KAarYTBWjbwhhHPNmca5uAVvIj9zSDB2NiThR6uo
hxYiJ9aE+4MvUbC5HrEjeSGcEpeGXMn8ms9xCGmFQFroOdPrZ0uZmtzsmXKOpJA7
QG2tUBijgf+/IckjoFSY
=RsgU
-----END PGP SIGNATURE-----
--- End Message ---
