Your message dated Mon, 20 Feb 2012 20:55:10 +0000
with message-id <[email protected]>
and subject line Bug#659794: fixed in tmux 1.7~svn2703-1
has caused the Debian Bug report #659794,
regarding tmux: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
659794: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659794
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tmux
Version: 1.6-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before tmux.  This
seems generally undesirable; it would be better to enforce a single code
path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts.
Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru tmux-1.6/debian/control tmux-1.6/debian/control
--- tmux-1.6/debian/control     2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/control     2012-02-13 18:46:04.000000000 +0000
@@ -14,6 +14,7 @@
 
 Package: tmux
 Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: terminal multiplexer
  tmux enables a number of terminals (or windows) to be accessed and
diff -Nru tmux-1.6/debian/maintscript tmux-1.6/debian/maintscript
--- tmux-1.6/debian/maintscript 1970-01-01 01:00:00.000000000 +0100
+++ tmux-1.6/debian/maintscript 2012-02-13 18:45:18.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/init.d/tmux-cleanup 1.4-6
diff -Nru tmux-1.6/debian/postinst tmux-1.6/debian/postinst
--- tmux-1.6/debian/postinst    2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/postinst    2012-02-13 18:45:34.000000000 +0000
@@ -2,10 +2,6 @@
 
 set -e
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 if [ "$1" = "configure" ]; then
     if [ -z "$2" ] || dpkg --compare-versions "$2" lt "1.5-3"; then
        add-shell /usr/bin/tmux
diff -Nru tmux-1.6/debian/postrm tmux-1.6/debian/postrm
--- tmux-1.6/debian/postrm      2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/postrm      2012-02-13 18:45:37.000000000 +0000
@@ -2,10 +2,6 @@
 
 set -e
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 if [ "$1" = "remove" ]; then
     remove-shell /usr/bin/tmux
 fi
diff -Nru tmux-1.6/debian/preinst tmux-1.6/debian/preinst
--- tmux-1.6/debian/preinst     2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/preinst     2012-02-13 18:45:41.000000000 +0000
@@ -7,8 +7,4 @@
     update-rc.d -f tmux-cleanup remove >/dev/null
 fi
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 #DEBHELPER#

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: tmux
Source-Version: 1.7~svn2703-1

We believe that the bug you reported is fixed in the latest version of
tmux, which is due to be installed in the Debian FTP archive:

tmux_1.7~svn2703-1.debian.tar.gz
  to main/t/tmux/tmux_1.7~svn2703-1.debian.tar.gz
tmux_1.7~svn2703-1.dsc
  to main/t/tmux/tmux_1.7~svn2703-1.dsc
tmux_1.7~svn2703-1_amd64.deb
  to main/t/tmux/tmux_1.7~svn2703-1_amd64.deb
tmux_1.7~svn2703.orig.tar.gz
  to main/t/tmux/tmux_1.7~svn2703.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Romain Francoise <[email protected]> (supplier of updated tmux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 20 Feb 2012 21:15:09 +0100
Source: tmux
Binary: tmux
Architecture: source amd64
Version: 1.7~svn2703-1
Distribution: experimental
Urgency: low
Maintainer: Karl Ferdinand Ebert <[email protected]>
Changed-By: Romain Francoise <[email protected]>
Description: 
 tmux       - terminal multiplexer
Closes: 659794
Changes: 
 tmux (1.7~svn2703-1) experimental; urgency=low
 .
   [ Romain Francoise ]
   * New upstream snapshot from Subversion (r2703).
 .
   [ Colin Watson ]
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
     new enough version of dpkg rather than using 'dpkg-maintscript-helper
     supports' guards, leading to more predictable behaviour on upgrades
     (closes: #659794).
Checksums-Sha1: 
 4c0927aca46f9c4c029ff326fa7342e1e9adad43 1302 tmux_1.7~svn2703-1.dsc
 f8d3568a9d74b7554fb159765edee1901e05f5a6 409969 tmux_1.7~svn2703.orig.tar.gz
 b14f3ecef664e39224a805ac00eed1d1181fdbcc 10119 tmux_1.7~svn2703-1.debian.tar.gz
 946e62c7cad7b6d608abc975a9a002601e2068fe 250666 tmux_1.7~svn2703-1_amd64.deb
Checksums-Sha256: 
 577ef205419c72d518857cfcaacd84bbe928aa4bdb79dcccac43db9c256ee9e1 1302 
tmux_1.7~svn2703-1.dsc
 6becba033a745c94f0f4abc6e87ede042c15a70b292c238fa12585c1cc67ae55 409969 
tmux_1.7~svn2703.orig.tar.gz
 7af1a56a178d4fbdd37487144798c39418d289905e8c7ef3ae9fa4a80f1d2ad2 10119 
tmux_1.7~svn2703-1.debian.tar.gz
 13b54e6e9a4e2580d178410c74ec9a8493af421fb73f0b90028dd6f9165e2ad5 250666 
tmux_1.7~svn2703-1_amd64.deb
Files: 
 311aaae6216a6acd5e85492cb7cefc9d 1302 admin optional tmux_1.7~svn2703-1.dsc
 7ed3e5bdf57874641ab1957d5c20dbea 409969 admin optional 
tmux_1.7~svn2703.orig.tar.gz
 a5561bf30fab040dc533d443db30824d 10119 admin optional 
tmux_1.7~svn2703-1.debian.tar.gz
 cebeb5fe9e84befabf22ca02946674b1 250666 admin optional 
tmux_1.7~svn2703-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFPQq0hogN2vsA8Vt8RAhEbAJ4jdQjqvhgRoRunC10dc8+5lv4INgCg4S3i
nhIygNILbTpgIXw+m8gBM3I=
=EUQt
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to