Your message dated Wed, 07 Mar 2012 13:47:55 +0000
with message-id <[email protected]>
and subject line Bug#662660: fixed in cups-filters 1.0.4-1
has caused the Debian Bug report #662660,
regarding cups-filters: Please drop ttf-freefonts and use fontconfig to find
the best-matching similar font
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
662660: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662660
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cups-filters
Version: 1.0.2-1
Severity: wishlist
Tags: patch
Hi,
I am sorry I feel the need to re-iterate #495598, but cups's and now cups-
filters's hard dependency on ttf-freefonts package is still disturbing me.
However, this time I provide a patch.
I don't think that the cups-filters - especially the texttopdf filter - should
rely on symlinks to actual TTF fontfiles named after the file names listed in
the pdf.utf-8.* maps. Instead, if the symlink in question does not exist or
does not lead to a valid TTF font file, the filter should ask fontconfig what
the next best matching font is. That is what fontconfig is
actually for. This way, the hard dependency on ttf-freefonts could get demoted
to a Recommends or at least get some alternative dependencies added. \o/
TL;DR: Please review the attached patch!
Cheers,
Fabian
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (901, 'testing'), (501, 'unstable'), (101, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 3.1.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages cups-filters depends on:
ii ghostscript 9.05~dfsg-2
ii libc6 2.13-26
ii libcups2 1.5.2-5
ii libcupsfilters1 1.0.2-1
ii libcupsimage2 1.5.2-5
ii libgcc1 1:4.6.2-12
ii libijs-0.35 0.35-8
ii liblcms2-2 2.2+git20110628-2
ii libpoppler13 0.16.7-3
ii libstdc++6 4.6.2-12
ii ttf-freefont 20100919-1
ii zlib1g 1:1.2.6.dfsg-1
Versions of packages cups-filters recommends:
pn colord 0.1.16-2
pn foomatic-filters <none>
pn ghostscript-cups <none>
Versions of packages cups-filters suggests:
pn foomatic-db-compressed-ppds | foomatic-db <none>
--- cups-filters-1.0.2.orig/filter/Makefile
+++ cups-filters-1.0.2/filter/Makefile
@@ -329,7 +329,7 @@ fontembed/libfontembed.a:
texttopdf: texttopdf.o textcommon.o common.o pdfutils.o fontembed/libfontembed.a
echo Linking $@...
- $(CC) $(LDFLAGS) -o $@ texttopdf.o textcommon.o common.o pdfutils.o -Lfontembed -lfontembed $(LIBS)
+ $(CC) $(LDFLAGS) -o $@ texttopdf.o textcommon.o common.o pdfutils.o -Lfontembed -lfontembed $(FONTCONFIG_LIBS) $(LIBS)
#
--- cups-filters-1.0.2.orig/filter/texttopdf.c
+++ cups-filters-1.0.2/filter/texttopdf.c
@@ -32,6 +32,7 @@
#include "fontembed/embed.h"
#include <assert.h>
#include "fontembed/sfnt.h"
+#include <fontconfig/fontconfig.h>
/*
* Globals...
@@ -49,6 +50,21 @@ EMB_PARAMS *font_load(const char *datadi
snprintf(filename, sizeof(filename), "%s/fonts/%s", datadir, font);
OTF_FILE *otf=otf_load(filename);
+
+ if (!otf) {
+ FcPattern *fc_pattern;
+ FcChar8 *fc_file;
+
+ FcInit();
+ fc_pattern = FcNameParse (font);
+ FcConfigSubstitute (0, fc_pattern, FcMatchPattern);
+ FcDefaultSubstitute (fc_pattern);
+ fc_pattern = FcFontMatch (0, fc_pattern, 0);
+ fc_file = FcPatternFormat (fc_pattern, "%{file|cescape}");
+ otf = otf_load(fc_file);
+ free(fc_pattern);
+ }
+
if (!otf) {
// TODO: try /usr/share/fonts/*/*/%s.ttf
return NULL;
--- End Message ---
--- Begin Message ---
Source: cups-filters
Source-Version: 1.0.4-1
We believe that the bug you reported is fixed in the latest version of
cups-filters, which is due to be installed in the Debian FTP archive:
cups-filters_1.0.4-1.debian.tar.gz
to main/c/cups-filters/cups-filters_1.0.4-1.debian.tar.gz
cups-filters_1.0.4-1.dsc
to main/c/cups-filters/cups-filters_1.0.4-1.dsc
cups-filters_1.0.4-1_amd64.deb
to main/c/cups-filters/cups-filters_1.0.4-1_amd64.deb
cups-filters_1.0.4.orig.tar.gz
to main/c/cups-filters/cups-filters_1.0.4.orig.tar.gz
libcupsfilters-dev_1.0.4-1_amd64.deb
to main/c/cups-filters/libcupsfilters-dev_1.0.4-1_amd64.deb
libcupsfilters1_1.0.4-1_amd64.deb
to main/c/cups-filters/libcupsfilters1_1.0.4-1_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Pitt <[email protected]> (supplier of updated cups-filters package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 07 Mar 2012 14:36:49 +0100
Source: cups-filters
Binary: libcupsfilters1 cups-filters libcupsfilters-dev
Architecture: source amd64
Version: 1.0.4-1
Distribution: unstable
Urgency: low
Maintainer: Debian CUPS Maintainers <[email protected]>
Changed-By: Martin Pitt <[email protected]>
Description:
cups-filters - OpenPrinting CUPS Filters
libcupsfilters-dev - OpenPrinting CUPS Filters - Development files for the
library
libcupsfilters1 - OpenPrinting CUPS Filters - Shared library
Closes: 495598 661127 662295 662660
Changes:
cups-filters (1.0.4-1) unstable; urgency=low
.
[ Till Kamppeter ]
* New upstream release
- cups-filters 1.0.4 release
- texttopdf: Fall back to altermative fonts via fontconfig if the
FreeMono TrueType fonts are not installed (Closes: #495598,
Closes: #662660).
- bannertopdf: Fix off-by-one error in page duplication
- bannertopdf: Put indirect references to streams into the page's
contents
- bannertopdf: Let byte offsets for the Xref table of the PDF output
being determined correctly also when the output goes to stdout
(LP: #939735).
- bannertopdf: Output multiple copies of the test page if duplex
and/or N-up is chosen, to let the test page appear on all possible
positions of the sheet (LP: #939530).
- bannertopdf: Scale test page template to fit the job's page size,
get and display full page geometry information, draw the frame which
marks the printable area 1pt smaller, to assure that it gets completely
visible (LP: #921073).
* debian/local/default-testpage.pdf: Added missing "Q" operator to the end of
the page. This broke N-up printing with pdftopdf (LP: #939530).
* debian/control: Added explicit build dependency on libfontconfig1-dev.
(Closes: #661127)
* debian/control: Changed font dependency (for texttopdf) to "ttf-freefont |
fonts-liberation | ttf-dejavu" instead of only "ttf-freefont"
(Closes: #495598, Closes: #662660).
.
[ Martin Pitt ]
* debian/control: Build against libpng-dev, with an alternative to the older
libpng12-dev. (Closes: #662295)
* debian/control: Prefer building against libtiff5-dev if available, falling
back to libtiff-dev.
* debian/control, debian/rules: Move from hardening-wrapper to using
dpkg-buildflags. Bump dpkg-dev build dependency to (>= 1.16.1~) for this.
* debian/copyright: Update Format header for official copyright format 1.0.
* debian/control: Bump Standards-Version to 3.9.3.
* debian/rules: Drop LC_MESSAGES setting, leftover from cups.
* debian/control: Bump libcupsimage2-dev build dependency to ensure to build
against a version which does not conflict on the libtiff?-dev build
dependency.
Checksums-Sha1:
06977eb2b39e754bc4c4e7df35b801d5eb6407f1 2495 cups-filters_1.0.4-1.dsc
f697c8ba9b50c5c9b5eb87aa5b42a9f1885d967f 989868 cups-filters_1.0.4.orig.tar.gz
d9d36b6a14884489c53a3f0035438dd341f99331 36980
cups-filters_1.0.4-1.debian.tar.gz
c6f6a52ca6ca696c4680e8a2873329395e721644 63162
libcupsfilters1_1.0.4-1_amd64.deb
d1a23bf0f44053303130e468356e38e28c1c1bcc 373538 cups-filters_1.0.4-1_amd64.deb
c7953a804cc2e5c920b07b7d2bc9fdf880de192d 74344
libcupsfilters-dev_1.0.4-1_amd64.deb
Checksums-Sha256:
4d437c6bfb4f427d359f0b75b1b0503b5a0b7bfc9bfda29b5d7b810ad5816bb6 2495
cups-filters_1.0.4-1.dsc
c606fe420f166926b772a201fdd363f0ca34bb1ed40ee5ff5ced78fe666158c0 989868
cups-filters_1.0.4.orig.tar.gz
59631e788c9410d14f645a1c0f126607460da8bb44decd2411f26b8f51f080b4 36980
cups-filters_1.0.4-1.debian.tar.gz
c2675dd9de4f40445eb99b810437fe273f6ad224a3e475408ced4a7aad09a71c 63162
libcupsfilters1_1.0.4-1_amd64.deb
318da78b4cb1a2fcbb4be30eea767788be99b9bbaf080bf803eb4e906b7000d4 373538
cups-filters_1.0.4-1_amd64.deb
fa1edaf2135b4fdfb1ad7ddd0b78b94988edbf895b646149778c58cf410474e1 74344
libcupsfilters-dev_1.0.4-1_amd64.deb
Files:
9542935e05c5c5ba4001097c4638379f 2495 net optional cups-filters_1.0.4-1.dsc
20f01880493882ecd97442d644a6c1bc 989868 net optional
cups-filters_1.0.4.orig.tar.gz
162a97d1a01eb52bd969cc5ee3a375af 36980 net optional
cups-filters_1.0.4-1.debian.tar.gz
ac75e421060e3bb8fdd9860cc9ba0340 63162 libs optional
libcupsfilters1_1.0.4-1_amd64.deb
60e237c756b50db8449074f19b2bec6a 373538 net optional
cups-filters_1.0.4-1_amd64.deb
4e0f0da07bb70d996d2e452541eda58d 74344 libdevel optional
libcupsfilters-dev_1.0.4-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJPV2UHAAoJEPmIJawmtHufIjsP/2keN9lMQS4uWY2fQVJjlJFc
uerh3myzcBRwC4cBNYs702Dc8gjRT9ETKHNgqg/UxQF2ckubZfYB7t1wBKJvPEa3
KVK0Tb/ECr+yRe5OQ+tJHg7yclNc93DzEjxZojuWJEEkmhiZTO/pahK34Xr6y/tR
fB8yCsXu6IKFU1YNPS9zAJBzuF2VyndW7B3u5AfcVf5l7Q+T0eK7K3T8RHwdfxpN
WJ6J+omIN5Z65PTtOZnPkaqgxFVT2WAhch5BGEE8O92s7+Jd+62KIa43Iy5oJgTs
0K/KPAophTUQY4TRxZxJF+YI4Iecsw6tjezwjqs+iUfViBssBSX3z32bqP/YL4RT
eLhPcQ75DdoP3kVjYHF8X5m6RiyTumWmwpDmOvXr6hgbprjl6DdDv0PBBi5aRFZU
/CvYiFeNGAXgmHd2dHsmQDt9z1KYm/FuHoJUiaKM2BNnwxTHZ8hzF18t+eqQ8DPX
2vbJCuTdKPNKtGtB4hR6xhWqI0rb2k8eXBkzAamLuQktceRj4iJ1+gPVPR4Nr6Jx
wJTB92jHggcPsOgI5++pUFtfKsrpb/s1EjOGJzXYupnOgdGtYE5T6C6rmQzPyKx0
0RrJRpPv2lMwdYatHC/TjtzHZBglTo7rFsoDhaC8x3f062P3wGr2HJMK0nA4ZRnX
Ru2z7EeVIvA0OQ9ARkN2
=6s1s
-----END PGP SIGNATURE-----
--- End Message ---
