Your message dated Thu, 05 Apr 2012 13:17:29 +0000
with message-id <[email protected]>
and subject line Bug#637173: fixed in inoticoming 0.2.3-1
has caused the Debian Bug report #637173,
regarding inoticoming: example init.d script requires LOGFILE
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
637173: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=637173
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: inoticoming
Version: 0.2.2-1
Severity: minor

The example init.d script is written to have LOGFILE be an optional element.

        if [ -n $LOGFILE ] ; then
                [ -f $LOGFILE ] || touch $LOGFILE
                chown $USER $LOGFILE
                OPTIONS="$OPTIONS --logfile $LOGFILE"
        fi

However that construct doesn't handle an empty LOGFILE due to
insufficient variable quoting.  The $LOGFILE disappears if it isn't
set.  That variable needs to be quoted for this construct to work as
intended.

-       if [ -n $LOGFILE ] ; then
+       if [ -n "$LOGFILE" ] ; then

Of course this is only an example and so this is only a minor issue.

Also as long as I am suggesting opening up the example init.d file,
log files in /var/log are generally group 'adm'.  It would be great if
that were continued.

-               chown $USER $LOGFILE
+               chown $USER:adm $LOGFILE

Also, as an aside at an even more minor level, there is some extra
whitespace in the script.  It would be super nice if that were cleaned
for the next upload too.

Thanks for maintaining inoticoming.
Bob



--- End Message ---
--- Begin Message ---
Source: inoticoming
Source-Version: 0.2.3-1

We believe that the bug you reported is fixed in the latest version of
inoticoming, which is due to be installed in the Debian FTP archive:

inoticoming_0.2.3-1.debian.tar.gz
  to main/i/inoticoming/inoticoming_0.2.3-1.debian.tar.gz
inoticoming_0.2.3-1.dsc
  to main/i/inoticoming/inoticoming_0.2.3-1.dsc
inoticoming_0.2.3-1_amd64.deb
  to main/i/inoticoming/inoticoming_0.2.3-1_amd64.deb
inoticoming_0.2.3.orig.tar.gz
  to main/i/inoticoming/inoticoming_0.2.3.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bernhard R. Link <[email protected]> (supplier of updated inoticoming package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 05 Apr 2012 14:01:03 +0200
Source: inoticoming
Binary: inoticoming
Architecture: source amd64
Version: 0.2.3-1
Distribution: unstable
Urgency: low
Maintainer: Bernhard R. Link <[email protected]>
Changed-By: Bernhard R. Link <[email protected]>
Description: 
 inoticoming - trigger actions when files hit an incoming directory
Closes: 637173
Changes: 
 inoticoming (0.2.3-1) unstable; urgency=low
 .
   * new maintenance release
   - improve init.d example (Closes: 637173)
   * change Standards-Version to 3.9.3, no changed needed
Checksums-Sha1: 
 8e46fac10d5503b4bba644f3e65201d8ebfdd21c 1878 inoticoming_0.2.3-1.dsc
 ab5d908ca86c665dd7c319fb991268b3a6177915 99795 inoticoming_0.2.3.orig.tar.gz
 939fc0d857e3c620598680d9538925471677bce8 3492 inoticoming_0.2.3-1.debian.tar.gz
 b9f68c34c585bad2178c8d168a484cdfcf2da472 16174 inoticoming_0.2.3-1_amd64.deb
Checksums-Sha256: 
 a256b8f2cce87c29fc81f505f61892d8bd66af759f6ea8d40127b8a8622f63b7 1878 
inoticoming_0.2.3-1.dsc
 b31ba7956bd98e7f9d6a8b81737570394f8a05e07b66670aca47711dd8c7ee68 99795 
inoticoming_0.2.3.orig.tar.gz
 d1b8f74fc1c2feca9dc374883b047fc97185f3d63893ba40ea5b8e4341071550 3492 
inoticoming_0.2.3-1.debian.tar.gz
 98533f2a888fff4b6f2bb125488e1bbba8fdf3eb8fed1460c5485f3104e8b33a 16174 
inoticoming_0.2.3-1_amd64.deb
Files: 
 26cacf6896279dbcca4a6450f1228e40 1878 utils extra inoticoming_0.2.3-1.dsc
 7dc8387773349db03a2c49e73e04bcd2 99795 utils extra 
inoticoming_0.2.3.orig.tar.gz
 94dd321d560f77afa3fe4077704a2e61 3492 utils extra 
inoticoming_0.2.3-1.debian.tar.gz
 960239fcb3e42176b611b79df5bebe1c 16174 utils extra 
inoticoming_0.2.3-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPfZnrAAoJEOxkTtbr1QJDk28QAJYnd2gCtvDW3ne3y8DXpVsv
3xe8xzj7TkmcxU03V3IVvPmA9p0OM6t5FfIOiZ0iYuAdVkhYZ53t/MU2aWkljYFb
fKg03RcguzNckGYHlfCiN5Ob5+yGUbSsTSTqKsIzZnmODtIc9kglXrBS+EFaXH6s
CPgIr1kTG2Sfav+GhwLogfKa8yp6WXHNXTlOSU8axrXTrJyreIBE4JXFCq5TqWKL
jyc47pAfbyamssyReBsFBuQ0BE0b3qmcCoMq4/p5on4lTODyXFPycjF7wxA9Q60s
ab99dseqTU3WCrwhodL7iQkXBoba3FDSfs0m++BVNVJGpSFi1j2esadP11fcb/Bj
KvXWQAQ2Xo6xAmznIeMMZMAPVILI6PF611fxMiXXG3eLFlZhrpRMC8SyqOXY3Lxf
kiUfOSIk/We9Xnd0oA/PgMPwr9CAr63vW0kya/Guws9BIKRka6ullIQkS/o4McnQ
TyurbZE6S1qAVDMTbB8NrNC/rhz+Xm16Un2xfm6lqCwj95PtLh9DGnGKKvnm55ax
80WhBZPkNoFaYS+aoHlpyuCf2xIHqXGwgInFBYrgit5IQyJPbifyt8dbOsPTAMnZ
KLgslbU4CzD6zcP0np/3P+bZCsgQf9RzfhaERJsyTHDrW9kjviyPrzgX47HWwnzl
g0+XDrvxc06BUEyUsO9/
=Co2B
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to