Your message dated Tue, 15 May 2012 16:32:13 +0000
with message-id <[email protected]>
and subject line Bug#654192: fixed in backupninja 1.0~rc1-1
has caused the Debian Bug report #654192,
regarding rsync backup using long format fails to rotate
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
654192: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654192
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: backupninja
Version: 0.9.8.1-1
Severity: normal

Hi!

I have configured backupninja to do a rsync (pull) backup for some host. 
However, after the first backup on day 1 (creating daily.1),
it only rotates once on day 2 (creating daily.2) and then backupninja stops
rotating and starts backuping over daily.1 repeatedly.

  Debug: skipping rotation of <backuproot>/target.rsync///daily.2 because it 
was created 0 days ago (1 needed).
  Debug: skipping rotation of <backuproot>/target.rsync///daily.1 because 
<backuproot>/target.rsync///daily.2 already exists.
  [..]
  Warning: <backuproot>/target.rsync///daily.1 already exists. Overwriting 
contents.

The fact is, that daily.2 was created not 0 but 2 days ago, according to
stat and also the contents of <backuproot>/metadata/daily.2/rotated.
Correct me if I am wrong, but I think the rsync handler incorrecly inspects
the metadata.  Consider line 402..410 of /usr/share/backupninja/rsync:

    for (( i=$oldest; i > 0; i-- )); do
      if [ -d $dir.$i ]; then
        if [ -f $metadata/created ]; then
          created=`tail -1 $metadata/created`
        elif [ -f $metadata/rotated ]; then
          created=`tail -1 $metadata/rotated`
        else
          created=0
        fi

In this loop, the handler tries to find out which archives should be rotated.
However, the metadata variable is always fixed (earlier) to
<backuproot>/metadata/daily.1.  IMO this makes no sense and probably should
be set to $backuproot/metadata/$dir.$i if it exists.

Kind regards,
Paul



--- End Message ---
--- Begin Message ---
Source: backupninja
Source-Version: 1.0~rc1-1

We believe that the bug you reported is fixed in the latest version of
backupninja, which is due to be installed in the Debian FTP archive:

backupninja_1.0~rc1-1.debian.tar.gz
  to main/b/backupninja/backupninja_1.0~rc1-1.debian.tar.gz
backupninja_1.0~rc1-1.dsc
  to main/b/backupninja/backupninja_1.0~rc1-1.dsc
backupninja_1.0~rc1-1_all.deb
  to main/b/backupninja/backupninja_1.0~rc1-1_all.deb
backupninja_1.0~rc1.orig.tar.gz
  to main/b/backupninja/backupninja_1.0~rc1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
intrigeri <[email protected]> (supplier of updated backupninja package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 15 May 2012 17:23:13 +0200
Source: backupninja
Binary: backupninja
Architecture: source all
Version: 1.0~rc1-1
Distribution: unstable
Urgency: low
Maintainer: Debian backupninja maintainers <[email protected]>
Changed-By: intrigeri <[email protected]>
Description: 
 backupninja - lightweight, extensible meta-backup system
Closes: 536858 654192 654708 656968 657201
Changes: 
 backupninja (1.0~rc1-1) unstable; urgency=low
 .
   * Imported Upstream version 1.0-rc1
     (Closes: #657201, #536858, #654192, #656968, #654708)
   * Drop obsolete pkglibdir-FTBFS-fix.diff: applied upstream.
   * Bump Standards-Version to 3.9.3 (no change required).
   * Suggest trickle package, now needed for duplicity traffic shaping.
   * Add NEWS entry for duplicity changes.
   * Revamp git-buildpackage configuration:
     - Update upstream-tag setting to reflect reality.
     - Use an upstream branch into which we can import upstream tarballs.
     - Use pristine-tar.
Checksums-Sha1: 
 095fa0a659cc13b43673ad3ddb9ae91abde02c39 2068 backupninja_1.0~rc1-1.dsc
 f8fc10c07adcabab127926be7cd994f9af98ad2e 172138 backupninja_1.0~rc1.orig.tar.gz
 33c7f6c71c577e238285fb82ae997447ed7581a1 13712 
backupninja_1.0~rc1-1.debian.tar.gz
 f814d743efbba5dfcece1639639869e31c49d4ec 106134 backupninja_1.0~rc1-1_all.deb
Checksums-Sha256: 
 2ec6960c1132dc18dda80a7b00c72eaec684b2520461aa08e50b1ee980585dc2 2068 
backupninja_1.0~rc1-1.dsc
 d5e3667cd3c459eb97561d43c8f5c3800093e953589ad963f3c74c92a1a8072f 172138 
backupninja_1.0~rc1.orig.tar.gz
 7d6ee9dabf1428837fc58abe77e5faae1ee7cc1da1904d35e26f9a6790c77b91 13712 
backupninja_1.0~rc1-1.debian.tar.gz
 9776bcb3be9dfa9b85b6c6de6d3657daf6af923f101754bde21688352bff0d8d 106134 
backupninja_1.0~rc1-1_all.deb
Files: 
 a7b0173f7a3278bbcc9c5b0fa625206f 2068 admin optional backupninja_1.0~rc1-1.dsc
 dcb340febf496d340d42c940efb19d78 172138 admin optional 
backupninja_1.0~rc1.orig.tar.gz
 350b5a68ad6cf2172b3ddb6b4a1bd0fd 13712 admin optional 
backupninja_1.0~rc1-1.debian.tar.gz
 6be870eb4f5c83e6ddcd490f03ee0de5 106134 admin optional 
backupninja_1.0~rc1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJPsoP2AAoJELrOFdKldJj/qDwP/0u9WOUhzmKTKS66SYd4O8Bd
lO1KSvCzKly/+riF/m/75IFTICB9Dnx4Yf93h1QNdPhZkfYCFys8ajM7vSiSVNvS
5YsMgeMhCQnO3C5RMDt0o/FcjeiZ8fj4d3x4Dznz+uQSkGkm7y80TIUhQx539PyT
ye1dP3MP2qAHJo2sUIYw5hZZ5caMVRxQC4anaRlwnqbUUBjmiomy79bBya82ZGPH
pQE1hZ/S5YCma2Fr9BBtRo+Tl6uix0prNgfpSWp4/FpwnHrCALPcKb7MspjyLmzy
bgAfcBmqSIdopwNROeNfQmrz2BM2wHOecodNmwZ4OzGeKVCV9hc8YaTO0ZWtBjZQ
wzb0WwJm+Z0d6g5a4cO9X36u2oeN3r93rfJjfCu6LHoymW7G2hzkmn0tcjK0FNtb
yas6OnhwKhuQourdg5umgSCNRGzlh+UH+FA5D22gq1Zg/D+qo0oirICi6K5uzm8d
uLYTxsRG/iR7LIR6+TH3dgLIJdGFBKNxhHIZ326UNHb679zcOQO0ApIlXIdS2ZlW
3uC6Qxdplf4j9FGVp0KqCXru1G8Qz/bqYBHvht+KBfeVOtbojVuJz9qaZD+WolFM
FSUKwsv1hxOPJl8cI9Hs8AqXr7s8pM5ZCN3f7Rn73JCV6efObM40jZtwDmIzl+Zp
+y/Yyd6b+NRH/ZJnMj8F
=uB9d
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to