Your message dated Sat, 09 Jun 2012 09:42:04 +0000
with message-id <[email protected]>
and subject line Bug#676720: fixed in rstatd 4.0.1-6
has caused the Debian Bug report #676720,
regarding rstatd: does not work with kernel 3.x kernel (updated patch for
unstable)
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
676720: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=676720
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rstatd
Version: 4.0.1-5
Severity: minor
Tags: patch
Hi Anibal. The following discussion refers to #654276[1]. The fix
there introduced another case explicitly for 3.x kernels. During
asking for a stable-update for rstatd Julien from Release Team noticed
that it would be better to use get_*26 calls as default fallback as
2.6 and 3.x kernels use the same interface. See [2] for my initial
request.
[1]: http://bugs.debian.org/654276
[2]: https://lists.debian.org/debian-release/2012/06/msg00142.html
On Wed, Jun 06, 2012 at 10:12:46PM +0200, Julien Cristau wrote:
> On Wed, Jun 6, 2012 at 21:25:37 +0200, Salvatore Bonaccorso wrote:
>
> > Agreed, and thanks for feedback. Indeed the fix was simply taken from
> > the version in unstable, which maybe should change that too.
> >
> Yes, that would be better.
>
> > Attached is the new debdiff for it.
> >
> Looks good to me, thanks.
Attached is now the same against 4.0.1-5 in unstable (note the pach
folliwing it needs a refresh for the offset).
Regards,
Salvatore
From 937673cb800b777965ad8841100771ab088e5dc5 Mon Sep 17 00:00:00 2001
From: Salvatore Bonaccorso <[email protected]>
Date: Sat, 9 Jun 2012 08:11:29 +0200
Subject: [PATCH] Defaults to get_*26 for kernel version >= 2.6
Defaults to get_*26 for kernel version >= 2.6 instead of introducing a
new if for 3.x kernels.
See: https://lists.debian.org/debian-release/2012/06/msg00152.html
---
debian/patches/02-654276-get_disk26.patch | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/debian/patches/02-654276-get_disk26.patch b/debian/patches/02-654276-get_disk26.patch
index b478b22..1914641 100644
--- a/debian/patches/02-654276-get_disk26.patch
+++ b/debian/patches/02-654276-get_disk26.patch
@@ -20,11 +20,12 @@ same interface is used for getting the disks statistics.
--- a/getdata.c 2012-01-08 12:26:19.000000000 +1100
+++ b/getdata.c 2012-01-08 12:31:12.000000000 +1100
-@@ -289,6 +289,10 @@ void getdata_setup() {
+@@ -289,6 +289,11 @@
getdata.disk = get_disk26;
getdata.vm = get_vm26;
}
-+ if (0 == strncmp(u.release, "3", 1)) {
++ /* defaults to get_*26 for kernel version >= 2.6 */
++ else {
+ getdata.disk = get_disk26;
+ getdata.vm = get_vm26;
+ }
--
1.7.10
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: rstatd
Source-Version: 4.0.1-6
We believe that the bug you reported is fixed in the latest version of
rstatd, which is due to be installed in the Debian FTP archive:
rstat-client_4.0.1-6_mipsel.deb
to main/r/rstatd/rstat-client_4.0.1-6_mipsel.deb
rstatd_4.0.1-6.debian.tar.bz2
to main/r/rstatd/rstatd_4.0.1-6.debian.tar.bz2
rstatd_4.0.1-6.dsc
to main/r/rstatd/rstatd_4.0.1-6.dsc
rstatd_4.0.1-6_mipsel.deb
to main/r/rstatd/rstatd_4.0.1-6_mipsel.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <[email protected]> (supplier of updated rstatd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 09 Jun 2012 18:12:10 +1000
Source: rstatd
Binary: rstatd rstat-client
Architecture: source mipsel
Version: 4.0.1-6
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <[email protected]>
Changed-By: Anibal Monsalve Salazar <[email protected]>
Description:
rstat-client - client for rstatd
rstatd - displays uptime information for remote machines
Closes: 676720
Changes:
rstatd (4.0.1-6) unstable; urgency=low
.
* Standards version is 3.9.3
* DH compatibility level is 9
* Defaults to get_*26 for kernel version >= 2.6
Patch by Salvatore Bonaccorso
Closes: #676720
Checksums-Sha1:
0213d6792caf191260a393f2a8cdd4e0afbb753b 1739 rstatd_4.0.1-6.dsc
a378894f63dccecd70e09558086c365c1231702e 9736 rstatd_4.0.1-6.debian.tar.bz2
5be0b9d28b7c8e4e8bb07787c8e9f76575159f35 18098 rstatd_4.0.1-6_mipsel.deb
0589192207b4b493a73259070f6394a066b12ce3 17098 rstat-client_4.0.1-6_mipsel.deb
Checksums-Sha256:
d4aba945c72f1af0dc48a9adaec3e41c6b8a13f16f47eeefea3278f11d3625f1 1739
rstatd_4.0.1-6.dsc
a614d59f154d25324d7e2db26d89030fa4542d3dece69115abee4242b7dc781f 9736
rstatd_4.0.1-6.debian.tar.bz2
4b4cf9646eeac36624fe86c977c9cc0f60148fcfc96293bba0e778b090fd28df 18098
rstatd_4.0.1-6_mipsel.deb
a7cc7fe5d771040b92deb257fb1c265ba905a64cda653a8336d6bc22ef5360a0 17098
rstat-client_4.0.1-6_mipsel.deb
Files:
bb8184d912796eaa17a4ec24658c368d 1739 net optional rstatd_4.0.1-6.dsc
3edd8e3fcce5480f99ce48b128a764ba 9736 net optional
rstatd_4.0.1-6.debian.tar.bz2
e0f764daf3a6780d79e81a3684ef1f8b 18098 net optional rstatd_4.0.1-6_mipsel.deb
9fa2f7ea9ad4e89d8fe5a8b48dd38de9 17098 net optional
rstat-client_4.0.1-6_mipsel.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJP0w/6AAoJEHxWrP6UeJfYw4IP/1Btc4WPUDnPhnPbWqhCl6hp
Zn4pob+vpvXCWshpTmPiOyFTtKQp+Y1CtbltGAarNyhI3t9Dk0EFS5Sxq7hv87/8
v6kzs85G5jJ3GyOW9NftBqXk7O41UvLo75Vv+Z3EywbNwaXdGnxdikW9dpKRfrzr
n93WEhk2vHGYPciWEZoIN6UJyaLEQ47CLqwDD3aDaCb39kIeMW3vVMIG9xVuCmFz
5SZPfRu3ayB99zwVHzdQRIw8VCFYgGLpOEk6l89V1sp0Z29LqwwocwCIbObXfNUs
+etw2J2MhvyhddhoYTAFxNXt7SO5Htk2pesixc1iX/NF0V7nO4hDVlNtN5d7mUKr
MVa4uPG5pgYzzYmQF3dxS1TV15T6dOWZJkN58AwitFjs0vC13VX36409h2zvuA03
XLwJoZa06FJ5IAYLdLiuakCWBVSJ3HqVY443+JsfKcACbyFj2MfYsBJfQOiPSTLK
8SFY6Pho1O4J8Q6D6z44r/+1ovyXqOwhyObZTe0JEQZvziBMVOJreRgHnlesdPvJ
tqJ+yUcDKFjS0HiojOEeS0m24azQ7UwAs5HONvUIkJdcxPTTdNpm/GdjiS+c/tUn
CIBVDOxhzmilW7PZWOTlGfhlOEaj+7x2GgsrHG+wvE8Z3ReyXumgqAmeGhVE3KBx
knt6k2dO25mNLoD6eXDu
=QU0s
-----END PGP SIGNATURE-----
--- End Message ---
