Your message dated Thu, 14 Jun 2012 18:33:32 +0000
with message-id <[email protected]>
and subject line Bug#677149: fixed in qpdfview 0.3~beta3-1
has caused the Debian Bug report #677149,
regarding qpdfview FTBFS on armel and armhf qreal vs double issues
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
677149: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677149
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
package: qpdfview
severity: important
version: 0.3~beta2-1
tags: patch
Your package failed to build on armel and armhf
sources/documentview.cpp: In member function ‘void
DocumentView::preparePages()’:
sources/documentview.cpp:2121:40: error: no matching function for call to
‘qMax(qreal&, double)’
sources/documentview.cpp:2121:40: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1116:17: note: template<class T> const T& qMax(const
T&, const T&)
sources/documentview.cpp:2122:40: error: no matching function for call to
‘qMin(qreal&, double)’
sources/documentview.cpp:2122:40: note: candidate is:
/usr/include/qt4/QtCore/qglobal.h:1114:17: note: template<class T> const T& qMin(const
T&, const T&)
make[1]: *** [documentview.o] Error 1
On most architectures qreal is defined as double but on arm architectures
it is defined as float. Assignments between qreal and double are ok because
assignments between float and double are ok but there can be issues with
pointers, templates and overloaded functions if proper distinctions are not
made. In this particular case the issue is a template.
The fix is a simple case of adding some typecasts a similar issue in
main.cpp is fixed in the same way.
patch is attached.
Description: Fix qreal VS double
Fix two qreal vs double issues that were preventing build on armel/armhf
One invlolving a template the other involving pointers.
Author: Peter Michael Green <[email protected]>
Bug-Debian: http://bugs.debian.org/?????
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- scribus-1.4.0.dfsg+r17287.orig/scribus/pageitem_textframe.cpp
+++ scribus-1.4.0.dfsg+r17287/scribus/pageitem_textframe.cpp
@@ -554,7 +554,7 @@ struct LineControl {
double maxX = colRight - morespace;
if (legacy) maxX -= lineCorr;
- double StartX = floor(qMax(line.x, qMin(maxX,breakXPos-maxShrink-1))-1);
+ double StartX = floor(qMax((double)line.x, qMin(maxX,breakXPos-maxShrink-1))-1);
int xPos = static_cast<int>(ceil(maxX));
QPoint pt12 (xPos, yAsc);
--- scribus-1.4.0.dfsg+r17287.orig/scribus/scribusview.cpp
+++ scribus-1.4.0.dfsg+r17287/scribus/scribusview.cpp
@@ -1711,7 +1711,7 @@ bool ScribusView::slotSetCurs(int x, int
FPoint point(pf.x() - currItem->xPos(), pf.y() - currItem->yPos());
if (transform.isInvertible() && currItem->itemText.length() > 0)
{
- double tx = 0, ty = 0;
+ qreal tx = 0, ty = 0;
transform.inverted().map(pf.x(), pf.y(), &tx, &ty);
point.setXY(tx, ty);
}
--- End Message ---
--- Begin Message ---
Source: qpdfview
Source-Version: 0.3~beta3-1
We believe that the bug you reported is fixed in the latest version of
qpdfview, which is due to be installed in the Debian FTP archive:
qpdfview_0.3~beta3-1.debian.tar.gz
to main/q/qpdfview/qpdfview_0.3~beta3-1.debian.tar.gz
qpdfview_0.3~beta3-1.dsc
to main/q/qpdfview/qpdfview_0.3~beta3-1.dsc
qpdfview_0.3~beta3-1_kfreebsd-amd64.deb
to main/q/qpdfview/qpdfview_0.3~beta3-1_kfreebsd-amd64.deb
qpdfview_0.3~beta3.orig.tar.gz
to main/q/qpdfview/qpdfview_0.3~beta3.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Benjamin Eltzner <[email protected]> (supplier of updated qpdfview package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 12 Jun 2012 21:23:41 +0100
Source: qpdfview
Binary: qpdfview
Architecture: source kfreebsd-amd64
Version: 0.3~beta3-1
Distribution: unstable
Urgency: low
Maintainer: Benjamin Eltzner <[email protected]>
Changed-By: Benjamin Eltzner <[email protected]>
Description:
qpdfview - tabbed PDF viewer
Closes: 677149 677152
Changes:
qpdfview (0.3~beta3-1) unstable; urgency=low
.
* Fixed a bug that occured on armel and armhf. (Closes: #677149)
Thanks to Peter Green <[email protected]>
.
* Added build-dependency. (Closes: #677152)
Thanks to Pino Toscano <[email protected]>
Checksums-Sha1:
d05b9619c799baee68eaba8d4a6102658914f5b3 1445 qpdfview_0.3~beta3-1.dsc
2d872659ed652baeceeb7cd2234296832375ac50 59601 qpdfview_0.3~beta3.orig.tar.gz
f8fb2f0499c8b64f3ca58264e27f86954a4484e2 1602
qpdfview_0.3~beta3-1.debian.tar.gz
8d2f0e7cba1ae04733054009e68f7c30300b3e3a 161528
qpdfview_0.3~beta3-1_kfreebsd-amd64.deb
Checksums-Sha256:
fbbbb363c73d0a310977bd51c66475fb5ee3f4dbeb5bf587148f2c85a8c8f54e 1445
qpdfview_0.3~beta3-1.dsc
e68c3dc83dcc2a1193cc6c014decda539a00a83e5c1a74c80e2464d5a29117ec 59601
qpdfview_0.3~beta3.orig.tar.gz
4d9f2393139d7cd71432fbd214697505c5b5d9d5f3fc17e27a28ae72789d75ed 1602
qpdfview_0.3~beta3-1.debian.tar.gz
78dc2439cfd99453ffe88dbfe71dce29ed98d1bdf219c8cb1ce6da5022c6048d 161528
qpdfview_0.3~beta3-1_kfreebsd-amd64.deb
Files:
3bf1447c7bc7c26608df11c3087a4996 1445 graphics optional
qpdfview_0.3~beta3-1.dsc
7167ca4a594a7e5931839907c919966c 59601 graphics optional
qpdfview_0.3~beta3.orig.tar.gz
513474d3b2317295c48c0ba4ce7bfddc 1602 graphics optional
qpdfview_0.3~beta3-1.debian.tar.gz
32891f8001f5c057c972f85b00b0130f 161528 graphics optional
qpdfview_0.3~beta3-1_kfreebsd-amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQEcBAEBAgAGBQJP2iy9AAoJEIAhAkTu07wNh8gH/iivlXh3ENkUWJM3teREJpjv
FAdKX/F2J6mT8F4dxC0hC42E0WOyG0OEJ0vX0x2fHdb0ZpiU5jAGSQ0mgRk9V/kc
+GIkkjjjIS9pAXb0oI2ztmB1U+JyrIBRayA3bDWlFnTRSRDAs5xrFzO+XxkFkNCJ
X57ZO0Trv1APt3zBxflXnODUMZNopQOLlFvoP75wCpDrH1wSu//Rc4CA2YLxXVdw
xBzm5IKggack8CzYQjBAiGtl/eMuCQpC4kJ5VfPRMxGvI3uaauCBZaV3nH6RsaMM
Z3khyrVgAoC3eZgcujAmB5RgxVvUO9u2RTH6h+2ulT6BoYY5JN1nqkIDSJdKx2g=
=btUa
-----END PGP SIGNATURE-----
--- End Message ---
