Your message dated Sun, 24 Jun 2012 02:48:21 +0000
with message-id <[email protected]>
and subject line Bug#585560: fixed in dvdbackup 0.4.2-1
has caused the Debian Bug report #585560,
regarding dvdbackup someties lies about which vob file had read errors
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
585560: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585560
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dvdbackup
Version: 0.4.1-1
Severity: important
Tags: patch
Hi,
when dvdbackup encounters read errors while copying vob files, it prints a
message to stderr mentioning the file name of the affected vob. However,
this file name is wrong for all except the first vob in a title set.
I noticed this because I copied the same disk using dvdbackup -M and also
using cp -r (the dvd is not css encrypted) to compare results, and both told
me they had one vob file affected by read errors, but not the same one.
After that, I copied the same disk using a different drive on a different
machine, which went through without read errors because this drive is
better/newer, and I compared all three results using md5sum. It became
evident that the vob file for which dvdbackup told it had read errors was
intact, because it was identical in all three cases, and that in reality
the vob file for which cp told it had read errors was affected, because all
three versions where different.
This happens because dvdbackup.c:DVDCopyTitleVobX reads the source dvd using
an abstract api using only title ids and no file names, and therefore needs
to reconstruct a file name when printing error messages. It includes the
correct title set id in the fake file name, but sets the vob number always
to zero, which is only correct for the first vob in a title set.
DVDCopyTitleVobX already has the correct vob number and uses it to construct
the the correct target vob file name, and therefore its trivial to use the
same number to create a correct file name for the error message.
My attached patch does exactly this.
Greetings,
Kolja Nowak.
-- System Information:
Debian Release: 5.0.4
APT prefers stable
APT policy: (990, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.30-bpo.2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages dvdbackup depends on:
ii libc6 2.7-18lenny4 GNU C Library: Shared libraries
ii libdvdread4 4.1.3-9 library for reading DVDs
dvdbackup recommends no packages.
Versions of packages dvdbackup suggests:
ii libdvdcss2 1.2.10-0.2 Simple foundation for reading DVDs
-- no debconf information
diff -Naur dvdbackup-0.4.1/src/dvdbackup.c dvdbackup-0.4.1_patch/src/dvdbackup.c
--- dvdbackup-0.4.1/src/dvdbackup.c 2009-06-09 00:25:29.000000000 +0200
+++ dvdbackup-0.4.1_patch/src/dvdbackup.c 2010-06-11 18:23:13.224031430 +0200
@@ -912,9 +912,9 @@
/* Return value */
int result;
- /* create filename VIDEO_TS.VOB or VTS_XX_0.VOB */
+ /* create filename VIDEO_TS.VOB or VTS_XX_X.VOB */
if(title_set > 0) {
- sprintf(filename, "VTS_%02i_0.VOB", title_set);
+ sprintf(filename, "VTS_%02i_%d.VOB", title_set, vob);
}
if (title_set_info->number_of_title_sets + 1 < title_set) {
--- End Message ---
--- Begin Message ---
Source: dvdbackup
Source-Version: 0.4.2-1
We believe that the bug you reported is fixed in the latest version of
dvdbackup, which is due to be installed in the Debian FTP archive:
dvdbackup-dbg_0.4.2-1_amd64.deb
to main/d/dvdbackup/dvdbackup-dbg_0.4.2-1_amd64.deb
dvdbackup_0.4.2-1.debian.tar.gz
to main/d/dvdbackup/dvdbackup_0.4.2-1.debian.tar.gz
dvdbackup_0.4.2-1.dsc
to main/d/dvdbackup/dvdbackup_0.4.2-1.dsc
dvdbackup_0.4.2-1_amd64.deb
to main/d/dvdbackup/dvdbackup_0.4.2-1_amd64.deb
dvdbackup_0.4.2.orig.tar.xz
to main/d/dvdbackup/dvdbackup_0.4.2.orig.tar.xz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Benjamin Drung <[email protected]> (supplier of updated dvdbackup package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 24 Jun 2012 04:26:40 +0200
Source: dvdbackup
Binary: dvdbackup dvdbackup-dbg
Architecture: source amd64
Version: 0.4.2-1
Distribution: unstable
Urgency: low
Maintainer: Stephen Gran <[email protected]>
Changed-By: Benjamin Drung <[email protected]>
Description:
dvdbackup - tool to rip DVD's from the command line
dvdbackup-dbg - debug files for dvdbackup
Closes: 585560
Changes:
dvdbackup (0.4.2-1) unstable; urgency=low
.
* New upstream release.
- Print the correct vob file name in which the read error happens.
Thanks to Kolja Nowak for the patch. (Closes: #585560, LP: #648752)
* Update my email address.
* Move from Subversion to Git.
* Switch to dpkg-source 3.0 (quilt) format.
* Bump Standards-Version to 3.9.3 (no changes needed).
* Switch from cdbs to dh 9.
* Update machine-readable copyright file to version 1.0 of the specification.
Checksums-Sha1:
14f0a7e849669680c181a187b254d065e0f74f62 1969 dvdbackup_0.4.2-1.dsc
cf10f2e2d1d8df23ecda96e867b9a39ce6b6f884 178660 dvdbackup_0.4.2.orig.tar.xz
f34e4d6c9b46397cb8cee3eac1c9990577d0b114 4785 dvdbackup_0.4.2-1.debian.tar.gz
fae0eeb6cea8cc19462df374b299dda5ea484110 54220 dvdbackup_0.4.2-1_amd64.deb
60e44daab366742114313c62dcd1559da7f0974d 43544 dvdbackup-dbg_0.4.2-1_amd64.deb
Checksums-Sha256:
6e23220e38191f47f72edc9cbe2c7be063cec5689b9a5db70cf3e940f8b11340 1969
dvdbackup_0.4.2-1.dsc
ef8c56fbb82b15b7eef00d2d3118c8253f9770009ed7bb2a5d4849acf88183e6 178660
dvdbackup_0.4.2.orig.tar.xz
5f44f72deead05dfe95f0318daa00285f2fa2b31ba735b9668d2292adc2ac0e8 4785
dvdbackup_0.4.2-1.debian.tar.gz
a6949e14ef5936aa66f8f5e2a8090c4d6538f6e16401715d2acf98522f33bdac 54220
dvdbackup_0.4.2-1_amd64.deb
eb6ca2eac8bcea4a833e365b44a788e6b53692f3d1fa216ebc856c1a9330d961 43544
dvdbackup-dbg_0.4.2-1_amd64.deb
Files:
5e686a7c48d8e13f09c8d16761f995ab 1969 video optional dvdbackup_0.4.2-1.dsc
28f273b2f27a3afea3a3c965ddbede86 178660 video optional
dvdbackup_0.4.2.orig.tar.xz
940dc26d7617dcc05867df1b1e6e3155 4785 video optional
dvdbackup_0.4.2-1.debian.tar.gz
91619388398db708bc5f5eb538e77db1 54220 video optional
dvdbackup_0.4.2-1_amd64.deb
70a569a7c1ff1029445a13ab6a702906 43544 debug extra
dvdbackup-dbg_0.4.2-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCgAGBQJP5n0WAAoJEBWetcTvyHdMmHcP/0CO7SmY6ZDxHmRRM1Dk6IA4
q9Is/ykqUlzd4UZpl7X8Ezl73a0fc0vS/YH2sq7piLOHGglH7HoFn7dp3FI5RS33
L+ZkUoDpzdcBfdNZPYEuMss8tNvKy0Esm751D+m88xQo8qnZhKTCZxtlk30o2m8z
JPTO9vdpQWkLntseaJYkO0ez28ZP8avkfc8S1FkKonOkaiuLrj7EgVpaNqAdv/qS
RbRn2pvGe/AZk07qvUoADLd3SH2DTBCFRcDAGAtELpxjWh7h2uz5RxHFfPkHZU0/
CNWQ1DJLfaqv6RcLJunTZNsVqoOjFeBosjLsoUSxhYaaL0y4nDB1GlSPqnWSLrg7
Jaemo8S1XdDV5cFUUP5GtSiENJ98u0E2PxQHsTlBtGByfyNe40ifRnFJPveX4xSS
XkQErc0rvCzmuXw4NUPWmqiwDOwujXZy4Q/t/vCf5S+vJLq85LI/yllyplZ32Eac
pwxk1dT01K5nT0mXdIEWudn24va2XlLtb8zvh18juOFRSHqf/m710RpfsMDF1HSi
M6BkoT8s9ajTHWxJOM6cdOB7QUhQ+DJEv/uMqA65WAGL8OhoUHv9Huvg4cEG6NJA
6MHfIhP/QL0dkB0RlulY4XlNRtBCKDdO/PYtancaMpp1LRG3irYktdxbDIEZO3+v
bj6YCgjnB4pQU6ibcNT5
=LbGV
-----END PGP SIGNATURE-----
--- End Message ---
