Your message dated Mon, 02 Jul 2012 23:17:10 +0000
with message-id <[email protected]>
and subject line Bug#479389: fixed in chrony 1.26-2
has caused the Debian Bug report #479389,
regarding chrony: Improvements for debian/rules
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
479389: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=479389
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: chrony
Version: 1.23-3
Severity: minor
Tags: patch
There are a number of little issues with chrony's debian/rules:
- It does not allow to build in unoptimized using
DEB_BUILD_OPTIONS=noopt
- there are no build-arch and build-indep targets (those are optional
but the more packages having them, the faster buildds might be able
to not waste space on indep stuff).
- there are a lot of confusing comments (like sayint to put stuff
in debian/tmp and then putting it in debian/chrony)
- setting prefix to '' is quite confusing. This way one thinks there
might be a reason it is not done the canonical way which I could not
find.
- it ignores make distclean errors
- is there a reason it does this faqen.pl in binary-indep hack?
It seems to be only perl and running fast.
- you tell it to create chrony.html and chrony.info via make doc
anyway. why not just remove them so the .diff gets cleaner?
Same for getdate.c
- dh_installmanpages is deprecated, and not used anyway in this
package
Hochachtungsvoll,
Bernhard R. Link
Index: chrony-1.23/debian/rules
===================================================================
--- chrony-1.23.orig/debian/rules 2008-05-04 17:08:43.000000000 +0200
+++ chrony-1.23/debian/rules 2008-05-04 17:14:30.000000000 +0200
@@ -6,13 +6,22 @@
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+CFLAGS = -Wall -g
+ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
+ CFLAGS += -O0
+else
+ CFLAGS += -O2
+endif
+
build: build-stamp
+build-arch: build-stamp
+build-indep:
+
build-stamp:
dh_testdir
- ./configure --prefix=''
- # Add here commands to compile the package.
- $(MAKE)
+ CFLAGS="$(CFLAGS)" ./configure --prefix=/usr --mandir=/usr/share/man
+ $(MAKE)
$(MAKE) docs
touch build-stamp
@@ -21,9 +30,8 @@
dh_testdir
dh_testroot
rm -f build-stamp install-stamp debian/substvars
-
- # Add here commands to clean up after the build process.
- -$(MAKE) distclean
+ rm -f faq.html chrony.html chrony.info getdate.c
+ if [ -e Makefile ] ; then $(MAKE) distclean ; fi
dh_clean
@@ -34,17 +42,16 @@
dh_clean -k
dh_installdirs
- # Add here commands to install the package into debian/tmp.
- $(MAKE) install DESTDIR=`pwd`/debian/chrony/usr MANDIR=/share/man
+ $(MAKE) install DESTDIR=$(CURDIR)/debian/chrony
+ chmod 755 faqgen.pl
+ ./faqgen.pl < faq.txt > faq.html
touch install-stamp
-# Build architecture-independent files here.
-binary-indep: build install
- chmod 755 faqgen.pl
- ./faqgen.pl < faq.txt > faq.html
+# Build architecture-independent files:
+binary-indep:
-# Build architecture-dependent files here.
+# Build architecture-dependent files:
binary-arch: build install
dh_testdir
dh_testroot
@@ -53,16 +60,10 @@
dh_installmenu -n
dh_installinit -n
dh_installcron
- dh_installmanpages
- dh_installchangelogs
+ dh_installchangelogs
cp chrony.conf debian/chrony/usr/share/chrony
cp debian/chrony.conf.md5sum debian/chrony/usr/share/chrony
-# cp chrony.keys debian/chrony/etc/chrony
cp chrony.info debian/chrony/usr/share/info
-# cp chrony.info-1 debian/chrony/usr/share/info
-# cp chrony.info-2 debian/chrony/usr/share/info
-# cp chrony.info-3 debian/chrony/usr/share/info
-# cp chrony.info-4 debian/chrony/usr/share/info
cp debian/ip-up debian/chrony/etc/ppp/ip-up.d/chrony
cp debian/ip-down debian/chrony/etc/ppp/ip-down.d/chrony
cp debian/apm debian/chrony/etc/apm/event.d/01chrony
@@ -70,7 +71,6 @@
dh_strip
dh_compress
dh_fixperms
-# chmod 640 debian/chrony/etc/chrony/chrony.keys
chmod 755 debian/chrony/etc/ppp/ip-up.d/chrony debian/chrony/etc/ppp/ip-down.d/chrony
dh_installdeb
dh_shlibdeps
@@ -78,8 +78,8 @@
dh_md5sums
dh_builddeb
-source diff:
+source diff:
@echo >&2 'source and diff are obsolete - use dpkg-source -b'; false
binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary
+.PHONY: build build-arch build-indep clean binary-indep binary-arch binary
--- End Message ---
--- Begin Message ---
Source: chrony
Source-Version: 1.26-2
We believe that the bug you reported is fixed in the latest version of
chrony, which is due to be installed in the Debian FTP archive:
chrony_1.26-2.diff.gz
to main/c/chrony/chrony_1.26-2.diff.gz
chrony_1.26-2.dsc
to main/c/chrony/chrony_1.26-2.dsc
chrony_1.26-2_amd64.deb
to main/c/chrony/chrony_1.26-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
John G. Hasler <[email protected]> (supplier of updated chrony package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 01 Jul 2012 22:05:56 -0500
Source: chrony
Binary: chrony
Architecture: source amd64
Version: 1.26-2
Distribution: unstable
Urgency: low
Maintainer: John G. Hasler <[email protected]>
Changed-By: John G. Hasler <[email protected]>
Description:
chrony - Sets your computer's clock from time servers on the Net
Closes: 195620 294030 407466 479389 518385 655123
Changes:
chrony (1.26-2) unstable; urgency=low
.
* Fixed Makefile.in so that getdate.c gets made (and removed
in "clean"). This will go upstream. Moved faq stuff in rules
from binary-indep to binary-arch.
* Restored accidently deleted nmu changelog entry.
.
* Applied patch from Moritz Muehlenhoff <[email protected]>
Closes: #655123 Please enabled hardened build flags
.
* Fixed upstream.
Closes: #518385 Chrony segfaults on startup (narrowed down to
chronyc and "burst")
.
* Added DEB_BUILD_OPTIONS=noopt to rules.
Added build-arch and build-indep to rules.
Prefix is now 'usr'.
Changed to dh_installman.
Fixed "clean:" target.
Closes: #479389 Improvements for debian/rules
.
* Fixed upstream.
Closes: #195620 Strange "System time : xxx seconds slow of NTP time"
output
.
* Upstream changes should have fixed this.
Closes:#294030 chronyd makes the whole system briefly (< 1 second)
freeze
.
* Fixed by upstream changes and new LSB headers.
Closes: #407466 Chrony won't access hardware clock but prevents
hwclock from doing so either
Checksums-Sha1:
562533aa4681792df3d056a6fe9cddf5cab0b369 1707 chrony_1.26-2.dsc
c13adbba2a6c263784daec988a50a5cafa508928 17977 chrony_1.26-2.diff.gz
21b32ab2bc52fada70b151fc74ef5b047dea32a7 392806 chrony_1.26-2_amd64.deb
Checksums-Sha256:
ce05219edb4b3c47831a1b99c37fe75db4166ac97608ba0bfd7efec59defb3a2 1707
chrony_1.26-2.dsc
c3c5977aec0372207d5840786f674eca428b73fde319baf893ca7d57ab03c9d3 17977
chrony_1.26-2.diff.gz
b00dab5f9b9647dc265455fee5fc9b55a43d6d0da4a3ee3aba5e5948c8dcf69a 392806
chrony_1.26-2_amd64.deb
Files:
d655f75bbc9e80ec51bedc0ad963666d 1707 admin extra chrony_1.26-2.dsc
b62ae11179aa5dd0e4d6c725b785d45c 17977 admin extra chrony_1.26-2.diff.gz
9e86a58095ffc45ae4a747ddac36f3a6 392806 admin extra chrony_1.26-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJP8gyIAAoJEHNAHjW0+9qlXXUQAI5dFz0ykaGj3Ql1lndcPrit
XIrmqtK8oi+GIUJi7ubRh/Q7IPuDeuOX7oaZzXWxBQLWmKm4I9AMYAkK88UfjcpT
qkxrSdrvtuQ6zA+9j4zml1FBwFNJHvgfRhahwoSeHowyoSmKHS+CBC05hzL0C6yu
gr8s/8cp3DERZp5KLKruX9Kj8+Ybi6fkpqltI4lfa12mQOnicy680eiVYLN8C596
gwmXla1+1u9UT4UrcX//4aNb16y6kytp4l4Pb67ruwBYUEe+Xl1P0tZzmJCUixjo
CrKTTfeAyVLMH0G3f/Enco57CEm/21p56si+PUxo2K1y/HXlEv286Xmhnpl5hewz
U4DatFg3N4Gx859Fxjn87LwKWt2VVD7tQiER7+kg/0uwwAbvM3w+7t7qW/B0UFB2
mRPSORQWqDIi4j8A2BmncYNJclatruCLEkqnAFF8giGxPOxBEY0+8CKWuPmFq5Vi
a+LKbMDW/ZGtk4ljNGg/zZaWqSAJikNvfLfg84vYg04TvmABM/X66TwHM53cetfb
bEQPjbrnGywIKDvjVeGIMn+eiGnLc2bNojGOwP8bsPb5iNoDFc6J4uib3A1qM7Qr
zFvIhfcu11g+MIlAQSjYc/WM/3nJKK/vOEZS9QKj1tQwg8py0oMF+9O/0AC53ZFO
8U/HgXzQ/+rGiBAlDA9y
=r9x+
-----END PGP SIGNATURE-----
--- End Message ---
