Your message dated Sat, 14 Jul 2012 08:48:00 +0000
with message-id <[email protected]>
and subject line Bug#681253: fixed in sshfp 1.2.2-3
has caused the Debian Bug report #681253,
regarding sshfp dies on every invocation with "NameError: global name
'hostname' is not defined"
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
681253: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=681253
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: sshfp
Version: 1.2.2-2
Severity: important
Dear Maintainer,
In our environment, sshfp dies on every invocation with
--------------------
Traceback (most recent call last):
File "/usr/bin/sshfp", line 378, in <module>
main()
File "/usr/bin/sshfp", line 363, in main
data = sshfp_from_file(khfile, args)
File "/usr/bin/sshfp", line 129, in sshfp_from_file
fingerprints.append(process_records(data, wantedHosts))
File "/usr/bin/sshfp", line 171, in process_records
if not check_keytype(keytype):
File "/usr/bin/sshfp", line 138, in check_keytype
print >> sys.stderr, "Could only find key type %s for %s" % (keytype,
hostname)
NameError: global name 'hostname' is not defined
--------------------
This is caused by a reference to the 'hostname' variable in def check_keytype
on line 138, at which point that variable is not defined.
The fix is trivial, here is a patch:
--------------------
--- /usr/bin/sshfp.orig 2011-11-15 14:45:22.000000000 -0500
+++ /usr/bin/sshfp 2012-07-11 13:48:01.075725852 -0400
@@ -129,7 +129,7 @@
fingerprints.append(process_records(data, wantedHosts))
return "\n".join(fingerprints)
-def check_keytype(keytype):
+def check_keytype(keytype, hostname):
global algos
for algo in algos:
if "ssh-%s" % algo[:-1] == keytype[:-1]:
@@ -141,7 +141,7 @@
def process_record(record, hostname):
(host, keytype, key) = record.split(" ")
key = key.rstrip()
- if check_keytype(keytype):
+ if check_keytype(keytype, hostname):
record = create_sshfp(hostname, keytype, key)
return record
return ""
@@ -168,7 +168,7 @@
if "," in host:
host = host.split(",")[0]
if all_hosts or host in hostnames or host == hostnames:
- if not check_keytype(keytype):
+ if not check_keytype(keytype, host):
continue
all_records.append(create_sshfp(host, keytype, key))
if all_records:
--------------------
Could you please apply it to the sshfp package?
Thanks,
Ward.
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages sshfp depends on:
ii openssh-client 1:5.9p1-5
ii python 2.7.2-10
ii python-dnspython 1.10.0-1
ii python-ipcalc 0.3-1
ii python-ldns 1.6.13-1
ii python2.7 [python-argparse] 2.7.3~rc2-2.1
sshfp recommends no packages.
sshfp suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: sshfp
Source-Version: 1.2.2-3
We believe that the bug you reported is fixed in the latest version of
sshfp, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julien Valroff <[email protected]> (supplier of updated sshfp package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 28 Feb 2012 18:48:02 +0100
Source: sshfp
Binary: sshfp
Architecture: source all
Version: 1.2.2-3
Distribution: unstable
Urgency: low
Maintainer: Julien Valroff <[email protected]>
Changed-By: Julien Valroff <[email protected]>
Description:
sshfp - DNS SSHFP records generator
Closes: 653639 681253
Changes:
sshfp (1.2.2-3) unstable; urgency=low
.
* Drop unconditional dependency on python-argparse which was included in
python 2.7 - thanks to Adrian Bunk <[email protected]> (Closes: #653639)
* Update DEP-5 URI to the final location
* Apply patch to fix undefined variable - thanks to Ward Vandewege
<[email protected]> (Closes: #681253)
* Bump Standards-Version to 3.9.3 (no changes needed)
Checksums-Sha1:
c992dd6cf649a30a20cc17aac8ad8621fca502de 1851 sshfp_1.2.2-3.dsc
0c3d95833d7f13a48c33dec695f4415969a93d2c 3728 sshfp_1.2.2-3.debian.tar.gz
8b7b301d651fc2b4fe8cf09a989e8b24be1cc4f9 26512 sshfp_1.2.2-3_all.deb
Checksums-Sha256:
db7ab46b1bd3777bf6c32b3c09fbd03fd01ea609765ed4c889f6790cd0d97588 1851
sshfp_1.2.2-3.dsc
f0be40307502eec2cfe92e26537166f860d19706fd98857d7b50fe7506249983 3728
sshfp_1.2.2-3.debian.tar.gz
a34f25bb4c97cc4eae855790aaa9147cec6da1d4117f015f82f0a77ceb78cdb1 26512
sshfp_1.2.2-3_all.deb
Files:
b63c04ad8d0a484785709a9c93012d4a 1851 net extra sshfp_1.2.2-3.dsc
4793f865889c399d9e5bdf6cdb1596d8 3728 net extra sshfp_1.2.2-3.debian.tar.gz
d2a60d24ce00cfb9f8902a4ae4fdbe31 26512 net extra sshfp_1.2.2-3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJQASNUAAoJEFHhprzRxas70QgQALtAVnJRzaC7VueoZxs4M/Mi
TJDzC1epr2U/09IAgRuVwPrwDURpAOwMtvlnKBrODn5zO/4xM90PSShMp+c6u7s6
GwLTk5GoT5sTCDTHxaM1WcIrZ7QYLYwWamtB4J9gt1z4uLtzSsCEUAO9qasZizmV
v3P5Fxswn0ZdcmLI7ARLnL433uAbEXuv/3zSkv4/K46Q5snBz2DTXPr2gvKvQjKc
DY3cQAilKndh622Nlkh9ysAATgS4iH1TYJOP/9ojVTWI5Dyf10PaN8hszapGDtxl
0lseBMP8G7aSYWJKIgObn5R2jR4E4jZlXatwh26/Cv0i7+CYw6b88UguKfSzlM5N
yC3HGr2vMvVsV+0Vn3NMkLhmecZvVJyk94apCguBo9a447SKTh73YUJIeaUC2IxU
BLC1Yz+BDuLbooSHzqMmpmFicSBnQzrrjgpD68tggwB3noJ2eFqE9OrZ14CYR2e0
wmrIfxbQxypcYxRgv3WSCcQ2DRyIeufREQuqRzunVNIlzjzhRguBxWgJ9psscw0b
ChPeE79YuxlSmujFfMl/Gtb+7TJbInHD+TUhvE94IMvwt+6R5P3M8oeI0mFMDzOP
cSbFkVPD9Fdj0uLDpqDYDOx+F2mCFiY8bqdzMJUdrj2w17lNcNcmaK19bQ9VZE5g
zMxw5yJRCxLP0AmeGZww
=HD9e
-----END PGP SIGNATURE-----
--- End Message ---
