Your message dated Thu, 20 Oct 2005 02:17:09 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#320452: fixed in vlan 1.9-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Jul 2005 14:33:49 +0000
>From [EMAIL PROTECTED] Fri Jul 29 07:33:49 2005
Return-path: <[EMAIL PROTECTED]>
Received: from vivaldi.madbase.net [81.173.6.10] 
        by spohr.debian.org with smtp (Exim 3.36 1 (Debian))
        id 1DyVvo-0007M5-00; Fri, 29 Jul 2005 07:33:48 -0700
Received: (qmail 24730 invoked from network); 29 Jul 2005 14:33:45 -0000
Received: by simscan 1.0.8 ppid: 24727, pid: 24728, t: 0.0383s
         scanners:none
Received: from unknown (HELO localhost) (127.0.0.1)
  by localhost with SMTP; 29 Jul 2005 14:33:44 -0000
Date: Fri, 29 Jul 2005 10:33:44 -0400 (EDT)
From: Eric Lammerts <[EMAIL PROTECTED]>
X-X-Sender: [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: vconfig doesn't set exit status on error
Message-ID: <[EMAIL PROTECTED]>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02


Package: vlan
Version: 1.8-2

Vconfig doesn't report error conditions in its exit status. This is
quite unpleasant in scripts. Example:

# vconfig add eth1 2 && echo foobar
ERROR: trying to add VLAN #2 to IF -:eth1:-  error: Invalid argument
foobar

I suggest applying the patch below.

thanks,

Eric


--- vconfig.c.orig      2005-07-29 10:25:20.069284000 -0400
+++ vconfig.c   2005-07-29 10:26:10.843355731 -0400
@@ -170,6 +170,7 @@
       // MATHIEU
       //cerr << "ERROR:  Could not open /proc/vlan/config.\n";
       fprintf(stderr,"WARNING:  Could not open /proc/net/vlan/config.  Maybe 
you need to load the 8021q module, or maybe you are not using PROCFS??\n");
+      exit(1);

    }
    else {
@@ -188,6 +189,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to add VLAN #%u to IF -:%s:-  error: 
%s\n",
                     vid, if_name, strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Added VLAN with VID == %u to IF -:%s:-\n",
@@ -202,6 +204,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to remove VLAN -:%s:- error: %s\n",
                  if_name, strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Removed VLAN -:%s:-\n", if_name);
@@ -212,6 +215,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to set egress map on device -:%s:- 
error: %s\n",
                  if_name, strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Set egress mapping on device -:%s:- "
@@ -224,6 +228,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to set ingress map on device -:%s:- 
error: %s\n",
                  if_name, strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Set ingress mapping on device -:%s:- "
@@ -236,6 +241,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to set flag on device -:%s:- error: 
%s\n",
                  if_name, strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Set flag on device -:%s:- "
@@ -248,6 +254,7 @@
       if (ioctl(fd, SIOCSIFVLAN, &if_request) < 0) {
          fprintf(stderr,"ERROR: trying to set name type for VLAN subsystem, 
error: %s\n",
                  strerror(errno));
+         exit(1);
       }
       else {
          fprintf(stdout,"Set name-type for VLAN subsystem."

---------------------------------------
Received: (at 320452-close) by bugs.debian.org; 20 Oct 2005 09:18:30 +0000
>From [EMAIL PROTECTED] Thu Oct 20 02:18:30 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
        id 1ESWXt-0003SO-00; Thu, 20 Oct 2005 02:17:09 -0700
From: Loic Minier <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#320452: fixed in vlan 1.9-1
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Thu, 20 Oct 2005 02:17:09 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2

Source: vlan
Source-Version: 1.9-1

We believe that the bug you reported is fixed in the latest version of
vlan, which is due to be installed in the Debian FTP archive:

vlan_1.9-1.diff.gz
  to pool/main/v/vlan/vlan_1.9-1.diff.gz
vlan_1.9-1.dsc
  to pool/main/v/vlan/vlan_1.9-1.dsc
vlan_1.9-1_i386.deb
  to pool/main/v/vlan/vlan_1.9-1_i386.deb
vlan_1.9.orig.tar.gz
  to pool/main/v/vlan/vlan_1.9.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Loic Minier <[EMAIL PROTECTED]> (supplier of updated vlan package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 20 Oct 2005 11:10:08 +0200
Source: vlan
Binary: vlan
Architecture: source i386
Version: 1.9-1
Distribution: unstable
Urgency: low
Maintainer: Ard van Breemen <[EMAIL PROTECTED]>
Changed-By: Loic Minier <[EMAIL PROTECTED]>
Description: 
 vlan       - user mode programs to enable VLANs on your ethernet devices
Closes: 320452 330673
Changes: 
 vlan (1.9-1) unstable; urgency=low
 .
   * New upstream release.
     - Fix return error codes in vconfig. (Closes: #320452)
   * Fix /etc/network/if-up.d/ip to not set rp_filter to 1 when it isn't
     configured. (Closes: #330673) [debian/ip-if-up]
   * Bump up Standards-Version to 3.6.2. [debian/control]
   * Add myself to the uploaders. [debian/control]
   * Update upstream URL.
Files: 
 41327381d8a6c1fd31cb111bf5be6996 590 misc extra vlan_1.9-1.dsc
 5f0c6060b33956fb16e11a15467dd394 176135 misc extra vlan_1.9.orig.tar.gz
 2bef774a49c6b7f880c460e1edb05e28 10699 misc extra vlan_1.9-1.diff.gz
 ad0d479389c08b4eefcd9d3d3b4636e3 24138 misc extra vlan_1.9-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDV18i4VUX8isJIMARAvuhAJ42NarmHG4+G7Rh8jBpzGjxPd7VHACggUQj
SVTPs4PcjmOs2bWtUQA+VO4=
=7Fye
-----END PGP SIGNATURE-----


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to