Your message dated Sat, 22 Dec 2012 11:32:30 +0000
with message-id <[email protected]>
and subject line Bug#692526: fixed in liferea 1.8.6-1.1
has caused the Debian Bug report #692526,
regarding liferea: crash when dragging GR feeds to parent node
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
692526: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692526
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: liferea
Version: 1.8.6-1
Severity: important
Tags: patch

Dragging feeds outside of google reader to the parent node, and then updating
that feed causes liferea to crash.


Upstream bug report  is here:
http://sourceforge.net/tracker/index.php?func=detail&aid=2855990&group_id=87005&atid=581684

Upstream patch is here:
http://liferea.git.sourceforge.net/git/gitweb.cgi?p=liferea/liferea;a=commitdiff;h=5f245fe87e8f32ff0e13c2e94addaf6032b806c4#patch2


Backported patch attached.



-- System Information:
Debian Release: wheezy/sid
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages liferea depends on:
ii  gconf-service       3.2.5-1+build1
ii  gconf2              3.2.5-1+build1
ii  libatk1.0-0         2.4.0-2
ii  libc6               2.13-35
ii  libcairo2           1.12.2-2
ii  libgconf-2-4        3.2.5-1+build1
ii  libgdk-pixbuf2.0-0  2.26.1-1
ii  libglib2.0-0        2.33.12+really2.32.4-3
ii  libgtk2.0-0         2.24.10-2
ii  libice6             2:1.0.8-2
ii  libjson-glib-1.0-0  0.14.2-1
ii  libnotify4          0.7.5-1
ii  libpango1.0-0       1.30.0-1
ii  libsm6              2:1.2.1-2
ii  libsoup2.4-1        2.38.1-2
ii  libsqlite3-0        3.7.13-1
ii  libunique-1.0-0     1.1.6-4
ii  libwebkitgtk-1.0-0  1.8.1-3.3
ii  libxml2             2.8.0+dfsg1-6
ii  libxslt1.1          1.1.26-14
ii  liferea-data        1.8.6-1

Versions of packages liferea recommends:
ii  curl      7.26.0-1
ii  dbus      1.6.8-1
ii  dbus-x11  1.6.8-1
ii  kget      4:4.8.4-1+b1
ii  wget      1.13.4-3

Versions of packages liferea suggests:
ii  network-manager  0.9.4.0-6

-- no debconf information
>From 5f245fe87e8f32ff0e13c2e94addaf6032b806c4 Mon Sep 17 00:00:00 2001
From: Lars Windolf <[email protected]>
Date: Mon, 30 Jul 2012 23:26:01 +0200
Subject: [PATCH] Fixes SF #2855990: Crash when dragging Google Reader feeds outside Google Reader. This is now prevented. (reported by algnod)

---
 ChangeLog       |    3 +++
 src/ui/ui_dnd.c |    9 ++++++++-
 2 files changed, 11 insertions(+), 1 deletions(-)

--- a/src/ui/ui_dnd.c
+++ b/src/ui/ui_dnd.c
@@ -105,7 +105,7 @@
 	   iterator to insert after). In any case we have to check
 	   if it is a writeable node source. */
 
-	/* never drop into read-only subscription node sources */
+	/* Never drop into read-only subscription node sources */
 	if (!(NODE_SOURCE_TYPE (targetNode)->capabilities & NODE_SOURCE_CAPABILITY_WRITABLE_FEEDLIST))
 		return FALSE;
 
@@ -116,6 +116,13 @@
 	if (gtk_tree_model_get_iter (GTK_TREE_MODEL (model), &iter, src_path)) {
 		gtk_tree_model_get (GTK_TREE_MODEL (model), &iter, FS_PTR, &sourceNode, -1);
 
+		g_assert (sourceNode);
+
+		/* Never drop into another node source as this arises to many problems
+		   (e.g. remote sync, different subscription type, e.g. SF #2855990) */
+		if (NODE_SOURCE_TYPE (targetNode) != NODE_SOURCE_TYPE (sourceNode))
+			return FALSE;
+
 		if (IS_FOLDER(sourceNode) && !(NODE_SOURCE_TYPE (targetNode)->capabilities & NODE_SOURCE_CAPABILITY_HIERARCHIC_FEEDLIST))
 			return FALSE;
 	}

--- End Message ---
--- Begin Message ---
Source: liferea
Source-Version: 1.8.6-1.1

We believe that the bug you reported is fixed in the latest version of
liferea, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David Smith <[email protected]> (supplier of updated liferea package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 15 Dec 2012 16:35:23 +0800
Source: liferea
Binary: liferea liferea-data liferea-dbg
Architecture: source all amd64
Version: 1.8.6-1.1
Distribution: unstable
Urgency: low
Maintainer: Luis Rodrigo Gallardo Cruz <[email protected]>
Changed-By: David Smith <[email protected]>
Description: 
 liferea    - feed aggregator for GNOME
 liferea-data - architecture independent data for liferea
 liferea-dbg - liferea debug symbols
Closes: 668197 677749 692270 692272 692525 692526 692527
Changes: 
 liferea (1.8.6-1.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Fixed crash when dragging Google Reader feeds to parent node.
     (Closes: #692526)
   * Fixed crash when removing folders in Google Reader feeds.
     (Closes: #692525)
   * Fixed crash when opening empty links in feeds. (Closes: #692272)
   * Fixed crash when network online status changes. (Closes: #692270)
   * Fixed bug where web browser doesn't launch or the wrong web browser is
     launched. (Closes: #668197)
   * Replaced build-depends on transitional package libwebkit-dev with
     libwebkitgtk-dev. (Closes: #677749)
   * Added hardening build flags since liferea has a parser and should be
     built with hardening. (Closes: #692527)
   * Added build dependency on dpkg-dev (>= 1.16.1~) to enable build flags
     with hardening.
Checksums-Sha1: 
 7e1c7749c8d65a990f543fcaa29eaf1d89bb8662 2024 liferea_1.8.6-1.1.dsc
 06e82b6cdf6f24e8d6c46cf7a3b4baab16eb2917 23470 liferea_1.8.6-1.1.debian.tar.gz
 0b99d2bb84eb0fedbfd6ad6af2863b74cc0db38a 915214 liferea-data_1.8.6-1.1_all.deb
 afed9a8a0e54c9873bed2644bfaeae7649e7b680 222020 liferea_1.8.6-1.1_amd64.deb
 1a2bf815651bece1cd4fd596c44107cae964830b 808992 liferea-dbg_1.8.6-1.1_amd64.deb
Checksums-Sha256: 
 fa029df5e82d17bf97759fb9f052881a9b6acf08761c7fde0900f841d349997c 2024 
liferea_1.8.6-1.1.dsc
 448b086a0be0dfb545b36a3d9c6895c8ec8fd7e5960a1c39f94c4ff1ea49d64e 23470 
liferea_1.8.6-1.1.debian.tar.gz
 c12e6ce00c8f0cda78f3832a6f6b35f9724643502e23cf1ef0e7aefe79dadc75 915214 
liferea-data_1.8.6-1.1_all.deb
 708813191794cb09d502134098db76fe59bd4b4f15b5f7b2a7ef4f372f24f62c 222020 
liferea_1.8.6-1.1_amd64.deb
 d787aa97d4b530c99521f7b16c4ee7e6ea98f14752b5d9a4c1bf2a72ff9aad07 808992 
liferea-dbg_1.8.6-1.1_amd64.deb
Files: 
 b965ebdcef75bd3f15e666b72bd47b9c 2024 web optional liferea_1.8.6-1.1.dsc
 68df04d98ed4b15564ae618eb58b5f1f 23470 web optional 
liferea_1.8.6-1.1.debian.tar.gz
 4bd03eda97d87e01ba8577c0d6868e82 915214 web optional 
liferea-data_1.8.6-1.1_all.deb
 4cdac5e37cda476d744038ef84ab847c 222020 web optional 
liferea_1.8.6-1.1_amd64.deb
 aa6a01f67be10481f0d158a533dd8aa2 808992 debug extra 
liferea-dbg_1.8.6-1.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBCAAGBQJQ1ZUSAAoJEJxcmesFvXUKFNEIAL19O5tShAK66juVdV/dtrxm
u6c8HX7+utEXjJeg59uso/DoeCNeOIaPG93IOkqQ+q6XiHfO31etn9iaYwOG1d/O
YnZw8AO33dt8c5Vz9wDdNFoOOfrWHa7LlNUTjYuutjZ+OZar/5F/mqB5OK9K7qdh
XkaVA3wvYatS/tAV/GEKvPy6M/GKn5xILaq9IYEWgBzum5LAAnY+4wwWtq2IOMwp
Es6iIaVicAjCxSiVIgcrcR7ip8BzqIFrBW9kZGR62JsYCgKVHEJLWJTGCQj7D0Xm
0uiH/06xwHbO6G0El+V4bNDMSkm2yO1go6/323HJrDIyKKlvFtAQEM+/OrUC0RE=
=RGqF
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to