Your message dated Sat, 29 Dec 2012 22:18:12 +0000
with message-id <[email protected]>
and subject line Bug#325761: fixed in qemu 1.3.0+dfsg-1~exp1
has caused the Debian Bug report #325761,
regarding tundev.c is bloated
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
325761: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=325761
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: qemu
Version: 0.7.0-4
Severity: normal
Tags: patch
Hi!
tundev.c suffers from feature creep. Its purpose is handling the tun device,
but for no good reason it also closes stdin, redirects stdout/stderr to a file,
and forks to get qemu in background.
This is annoying. If I wanted to do any of these things, I would just use
shell redirectors, etc.
The attached patch solves the problem (tested and known to work).
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-1-k7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ANSI_X3.4-1968) (ignored: LC_ALL
set to C)
Versions of packages qemu depends on:
ii bochsbios 2.2.1-1 BIOS for the Bochs emulator
ii libc6 2.3.5-4 GNU C Library: Shared libraries an
ii libsdl1.2debi 1.2.7+1.2.8cvs20041007-5.3 Simple DirectMedia Layer
ii openhackware 0.4.1-1 OpenFirmware emulator for PowerPC
ii proll 18-1 JavaStation PROM 2.x compatible re
ii vgabios 0.5c-1 VGA BIOS software for the Bochs an
ii zlib1g 1:1.2.3-3 compression library - runtime
Versions of packages qemu recommends:
ii debootstrap 0.3.1.5 Bootstrap a basic Debian system
ii sharutils 1:4.2.1-15 shar, unshar, uuencode, uudecode
-- no debconf information
--- /usr/share/doc/qemu/tundev.c 2004-09-30 13:46:46.000000000 +0200
+++ ./tundev.c 2005-08-30 20:26:29.000000000 +0200
@@ -22,9 +22,9 @@
char *newargs[argc + 1];
int fd;
- if (argc < 4) {
+ if (argc < 3) {
fprintf(stderr,
- "Usage: tundev user logfile qemu <qemu options>...\n");
+ "Usage: %s username qemu <qemu options>...\n", argv[0]);
exit(1);
}
@@ -56,31 +56,15 @@
}
/* Insert -tun-fd */
- newargs[0] = argv[3];
+ newargs[0] = argv[2];
newargs[1] = "-tun-fd";
asprintf(&newargs[2], "%d", fd);
- for (i = 4; i <= argc; i++)
- newargs[i-1] = argv[i];
+ for (i = 3; i < argc; i++)
+ newargs[i] = argv[i];
- if (strcmp(argv[2], "-") == 0) {
- execvp(newargs[0], newargs);
- exit(1);
- }
-
- switch (fork()) {
- case 0: {
- close(1);
- close(2);
- open(argv[2], O_WRONLY|O_APPEND);
- open(argv[2], O_WRONLY|O_APPEND);
- close(0);
- execvp(newargs[0], newargs);
- exit(1);
- }
- case -1:
- perror("fork failed");
- exit(1);
- }
printf("%s\n", ifr.ifr_name);
- exit(0);
+
+ execvp(newargs[0], newargs);
+ perror("execvp");
+ exit(1);
}
--- End Message ---
--- Begin Message ---
Source: qemu
Source-Version: 1.3.0+dfsg-1~exp1
We believe that the bug you reported is fixed in the latest version of
qemu, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Tokarev <[email protected]> (supplier of updated qemu package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 30 Dec 2012 01:52:21 +0400
Source: qemu
Binary: qemu qemu-keymaps qemu-system qemu-user qemu-user-static qemu-utils
Architecture: source i386 all
Version: 1.3.0+dfsg-1~exp1
Distribution: experimental
Urgency: low
Maintainer: Debian QEMU Team <[email protected]>
Changed-By: Michael Tokarev <[email protected]>
Description:
qemu - fast processor emulator
qemu-keymaps - QEMU keyboard maps
qemu-system - QEMU full system emulation binaries
qemu-user - QEMU user mode emulation binaries
qemu-user-static - QEMU user mode emulation binaries (static version)
qemu-utils - QEMU utilities
Closes: 325754 325761 597524 676374
Changes:
qemu (1.3.0+dfsg-1~exp1) experimental; urgency=low
.
[ Michael Tokarev ]
* new upstream version (1.3.0) (Closes: #676374)
- Removed patches included upstream:
do-not-include-libutil.h.patch
configure-nss-usbredir.patch
tcg_s390-fix-ld_st-with-CONFIG_TCG_PASS_AREG0.patch
net-add--netdev-options-to-man-page.patch
- update 02_kfreebsd.patch
- do not build mpc8544ds.dtb
- include new targets
* Cleaned up the build system ALOT. Larger changes:
- used explicit lists of emulated targets in debian/rules
and generate everything else from there, instead of repeating
these lists in lots of places.
- stop using debian/$pkg.manpages and other auxilary files like this,
moving eveything to debian/$pkg.install, because with the number
of packages growing, amount of these small files becomes very
large and the result is difficult to maintain.
* ship forgotten target-x86_64.conf in qemu-system.
* ship virtfs-proxy-helper in qemu-utils.
* stop shipping tundev.c, since it does not reflect the reality for
a long time now (Closes: #325761, #325754).
* remove debian/patches/fix-armhf-prctl.patch, it is included
upstream in 1.1.0 version and is misapplied since 1.1.0~rc3+dfsg-1.
* drop -jN passing to downstream makes, as it breaks dpkg-buildpackage -j
and actually breaks build (Closes: #597524 - said to be fixed in 0.14.1
but was still present)
* add revert-serial-fix-retry-logic.patch that restores
old (semi-)working behavour of a virtual serial port.
* re-introduce support parallel build using DEB_BUULD_OPTIONS=parallel=N,
this time by adding to $MAKEFLAGS instead of passing down to submakes
* build-depend on libcap-ng-dev (for virtfs-proxy-helper)
.
[ Vagrant Cascadian ]
* Add libcap-dev to Build-Depends to support virtfs-proxy-helper.
Checksums-Sha1:
8f4790361d82787dff594fb4173b496f9cbc9327 2462 qemu_1.3.0+dfsg-1~exp1.dsc
00b00c2c9e9895d73b4a76a967088761403c583e 4090172 qemu_1.3.0+dfsg.orig.tar.xz
7b2bd9305952e45adb216d1f04d6193fd98f39e6 41747
qemu_1.3.0+dfsg-1~exp1.debian.tar.gz
94346d70e24c5f653c0fb01f20295bafba6ceb08 176832 qemu_1.3.0+dfsg-1~exp1_i386.deb
227ce6061f8426362ce327c9fe9e1ad975032a94 51440
qemu-keymaps_1.3.0+dfsg-1~exp1_all.deb
0729a3705ecb1b41e1a568c51c62aca732624deb 33057420
qemu-system_1.3.0+dfsg-1~exp1_i386.deb
488775448242eae76a65ae786f875fb05d2f7485 8260652
qemu-user_1.3.0+dfsg-1~exp1_i386.deb
de7ed7e88fed4bfd48d5b64bb447e80fa68c43f6 15324334
qemu-user-static_1.3.0+dfsg-1~exp1_i386.deb
621e35fa6a98fe31f14ef9455295585fad057f19 874662
qemu-utils_1.3.0+dfsg-1~exp1_i386.deb
Checksums-Sha256:
11fb67d9d3f51866445ba39ed3fd7bb2f393d63898e2ade22a787b2a8164ef17 2462
qemu_1.3.0+dfsg-1~exp1.dsc
a0ac454975ed1edf1c81abbfb9f7aad15008ac39247eea0c471eec520053f7e6 4090172
qemu_1.3.0+dfsg.orig.tar.xz
dd22541ede35ca072f1a10981cee5092f71d86ebbd9a38d7d7a511478a95117a 41747
qemu_1.3.0+dfsg-1~exp1.debian.tar.gz
311fdd5e347c7779eae92e29a053b05e26caec2a4090c12f98c0e7fb371fccef 176832
qemu_1.3.0+dfsg-1~exp1_i386.deb
9b09e7371fee5ad1b61e23ee778145277377968ffc5f456d9c9bdc61048f55bb 51440
qemu-keymaps_1.3.0+dfsg-1~exp1_all.deb
9b33b3618b0ed9e069fb7e4c68369b99a0e9b5afe18502d06b674b3f5d6568c9 33057420
qemu-system_1.3.0+dfsg-1~exp1_i386.deb
7eb5f76286115c187fb8f54f472f073d8fa61e0d0c19f1157ad1b9375424c2c1 8260652
qemu-user_1.3.0+dfsg-1~exp1_i386.deb
19708ab88b79ad700f845098159713881d86f3e44ff397e5e47ef177b11ba4a7 15324334
qemu-user-static_1.3.0+dfsg-1~exp1_i386.deb
c01720bc7d9c81ea277af90ba71e8f6fc3e7cda5767d5904eebdb88d4acede65 874662
qemu-utils_1.3.0+dfsg-1~exp1_i386.deb
Files:
88ca827970acbed9de09259f4677ec95 2462 misc optional qemu_1.3.0+dfsg-1~exp1.dsc
398c60b15d02192f423b08634266ad83 4090172 misc optional
qemu_1.3.0+dfsg.orig.tar.xz
d1bb8eaa8c5dd706d37d6d21dff226c6 41747 misc optional
qemu_1.3.0+dfsg-1~exp1.debian.tar.gz
5f66d465c976ee4957daa760dc9c74a8 176832 misc optional
qemu_1.3.0+dfsg-1~exp1_i386.deb
36f5d56eff14cb94170572ce12f1d6bf 51440 misc optional
qemu-keymaps_1.3.0+dfsg-1~exp1_all.deb
6ee5824368da00393a842526a22da7d7 33057420 misc optional
qemu-system_1.3.0+dfsg-1~exp1_i386.deb
b9b1febc173d5f40a2d4c59e6aa82dd7 8260652 misc optional
qemu-user_1.3.0+dfsg-1~exp1_i386.deb
2586320b8228f31f5b5e3db510893108 15324334 misc optional
qemu-user-static_1.3.0+dfsg-1~exp1_i386.deb
38e584ee9f7fd34e6b5057bb8e0aca19 874662 misc optional
qemu-utils_1.3.0+dfsg-1~exp1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iJwEAQECAAYFAlDfaHsACgkQUlPFrXTwyDjj8QQAhfrpybRQXFtGhiJU3hw1VEid
pzSBQ7JQhl17iAgSTcqc5OGixXp2GVUeHpeNvSxJeVfz3uwFE6gJuv/ELqlqBFPA
86nfWNyxNtPzqbIYBZBAM40FXQj9c9RX8HVKBtcVvibm6c+gNlagned5ljmbsXyF
mCT2c4oA1xNTu+oemeA=
=qbRj
-----END PGP SIGNATURE-----
--- End Message ---
