Your message dated Thu, 04 Apr 2013 21:33:05 +0000
with message-id <[email protected]>
and subject line Bug#704707: fixed in trac-authopenid 0.4.1-2
has caused the Debian Bug report #704707,
regarding trac-authopenid crashes when an OpenID provider does not provide a
full name
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
704707: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704707
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: trac-authopenid
Version: 0.4.1-1
Severity: normal
Tags: patch upstream
Control: forwarded -1 https://github.com/dairiki/authopenid-plugin/pull/7
Without the attached patch, when an OpenID provider declines to provide a full
name, trac crashes by accessing the authname variable before it was
initialized.
If no full name is provided, it should fall back to using the OpenID
URL as the user's identity.
The patch attached here should work for 0.4.1-1 -- it's slightly
different from the patch i submitted to upstream's master branch
because upstream has some unreleased changes since 0.4.1.
--dkg
-- System Information:
Debian Release: 7.0
APT prefers testing
APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.8-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages trac-authopenid depends on:
ii python 2.7.3-4
ii python-openid 2.2.5-3
ii trac 1.0.1-1
trac-authopenid recommends no packages.
trac-authopenid suggests no packages.
-- debconf-show failed
--- a/authopenid/authopenid.py 2012-06-25 17:06:18.000000000 -0400
+++ b/authopenid/authopenid.py 2013-04-04 16:04:57.542661061 -0400
@@ -584,6 +584,7 @@
remote_user = new_user
if allowed:
+ authname = None
cookie = hex_entropy()
cookie_lifetime = self.trac_auth_cookie_lifetime
@@ -604,9 +605,11 @@
authname = req.session['name']
if self.combined_username:
authname = '%s <%s>' % (authname, remote_user)
+ else:
+ authname = remote_user
# Possibly lower-case the authname.
- if self.lowercase_authname:
+ if authname and self.lowercase_authname:
authname = authname.lower()
# Make authname unique in case of collisions
--- End Message ---
--- Begin Message ---
Source: trac-authopenid
Source-Version: 0.4.1-2
We believe that the bug you reported is fixed in the latest version of
trac-authopenid, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Kahn Gillmor <[email protected]> (supplier of updated
trac-authopenid package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 04 Apr 2013 16:44:50 -0400
Source: trac-authopenid
Binary: trac-authopenid
Architecture: source all
Version: 0.4.1-2
Distribution: unstable
Urgency: low
Maintainer: Jeremy Lainé <[email protected]>
Changed-By: Daniel Kahn Gillmor <[email protected]>
Description:
trac-authopenid - OpenID authentication plugin for Trac
Closes: 704707
Changes:
trac-authopenid (0.4.1-2) unstable; urgency=low
.
* Avoid crash when OpenID provider does not give a full name
(Closes: #704707)
Checksums-Sha1:
be12ed33a42451da4ad3e3dec4a19004e9f47047 2169 trac-authopenid_0.4.1-2.dsc
792a7df038ef9909dce5ac7dcee14e618eda031d 2942
trac-authopenid_0.4.1-2.debian.tar.gz
cc9ef060b21d99135682c60de3b5e7b873c9a6a3 39998 trac-authopenid_0.4.1-2_all.deb
Checksums-Sha256:
41dbe81a7d1c80fe7684bbb991660c5374d6d0261631e2d2ed7a3b4463eb8077 2169
trac-authopenid_0.4.1-2.dsc
8cb4e752361fe90f39800a703a4e32fb020250ef8020f833ef238500c1e31faa 2942
trac-authopenid_0.4.1-2.debian.tar.gz
43b012c24d1dfe5b10f4f5d651c50660750f181448a32af0b2602086b970b439 39998
trac-authopenid_0.4.1-2_all.deb
Files:
6a4b944cc6b0375d9b8de4a6f622a8dd 2169 python optional
trac-authopenid_0.4.1-2.dsc
2adf2e8e8146c7eeecbe05f95d3a3207 2942 python optional
trac-authopenid_0.4.1-2.debian.tar.gz
2283ee55a2d360e838587735b3830142 39998 python optional
trac-authopenid_0.4.1-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQJ8BAEBCgBmBQJRXeu2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFQjk2OTEyODdBN0FEREUzNzU3RDkxMUVB
NTI0MDFCMTFCRkRGQTVDAAoJEKUkAbEb/fpczp4P/1AesetQyoff3x1qw5j1P1A4
Q3/0zjrkMCtrfHd6u75kT+GtM8/nIdgt6aizeDLfLuxZ/6qq7m49dBQC1Yh2J8Hr
jK96mQWE8dyI86VeOgrIGUe01zw0AGqMn6Bcj3LZ7WRn4Oh2kSZVIOepGHrBtPUy
z9aVThJr3RZw9GpcWw6bPPeRbE+p2avVN3u8uOvDvChbmZ/F+ODfV+4uh7SSvtfw
8ycgICADJe4LpLSm6/9GV37N89WDKu+0HbG1PQ80Q/NcRQLVMAYYgvLW/QjRM1sH
v/Swy2DOqRfaekYOZGtj3Kh0yqr75wuMXiYrPRrGPZzx+iAdsdg+yB3t5xFlHfDe
emX8IG9L2jaw3FAxIZ/Eqlyds0z6me8R820/iGlYPAGIPWjR7H8web8TLhsY1br/
PuSBPkU/PcQ/6BfdWm/bb06v+/W1LHzES2EoJzsIyzqmoa/AuuHR4qjsPzZbYSWQ
tcwuo8b1NNo+7WRBB+ZZFiLGm7bVsP5FwJIUNmuWGZNbT7QREs1qkxutUEfCywPR
vw7WbGq8qzVI3BWg+M7de7Y/DljPXL2BxW0Bd8SoiA3hntekAOwELjuefm0DqnQx
XL/8W3BKEbGfhVKnzs4akdVCWFvGqWf3hA3adqe/biVnzMuJM7o8hpMu/cilL+MS
21JQxxMNTQYUECO4XTMp
=U86K
-----END PGP SIGNATURE-----
--- End Message ---
