Your message dated Tue, 23 Apr 2013 00:17:46 +0000
with message-id <[email protected]>
and subject line Bug#682388: fixed in powertop 2.0-0.3
has caused the Debian Bug report #682388,
regarding powertop: buffer overrun in process::process
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
682388: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682388
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: powertop
Version: 2.0-0.2
Severity: important
Tags: upstream

powertop crashes at startup with
*** stack smashing detected ***: powertop terminated

The crash is not reproducible with powertop:amd64.

After recompiling powertop to get debug symbols I got the following
backtrace with gdb.:

#0  0xf7fdf425 in __kernel_vsyscall ()
#1  0xf7ca1941 in *__GI_raise (sig=6) at 
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0xf7ca4d72 in *__GI_abort () at abort.c:92
#3  0xf7cdb305 in __libc_message (do_abort=2, fmt=0xf7dae5c8 "*** %s ***: %s 
terminated\n")
    at ../sysdeps/unix/sysv/linux/libc_fatal.c:189
#4  0xf7d5beb0 in *__GI___fortify_fail (msg=<optimized out>) at 
fortify_fail.c:32
#5  0xf7d5be5a in __stack_chk_fail () at stack_chk_fail.c:29
#6  0x08066f91 in process::process (this=0xdf00650, _comm=<optimized out>, 
_pid=7812, _tid=0) at process/process.cpp:140
#7  0x08067277 in find_create_process (comm=0xde7794c "mplayer", pid=7812) at 
process/process.cpp:173
#8  0x0806a9b3 in perf_process_bundle::handle_trace_point (this=0xde4e080, 
trace=0xde7791c, cpu=0, time=1053728094267690)
    at process/do_process.cpp:264
#9  0x0806fd52 in perf_bundle::process (this=0xde4e080) at 
perf/perf_bundle.cpp:303
#10 0x0806b6c6 in process_process_data () at process/do_process.cpp:1131
#11 0x08089d0f in one_measurement (seconds=1) at main.cpp:193
#12 0x0804dd5a in main (argc=1, argv=0xffffdc94) at main.cpp:418


/proc/7812/cmdline contains exactly 4096 characters (though
process::process appears to read only 4095 of them) and is not
null-terminated. As a result, variable "line" does not contain
sequence of two nulls and cmdline_to_string replaces nulls with spaces
further into stack until it finds such sequence.

As expected, powertop does not crash if there is no process with long
command line.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing'), (400, 'stable')
Architecture: i386 (x86_64)
Foreign Architectures: amd64

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages powertop depends on:
ii  libc6             2.13-33
ii  libgcc1           1:4.7.1-2
ii  libncursesw5      5.9-10
ii  libnl-3-200       3.2.7-4
ii  libnl-genl-3-200  3.2.7-4
ii  libpci3           1:3.1.9-5
ii  libstdc++6        4.7.1-2
ii  libtinfo5         5.9-10
ii  zlib1g            1:1.2.7.dfsg-13

powertop recommends no packages.

Versions of packages powertop suggests:
ii  cpufrequtils       008-1
pn  laptop-mode-tools  <none>

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: powertop
Source-Version: 2.0-0.3

We believe that the bug you reported is fixed in the latest version of
powertop, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonathan Wiltshire <[email protected]> (supplier of updated powertop package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 21 Apr 2013 00:38:10 +0100
Source: powertop
Binary: powertop
Architecture: source amd64
Version: 2.0-0.3
Distribution: unstable
Urgency: high
Maintainer: Patrick Winnertz <[email protected]>
Changed-By: Jonathan Wiltshire <[email protected]>
Description: 
 powertop   - Linux tool to find out what is using power on a laptop
Closes: 682388
Changes: 
 powertop (2.0-0.3) unstable; urgency=high
 .
   * Non-maintainer upload.
   * Add patch long-process-names-nullterm.patch to prevent a crash
     on paticularly long process names (Closes: #682388)
Checksums-Sha1: 
 7ef0b9838e988be2fbee8431de1b8b1cff9d4ba7 1836 powertop_2.0-0.3.dsc
 0c91f6f2b3299f864f1f7f42e8c0c04c7d9b29ea 7790 powertop_2.0-0.3.debian.tar.gz
 c2fb13ea76fb2f507fde49c0b1e17cad04a19b95 173414 powertop_2.0-0.3_amd64.deb
Checksums-Sha256: 
 611c055ae114852f6afdad087afae80b26d0a06302abb64d5f52571b9e8e3c5e 1836 
powertop_2.0-0.3.dsc
 7c0d37d16a489c1230322709edaaa7c11c7fd8497a11b81ceed23852ea58e902 7790 
powertop_2.0-0.3.debian.tar.gz
 f8172c415e9fcc1ce952a6cc23892bb5207f9ba5952e20867eb6d94ae91cbb33 173414 
powertop_2.0-0.3_amd64.deb
Files: 
 f942d442c9689aea9aa941c4e61f9617 1836 utils extra powertop_2.0-0.3.dsc
 c1e2732c4b71fc8557a52584e1015a9d 7790 utils extra 
powertop_2.0-0.3.debian.tar.gz
 085102b7bf2edbb7c6d4b43466270e75 173414 utils extra powertop_2.0-0.3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJRcyqwAAoJEFC7AtTIpr9hn/gP/jbxuldPhdQ2zs+hQ8BFfocz
YRyASBKNi6HZpCNc+dnQEgHZ/wdye3LpDuWsLlAdBoqWXsQKOJOiIo8no2jNatBP
ytyvXg5BgxacvlzxH5mLyDp/V80dMVj+1hHwU1VEgDoQS+XXIQEAlWgfMB1GA+WB
Fhcuyr1wJThZnBqpCPXzAsrd1lnhBXyR0/B267F8awpD4zsslvCYyBB3j2BddV5B
qasZLvo0xMH8JnBATUXG6vxP6U1kTXlD+uSP7S3kd4/HMwyIseSa02LzSIHounCX
I6+C26LrQvaUdn94kfetnAA6E8LnZXkZpi/F30cMHpmNBb8Q8IHjgtl9I/CW2E8Y
XY1L4h8sL9hvC04Y8/VRZCw/bGhlruaZRXqmyLuKjiUpcGKHKsq6KH2OuKSwGfyh
HvvGkjuY8CMmONnVJ1qKs1Gq8xgSE5jcMsfVKe3H00EULuYUFdd5kBVMgeNxqnmE
9d1txzJct7rByGTjnOGfiuq0hTkjL5d+eizqW5zergKq+qEXH1FOHzl+3ugGac+T
Vp2Fd24dmH1RuAgiTOEe/dtYEgL9DzEAHx8g53tWbfEJgaQFgm6cBl2p+9550Fq0
h10EUGXWopjOEUCc1BM0LWXYoCAN9B9KgPTguCuiRDsinut6JKltB2P6NbLyvN9j
R/V9trlf4tJtnTV9m3pc
=EMQ1
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to