Your message dated Tue, 25 Oct 2005 14:17:19 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#335191: fixed in mgdiff 1.0-28
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 22 Oct 2005 13:46:04 +0000
>From [EMAIL PROTECTED] Sat Oct 22 06:46:04 2005
Return-path: <[EMAIL PROTECTED]>
Received: from 148.red-213-96-98.staticip.rima-tde.net (javifsp.no-ip.org)
[213.96.98.148] (Debian-exim)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1ETJhE-0000Hm-00; Sat, 22 Oct 2005 06:46:04 -0700
Received: from jfs by javifsp.no-ip.org with local (Exim 4.52)
id 1ETJhC-0002me-Hq
for [EMAIL PROTECTED]; Sat, 22 Oct 2005 15:46:02 +0200
Date: Sat, 22 Oct 2005 15:46:02 +0200
From: Javier =?iso-8859-1?Q?Fern=E1ndez-Sanguino_Pe=F1a?= <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: msgdiff: Allows user to set both input as '-'
Message-ID: <[EMAIL PROTECTED]>
Mail-Followup-To: [EMAIL PROTECTED]
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7"
Content-Disposition: inline
User-Agent: Mutt/1.5.10i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
--GRPZ8SYKNexpdSJ7
Content-Type: multipart/mixed; boundary="Qxx1br4bt0+wmkIi"
Content-Disposition: inline
--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: mgdiff
Version: 1.0-27
Severity: normal
Tags: patch
Mgdiff will happily allow users to set '-' as both files which will not work
(since stdin is only read once) and makes it generate two temporary files
(although only the last one will be removed on exit).
The attached patch fixes this by having it reject a call of the form:=20
$ msgdiff - -=20
Regards
Javier
--Qxx1br4bt0+wmkIi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="msgdiff_stdin_input.diff"
--- mgdiff-1.0-27/mgdiff.c 2005-10-22 15:24:06.000000000 +0200
+++ mgdiff-1.0/mgdiff.c 2005-10-22 15:43:13.000000000 +0200
@@ -1163,6 +1163,10 @@
* two filenames on command line; process them
*/
case 3:
+ if (strcmp (argv[1], "-") == 0 && strcmp (argv[1], "-") == 0) {
+ (void) fprintf (stderr, "Cannot use stdin for both file
input\n");
+ exit (2);
+ }
if (strcmp (argv[1], "-") == 0) {
if (!copy_to_tempfile (stdin, tempfname, sizeof (tempfname))) {
(void) fprintf (stderr, "Error copying stdin to temp file
\"%s\"\n", tempfname);
--Qxx1br4bt0+wmkIi--
--GRPZ8SYKNexpdSJ7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDWkKasandgtyBSwkRAsXhAJ9Q1W6n8MW3GJ7SO7F59/iTThGEdgCghTV5
ocoKpEF53cb0hELXHy6Zl1s=
=RsW1
-----END PGP SIGNATURE-----
--GRPZ8SYKNexpdSJ7--
---------------------------------------
Received: (at 335191-close) by bugs.debian.org; 25 Oct 2005 21:17:45 +0000
>From [EMAIL PROTECTED] Tue Oct 25 14:17:45 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EUWAZ-0003ge-00; Tue, 25 Oct 2005 14:17:19 -0700
From: Edelhard Becker <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#335191: fixed in mgdiff 1.0-28
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Tue, 25 Oct 2005 14:17:19 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: mgdiff
Source-Version: 1.0-28
We believe that the bug you reported is fixed in the latest version of
mgdiff, which is due to be installed in the Debian FTP archive:
mgdiff_1.0-28.diff.gz
to pool/main/m/mgdiff/mgdiff_1.0-28.diff.gz
mgdiff_1.0-28.dsc
to pool/main/m/mgdiff/mgdiff_1.0-28.dsc
mgdiff_1.0-28_i386.deb
to pool/main/m/mgdiff/mgdiff_1.0-28_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Edelhard Becker <[EMAIL PROTECTED]> (supplier of updated mgdiff package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 25 Oct 2005 22:48:37 +0200
Source: mgdiff
Binary: mgdiff
Architecture: source i386
Version: 1.0-28
Distribution: unstable
Urgency: low
Maintainer: Edelhard Becker <[EMAIL PROTECTED]>
Changed-By: Edelhard Becker <[EMAIL PROTECTED]>
Description:
mgdiff - xdiff clone
Closes: 335188 335191
Changes:
mgdiff (1.0-28) unstable; urgency=low
.
* bug fixes by Javier Fernández-Sanguino Peña <[EMAIL PROTECTED]>
- Insecure /tmp usage in viewpatch example script (Closes: #335188)
- mgdiff: Allows user to set both input as '-' (Closes: #335191)
Thanks Javier!
Files:
7c876ade0f3c096114650f6efb81fc83 575 text optional mgdiff_1.0-28.dsc
27d0664b81e045a08a639fdf6ec244bc 41077 text optional mgdiff_1.0-28.diff.gz
649a96a9b6ee3387ae519a9fb15cdd3f 58242 text optional mgdiff_1.0-28_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDXqBPlByGkm8iLx8RAvMDAJ43Egega8J92G8nfSDy3S0U+6OCgACdFPYT
bawfcSX69s2p6Z+3NeZWO/8=
=kWf3
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
