Your message dated Sun, 05 May 2013 04:17:48 +0000
with message-id <[email protected]>
and subject line Bug#704453: fixed in moreutils 0.48
has caused the Debian Bug report #704453,
regarding moreutils/sponge fails silently if the destination file cannot be 
written
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
704453: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704453
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: moreutils
Version: 0.47
Severity: normal

Dear Maintainer,

I have found what seems to be a bug in "sponge", which does not propagate the
write error when writing to its output file, failing silently.

   * What led up to the situation?

$ echo  | sponge /dev/full && echo OK
OK

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

   * What was the outcome of this action?

It could not obviously write to /dev/full, but returned EXIT_SUCESS.

   * What outcome did you expect instead?

I would expect it to return a non-zero return value and a message.

   * Debug details

$ echo | strace sponge /dev/full
[...]
open("/dev/full", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 4
lseek(3, 0, SEEK_SET)                   = 0
read(3, "\n", 8192)                     = 1
fstat(4, {st_mode=S_IFCHR|0666, st_rdev=makedev(1, 7), ...}) = 0
ioctl(4, SNDCTL_TMR_TIMEBASE or TCGETS, 0x7fff7e925e80) = -1 ENOTTY
(Inappropriate ioctl for device)
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
0x7f8e389b8000
read(3, "", 8192)                       = 0
close(3)                                = 0
munmap(0x7f8e389b9000, 4096)            = 0
write(4, "\n", 1)                       = -1 ENOSPC (No space left on device)
close(4)                                = 0
munmap(0x7f8e389b8000, 4096)            = 0
rt_sigprocmask(SIG_BLOCK, [HUP INT QUIT PIPE ALRM TERM XCPU XFSZ VTALRM PROF
IO], [], 8) = 0
unlink("/tmp/sponge.wsOZkV")            = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
exit_group(0)                           = ?
[...]

As you can see, the write() fails but the error is not propagated.

I think this issue is potentially (although remotely probably) serious since
sponge lends itself to be used to automatically edit files, but it will thrash
them if the concerning filesystem happens to become full during the editing.

Thank you.

Raúl Salinas



-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=eo.UTF-8, LC_CTYPE=eo.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages moreutils depends on:
ii  libc6            2.13-38
ii  libipc-run-perl  0.92-1
ii  perl             5.14.2-19

moreutils recommends no packages.

Versions of packages moreutils suggests:
pn  libtime-duration-perl  <none>
ii  libtimedate-perl       1.2000-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: moreutils
Source-Version: 0.48

We believe that the bug you reported is fixed in the latest version of
moreutils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <[email protected]> (supplier of updated moreutils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 04 May 2013 23:50:03 -0400
Source: moreutils
Binary: moreutils
Architecture: source i386
Version: 0.48
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <[email protected]>
Changed-By: Joey Hess <[email protected]>
Description: 
 moreutils  - additional Unix utilities
Closes: 697113 704453
Changes: 
 moreutils (0.48) unstable; urgency=low
 .
   * Allow overriding PREFIX and CFLAGS to make the build more flexible
     (Thanks, Ben Walton)
   * Typo. Closes: #697113
   * ts: -i enables incremental timestamping.
     Thanks, Thomas Vander Stichele
   * ts: Support single-digit day dates.
     Thanks, Peter Lunicks
   * sponge: Check fclose to detect certian short reads. Closes: #704453
Checksums-Sha1: 
 446426af43af0016b5f6391f1f6b6fb36fbbbd53 1508 moreutils_0.48.dsc
 023893342ce68d877f4a8eb14142bbd7fd3706ee 46748 moreutils_0.48.tar.gz
 5342858199dde5a685f01ace2a3d8ae38ccaf707 61524 moreutils_0.48_i386.deb
Checksums-Sha256: 
 67b0dee569bc9f23548486304b25a9355db6ff085a6694fbf6b3b34ef7f6fe08 1508 
moreutils_0.48.dsc
 294d097ea7d7a8c7a8205a234e9861a1d64042f639bc609e11696b12b8db8c2d 46748 
moreutils_0.48.tar.gz
 ddeb7120df20d638780b5822c3e988b1e92d0f75c65b28a12bcf4bc224bdf0a9 61524 
moreutils_0.48_i386.deb
Files: 
 4a2cd3a41feed6ff17de9f3e44cad796 1508 utils optional moreutils_0.48.dsc
 c6f1eb13132a88ce053be709aa2625d2 46748 utils optional moreutils_0.48.tar.gz
 9ac2de9d75a322a302d2e0b5b44981f2 61524 utils optional moreutils_0.48_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBUYXZvMkQ2SIlEuPHAQj2Lw/9F+TJC75sFsVuRi5i2LqndWS71mTN74N1
Zu2v7gqAofqE0j4qAdfOrbDXa1oaJfsBrtrdFON54hJQpdMSq0qmk4XQq5WXMtGN
Mg95kFWhscqJSjI9VGuZt6jzIZ+2TZsrYU/2eBUAk0F9pJoPmd1Ycu92nCdaYqYo
otnD0/dfGIo/CbRx9EqJsPg4tKoDWWEnUsiTd3mpUmUaV2z3GNFVsQYlchXmithr
ymbiK5PC47QEcg7jhcS/dvROiC/GCIXB1yYvmZ3v2JsTJsO3cNnAdiQO/CbKCNti
E51AMrUNcDFqcVWkJSB/EKO2icWUUNyxyyN4Pb8B/57M5LAK0LVGkw9N9CT69uWz
5v+pVCkZV2WZTSCdnAT/XmMTqGcsA9QRdPnbXMnxCLMVgbAHaqwiBX1+576gYeLF
nWszfjxQwlJ1dYRRsIC6R2l0a3X8reDqSGP0PxC/wiqxGssbg6oyxaZFFNepp0Kw
lZkC34jx2wIbGMg/8B5wHbOVsbaM12lFNWFQtb8JxjP94KJbfm87G1wz4tPZxofo
yjbdyWqdha3kAFgl0ctnhuLHFB4dnr2Nx0oBsYhYk3YPxgHV372CocINdme7d0YQ
+kyM8LQlPtErburYHS4+u4R1jE29Utsqf3guz7BUdySmtVL8YENZ1irE7I8tCHj4
5zBwfe/TTFM=
=D2WM
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to