Your message dated Sun, 19 May 2013 15:48:26 +0000
with message-id <[email protected]>
and subject line Bug#679217: fixed in libevent 2.0.21-stable-1
has caused the Debian Bug report #679217,
regarding libevent: memleaks - scoped cleanup on bailing out
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
679217: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679217
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libevent
Version: 2.0.19-stable-3
Severity: normal
Tags: upstream patch
Hi Anibal,
Attached are two trivial tweaks [1] to free memory allocated
inside routines. Explanations are in the patch headers proper.
While they look trivial, I can quite judge the impact, since I
don't have a clear idea how often are these called and fail to
reclaim the allocated memory on bail-out.
[1] I did dpkg-source --commit for you, please poke upstream,
and add to series if you find them appropriate, also adjusting
patch headers with the info further returned by BTS.
Description: free handle is request_new fails
Trivial clean up on bailing out
.
libevent (2.0.19-stable-3) unstable; urgency=low
.
* [ceb52d98] DH compatibility level is 9
* [7792ab18] Support multiarch (Closes: #675320)
Author: Anibal Monsalve Salazar <[email protected]>
Bug-Debian: http://bugs.debian.org/675320
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- libevent-2.0.19-stable.orig/evdns.c
+++ libevent-2.0.19-stable/evdns.c
@@ -2291,7 +2291,10 @@ nameserver_send_probe(struct nameserver
handle = mm_calloc(1, sizeof(*handle));
if (!handle) return;
req = request_new(ns->base, handle, TYPE_A, "google.com", DNS_QUERY_NO_SEARCH, nameserver_probe_callback, ns);
- if (!req) return;
+ if (!req) {
+ mm_free(handle);
+ return;
+ }
ns->probe_request = handle;
/* we force this into the inflight queue no matter what */
request_trans_id_set(req, transaction_id_pick(ns->base));
Description: free req when bailing out and returning NULL
I can see the comment of uncertaincy /* XXX Should we dealloc req? If yes, how? */
but I think req should be nevertheless freed by mm_free() on bailing out and
returning NULL from search_request_new(), as req was allocated by mm_malloc in
request_new(). This is the trivial scoped cleaning.
Further, the callers of search_request_new() are supposed to check its return
value against NULL. Not done yet, but should trivial to add.
.
libevent (2.0.19-stable-3) unstable; urgency=low
.
* [ceb52d98] DH compatibility level is 9
* [7792ab18] Support multiarch (Closes: #675320)
Author: Anibal Monsalve Salazar <[email protected]>
Bug-Debian: http://bugs.debian.org/675320
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- libevent-2.0.19-stable.orig/evdns.c
+++ libevent-2.0.19-stable/evdns.c
@@ -3158,6 +3158,8 @@ search_request_new(struct evdns_base *ba
handle->search_origname = mm_strdup(name);
if (handle->search_origname == NULL) {
/* XXX Should we dealloc req? If yes, how? */
+ if (req)
+ mm_free(req);
return NULL;
}
handle->search_state = base->global_search_state;
--- End Message ---
--- Begin Message ---
Source: libevent
Source-Version: 2.0.21-stable-1
We believe that the bug you reported is fixed in the latest version of
libevent, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Leo Costela <[email protected]> (supplier of updated libevent package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 19 May 2013 00:40:30 +0200
Source: libevent
Binary: libevent-dev libevent-dbg libevent-2.0-5 libevent-core-2.0-5
libevent-extra-2.0-5 libevent-pthreads-2.0-5 libevent-openssl-2.0-5
Architecture: source amd64
Version: 2.0.21-stable-1
Distribution: unstable
Urgency: low
Maintainer: Anibal Monsalve Salazar <[email protected]>
Changed-By: Leo Costela <[email protected]>
Description:
libevent-2.0-5 - Asynchronous event notification library
libevent-core-2.0-5 - Asynchronous event notification library (core)
libevent-dbg - Asynchronous event notification library (debug symbols)
libevent-dev - Asynchronous event notification library (development files)
libevent-extra-2.0-5 - Asynchronous event notification library (extra)
libevent-openssl-2.0-5 - Asynchronous event notification library (openssl)
libevent-pthreads-2.0-5 - Asynchronous event notification library (pthreads)
Closes: 679217
Changes:
libevent (2.0.21-stable-1) unstable; urgency=low
.
* [dd23c3ce] Imported Upstream version 2.0.21-stable
- fix memleaks in evdns (closes: 679217)
* [bbc5530e] debian/control: use canonical VCS URL
Checksums-Sha1:
aa9524cf7dc5b8ff430b873c7762a24326ba7ce5 1707 libevent_2.0.21-stable-1.dsc
3e6674772eb77de24908c6267c698146420ab699 850772
libevent_2.0.21-stable.orig.tar.gz
2353ce53fccc03df454c1b11eedc08232e383625 7588
libevent_2.0.21-stable-1.debian.tar.xz
09cc15c5bb1fb013dda12d4bf0deeb0582fefd50 328156
libevent-dev_2.0.21-stable-1_amd64.deb
9e2d29656a02cd6db8bc08e2e514af137e388e04 723546
libevent-dbg_2.0.21-stable-1_amd64.deb
5f3f22e786d1ee90ffb5c5b7599e5d77f0473dea 173188
libevent-2.0-5_2.0.21-stable-1_amd64.deb
353b965f821034000bd933843d889ff8f80dcc33 122132
libevent-core-2.0-5_2.0.21-stable-1_amd64.deb
593db38155eeaaf0fd51c71e509cb500fae6e689 102932
libevent-extra-2.0-5_2.0.21-stable-1_amd64.deb
d146f38f8ce8ec955d29369b798a82a06c9dcf4d 45436
libevent-pthreads-2.0-5_2.0.21-stable-1_amd64.deb
d7ef838fb8687e7eeb065ce2936badb8a3555f15 53114
libevent-openssl-2.0-5_2.0.21-stable-1_amd64.deb
Checksums-Sha256:
b788367774e3398dc397c5aa2bd6878a4607e740fda22776024e3c9c4c74b6aa 1707
libevent_2.0.21-stable-1.dsc
22a530a8a5ba1cb9c080cba033206b17dacd21437762155c6d30ee6469f574f5 850772
libevent_2.0.21-stable.orig.tar.gz
5c773d3bde810e6a09a05c76825df2fbf8234d59a95bf7d89f40c501cdb6e4fd 7588
libevent_2.0.21-stable-1.debian.tar.xz
7bb26d6c0c9a123f2f4bc67ca44ca728baa4ee73f2867691220047fc4032904c 328156
libevent-dev_2.0.21-stable-1_amd64.deb
57cbac63895a1258be3e746cd007ed866418dd34318b6e7c88ca1995b9210f2f 723546
libevent-dbg_2.0.21-stable-1_amd64.deb
be9a4f848cfea3a36f88f879418ec1337edf9ffe391c6af1daaeed8de83d45eb 173188
libevent-2.0-5_2.0.21-stable-1_amd64.deb
fc1173706f9739dabb7a4ed86ab7508fbe727e6849ba3124e03947b2b2d8287f 122132
libevent-core-2.0-5_2.0.21-stable-1_amd64.deb
cda42c7b5fa128501dbaa98a6c100bd5752480ee28c9d43f52bb16522152882f 102932
libevent-extra-2.0-5_2.0.21-stable-1_amd64.deb
b508be258b9f8dc4edfdbd4c4f9c314eb26ed47708bbf7f75e7e84e99b24c5ea 45436
libevent-pthreads-2.0-5_2.0.21-stable-1_amd64.deb
0789c1733a3eda9f89028b91fdcab88b41613a57fe601f3dc184f0f676decf7e 53114
libevent-openssl-2.0-5_2.0.21-stable-1_amd64.deb
Files:
0e0ff1aa6c0fce51376f687c6aa90ae5 1707 libs optional
libevent_2.0.21-stable-1.dsc
b2405cc9ebf264aa47ff615d9de527a2 850772 libs optional
libevent_2.0.21-stable.orig.tar.gz
91c9537a078d592c7be932c4c6dcdaaa 7588 libs optional
libevent_2.0.21-stable-1.debian.tar.xz
c6e63d7ffe970359360e87e997ed7a17 328156 libdevel optional
libevent-dev_2.0.21-stable-1_amd64.deb
b69b36c079392bd073160adc00835beb 723546 debug extra
libevent-dbg_2.0.21-stable-1_amd64.deb
3ac7b96ca417d386badeec5c3cbe7826 173188 libs standard
libevent-2.0-5_2.0.21-stable-1_amd64.deb
ef7581e9729f85765b86e0e7d61fc002 122132 libs optional
libevent-core-2.0-5_2.0.21-stable-1_amd64.deb
ed617ea81d1c8cf5c7df74890e4f4e4c 102932 libs optional
libevent-extra-2.0-5_2.0.21-stable-1_amd64.deb
c9fd2b1d4a6d2c9da0dec5c2e592030a 45436 libs optional
libevent-pthreads-2.0-5_2.0.21-stable-1_amd64.deb
f21e7bc816f847dea96ffa6a0f735568 53114 libs optional
libevent-openssl-2.0-5_2.0.21-stable-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlGY8s0ACgkQImLTb3rflGZu5gCg42pU5EUKDibcOfWPDsk8AzA+
+cEAoO8uaQprFG0Kz/aqFkyCJgSkcWzl
=b2l7
-----END PGP SIGNATURE-----
--- End Message ---
