Your message dated Sun, 02 Jun 2013 09:49:48 +0000
with message-id <[email protected]>
and subject line Bug#710364: fixed in saint 2.3.4+dfsg-2
has caused the Debian Bug report #710364,
regarding saint: fails to build with ld --as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
710364: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710364
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: saint
Version: 2.3.4+dfsg-1
Severity: wishlist
Tags: patch

saint fails to build with ld --as-needed
this flag requires libraries to be placed after objects needing
their symbols.
this causes build failures in ubuntu:

gcc -lm -lgsl -lgslcblas  -Wl,-Bsymbolic-functions -Wl,-z,relro
/tmp/buildd/saint-2.3.4+dfsg/build/*.o -o
/tmp/buildd/saint-2.3.4+dfsg/bin/saint-reformat
/tmp/buildd/saint-2.3.4+dfsg/build/initdata.o: In function `reformat_data':
/tmp/buildd/saint-2.3.4+dfsg/src/SAINTreformat/initdata.c:305: undefined
reference to `gsl_sort

attached patch fixes the issue.
Description: fix build failure with ld --as-needed
 libraries need to be placed after objects needing them
--- a/Makefile
+++ b/Makefile
@@ -43,7 +43,7 @@ all: makeDirs \
 saint-reformat:
 	$(CC) $(CFLAGS) -c $(SRC)/SAINTreformat/*.c $(SRC)/SAINTreformat/*.h
 	mv *.o $(BUILD)
-	$(CC) $(LIBS) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-reformat
+	$(CC) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-reformat $(LIBS)
 	rm $(BUILD)/*.o
 	@echo
 	@echo
@@ -52,7 +52,7 @@ saint-reformat:
 saint-spc-noctrl-matrix:
 	$(CC) $(CFLAGS) -c $(SRC)/SAINTspc-noctrl-matrix/*.c $(SRC)/SAINTspc-noctrl-matrix/*.h
 	mv *.o $(BUILD)
-	$(CC) $(LIBS) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-noctrl-matrix
+	$(CC) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-noctrl-matrix $(LIBS)
 	rm $(BUILD)/*.o
 	@echo
 	@echo
@@ -60,7 +60,7 @@ saint-spc-noctrl-matrix:
 saint-spc-noctrl:
 	$(CC) $(CFLAGS) -c $(SRC)/SAINTspc-noctrl/*.c $(SRC)/SAINTspc-noctrl/*.h
 	mv *.o $(BUILD)
-	$(CC) $(LIBS) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-noctrl
+	$(CC) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-noctrl $(LIBS)
 	rm $(BUILD)/*.o
 	@echo
 	@echo
@@ -69,7 +69,7 @@ saint-spc-noctrl:
 saint-spc-ctrl:
 	$(CC) $(CFLAGS) -c $(SRC)/SAINTspc-ctrl/*.c $(SRC)/SAINTspc-ctrl/*.h
 	mv *.o $(BUILD)
-	$(CC) $(LIBS) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-ctrl
+	$(CC) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-spc-ctrl $(LIBS)
 	rm $(BUILD)/*.o
 	@echo
 	@echo
@@ -78,7 +78,7 @@ saint-spc-ctrl:
 saint-int-ctrl:
 	$(CC) $(CFLAGS) -c $(SRC)/SAINTint-ctrl/*.c $(SRC)/SAINTint-ctrl/*.h
 	mv *.o $(BUILD)
-	$(CC) $(LIBS) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-int-ctrl
+	$(CC) $(LDFLAGS) $(BUILD)/*.o -o $(TARGET)/saint-int-ctrl $(LIBS)
 	rm $(BUILD)/*.o
 	@echo
 	@echo

--- End Message ---
--- Begin Message ---
Source: saint
Source-Version: 2.3.4+dfsg-2

We believe that the bug you reported is fixed in the latest version of
saint, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Alteholz <[email protected]> (supplier of updated saint package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 01 Jun 2013 22:00:00 +0200
Source: saint
Binary: saint
Architecture: source amd64
Version: 2.3.4+dfsg-2
Distribution: unstable
Urgency: low
Maintainer: Debian Med Packaging Team 
<[email protected]>
Changed-By: Thorsten Alteholz <[email protected]>
Description: 
 saint      - Significance Analysis of INTeractome
Closes: 710364
Changes: 
 saint (2.3.4+dfsg-2) unstable; urgency=low
 .
   * add patch ld-as-needed.patch from Julian Taylor (Closes: #710364)
Checksums-Sha1: 
 1ee730521fd17841c99b00d214d4f96f5d80b2fe 1359 saint_2.3.4+dfsg-2.dsc
 3e56d3993b44a634f41c798ff60b204ffaff57e5 5643 saint_2.3.4+dfsg-2.debian.tar.gz
 79ae300d1f69dbc8ea943aa88502a4c7efdb6d28 136932 saint_2.3.4+dfsg-2_amd64.deb
Checksums-Sha256: 
 ff98a0835fb436e96113546d64d68a925d66a2ab7c02e4cd06d55c1f404e04a2 1359 
saint_2.3.4+dfsg-2.dsc
 dd180c21d892574fe9588506d6852712c0dd198d2378bcccb864fe9174abc60c 5643 
saint_2.3.4+dfsg-2.debian.tar.gz
 b0851394e9dc44fe876cc146edcc0383c7f5d280dfa06168e5ad815937f7bd23 136932 
saint_2.3.4+dfsg-2_amd64.deb
Files: 
 2710ec2224bdbfb6b2ea206841760522 1359 science optional saint_2.3.4+dfsg-2.dsc
 6f9cc8228e5db946e7ae4cca267bd55e 5643 science optional 
saint_2.3.4+dfsg-2.debian.tar.gz
 a9104c8b657426f452ee16c3be8e8acc 136932 science optional 
saint_2.3.4+dfsg-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlGrEcYACgkQ02K2KlS5mJCzqQCfQh41cXQF079BsQ5DKPkT/jue
lvEAoJaM7m1xn3cUzD0DAbtGIkwTtWNo
=L3T3
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to