Your message dated Sun, 16 Jun 2013 19:47:06 +0000 with message-id <[email protected]> and subject line Bug#711751: fixed in dkimpy 0.5.3-1+deb7u1 has caused the Debian Bug report #711751, regarding incorrectly handles folded headers to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 711751: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=711751 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: python-dkim Version: 0.5.3-1 Severity: important Tags: patch Hi, it seems that python-dkim handles folded headers incorrectly. In partitular, attached tstmail-1 verifies correctly while tstmail-2 does not. The diff between these is: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=NRDGmXYX648Rm6cs06aAQIE77gu68nsSHYB4kAMm7QQ=; b=VaN3KmNPlU1uSNproy8wF+6qwTUKEcyzanoPSo/u8P0p8rtHgQpOW5/nJ+/ExQ9jKN FWTyZ9PLecg/0De0QYV18GQovYb3PVUCDHS7dYzfWp072lFPAhISUancFc30amzRPXcy J2lnvgoPcFuqDh5tLPchz8LdeIL0hMr2Xt+xEibHftqYT0JRXX4LXkZdO/b/i825qMtL W51wBB0V6L1ZU156A9cZWQWvwnQ/lV7PV7AwRqGbIESguRLfCbM+UIAGoCR8QtTO0lkY - bGqPQucn+1eZZUNsEJAWFI6eo2MmxY/FABEURGYAukaTg13UC9W+O6kGPH5iS5aRpAAT - eKbQ== + bGqPQucn+1eZZUNsEJAWFI6eo2MmxY/FABEURGYAukaTg13UC9W+O6kGPH5iS5aRpAAT eKbQ== } weasel@valiant:~/tmp/dkimpy-0.5.3$ ./dkimverify.py < ~/tmp/tstmail-1 } signature ok } weasel@valiant:~/tmp/dkimpy-0.5.3$ ./dkimverify.py < ~/tmp/tstmail-2 } signature verification failed I think the problem is due to an incorrect regex for FWS in dkim/__init__.py. The followed patch fixes ti: --- dkim/__init__.py.orig 2013-06-09 12:44:56.036635416 +0200 +++ dkim/__init__.py 2013-06-09 12:46:36.396127067 +0200 @@ -118,7 +118,8 @@ lastindex[h] = i return sign_headers -FWS = r'(?:\r?\n\s+)?' +# FWS = ([*WSP CRLF] 1*WSP) / obs-FWS ; Folding white space [RFC5322] +FWS = r'(?:(?:\s*\r?\n)?\s+)?' RE_BTAG = re.compile(r'([;\s]b'+FWS+r'=)(?:'+FWS+r'[a-zA-Z0-9+/=])*(?:\r?\n\Z)?') def hash_headers(hasher, canonicalize_headers, headers, include_headers, That is, FWS is one or more whitespaces with one *optional* linebreak. Maybe this could even be fixed in Debian stable? Cheers, weaselDKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=NRDGmXYX648Rm6cs06aAQIE77gu68nsSHYB4kAMm7QQ=; b=VaN3KmNPlU1uSNproy8wF+6qwTUKEcyzanoPSo/u8P0p8rtHgQpOW5/nJ+/ExQ9jKN FWTyZ9PLecg/0De0QYV18GQovYb3PVUCDHS7dYzfWp072lFPAhISUancFc30amzRPXcy J2lnvgoPcFuqDh5tLPchz8LdeIL0hMr2Xt+xEibHftqYT0JRXX4LXkZdO/b/i825qMtL W51wBB0V6L1ZU156A9cZWQWvwnQ/lV7PV7AwRqGbIESguRLfCbM+UIAGoCR8QtTO0lkY bGqPQucn+1eZZUNsEJAWFI6eo2MmxY/FABEURGYAukaTg13UC9W+O6kGPH5iS5aRpAAT eKbQ== MIME-Version: 1.0 Sender: [email protected] Received: by 10.42.92.137 with HTTP; Sun, 9 Jun 2013 02:37:02 -0700 (PDT) From: Christian Fromme <[email protected]> Date: Sun, 9 Jun 2013 11:37:02 +0200 X-Google-Sender-Auth: ZkDaYkXZHozJZyNGgvWFlv78IRY Message-ID: <cabop5ezogosxqxv1puhczdf-w3xpofpsbsm8o8lx5crx-eq...@mail.gmail.com> Subject: DKIM test mail #1 To: [email protected] Content-Type: text/plain; charset=ISO-8859-1 Hello, DKIMDKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=NRDGmXYX648Rm6cs06aAQIE77gu68nsSHYB4kAMm7QQ=; b=VaN3KmNPlU1uSNproy8wF+6qwTUKEcyzanoPSo/u8P0p8rtHgQpOW5/nJ+/ExQ9jKN FWTyZ9PLecg/0De0QYV18GQovYb3PVUCDHS7dYzfWp072lFPAhISUancFc30amzRPXcy J2lnvgoPcFuqDh5tLPchz8LdeIL0hMr2Xt+xEibHftqYT0JRXX4LXkZdO/b/i825qMtL W51wBB0V6L1ZU156A9cZWQWvwnQ/lV7PV7AwRqGbIESguRLfCbM+UIAGoCR8QtTO0lkY bGqPQucn+1eZZUNsEJAWFI6eo2MmxY/FABEURGYAukaTg13UC9W+O6kGPH5iS5aRpAAT eKbQ== MIME-Version: 1.0 Sender: [email protected] Received: by 10.42.92.137 with HTTP; Sun, 9 Jun 2013 02:37:02 -0700 (PDT) From: Christian Fromme <[email protected]> Date: Sun, 9 Jun 2013 11:37:02 +0200 X-Google-Sender-Auth: ZkDaYkXZHozJZyNGgvWFlv78IRY Message-ID: <cabop5ezogosxqxv1puhczdf-w3xpofpsbsm8o8lx5crx-eq...@mail.gmail.com> Subject: DKIM test mail #1 To: [email protected] Content-Type: text/plain; charset=ISO-8859-1 Hello, DKIM
--- End Message ---
--- Begin Message ---Source: dkimpy Source-Version: 0.5.3-1+deb7u1 We believe that the bug you reported is fixed in the latest version of dkimpy, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Scott Kitterman <[email protected]> (supplier of updated dkimpy package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sun, 09 Jun 2013 23:31:12 -0400 Source: dkimpy Binary: python-dkim python3-dkim Architecture: source all Version: 0.5.3-1+deb7u1 Distribution: wheezy Urgency: low Maintainer: Scott Kitterman <[email protected]> Changed-By: Scott Kitterman <[email protected]> Description: python-dkim - Python module for DKIM signing and verification python3-dkim - Python 3 module for DKIM signing and verification Closes: 711751 Changes: dkimpy (0.5.3-1+deb7u1) wheezy; urgency=low . * Fix Gmail signature verification failures due to improper FWS regular expression - Thanks to Peter Palfrader (weasel) for the patch (Closes: #711751) Checksums-Sha1: 5238f54cf6048aa4c33690e62427970fa2405818 1371 dkimpy_0.5.3-1+deb7u1.dsc 7de40dc4c80e0671a248a4db0c9557e23ad600b1 3872 dkimpy_0.5.3-1+deb7u1.diff.gz 012387fe04c41c6b82ff66e9f8ab9d3df0b22fbe 33850 python-dkim_0.5.3-1+deb7u1_all.deb c10f9534508d5db5224cbe47fe26652b1e4c4371 27618 python3-dkim_0.5.3-1+deb7u1_all.deb Checksums-Sha256: 7a9f193197ddb8ed98dfd101232ac98438222dbbbd58198091eab306d896bc5f 1371 dkimpy_0.5.3-1+deb7u1.dsc f6c453e5cb06a3d5c10a8adb35a5c54efb163684c679020cf37f81de318cc975 3872 dkimpy_0.5.3-1+deb7u1.diff.gz 0123ce9d15eec604c8f6570ddf0b12d9cccba1b9d2d802039f0445a4818d2f69 33850 python-dkim_0.5.3-1+deb7u1_all.deb f9298d3e0d5ccb7b70c902ac38b1719c467709875db4d0136116bb9eaa48b5aa 27618 python3-dkim_0.5.3-1+deb7u1_all.deb Files: 823d0f33e5f726ec7e727df0d342fe97 1371 python optional dkimpy_0.5.3-1+deb7u1.dsc fd09f65a789b92fabc68a8cb92ba45ea 3872 python optional dkimpy_0.5.3-1+deb7u1.diff.gz 8730f97365b2094e00326fcb97e70c46 33850 python optional python-dkim_0.5.3-1+deb7u1_all.deb 2869f2ce4e225e4fc275cd51a75c56e8 27618 python optional python3-dkim_0.5.3-1+deb7u1_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlG1S1AACgkQHajaM93NaGrGTgCdHw3qz6N2QP2CevZ7w6ZvYWrd eREAn0MhRgUP7QwIe9HO0LqqO85cWxqe =LijI -----END PGP SIGNATURE-----
--- End Message ---
