Your message dated Thu, 29 Aug 2013 21:35:01 +0000 with message-id <[email protected]> and subject line Bug#720280: fixed in munin 2.0.17-2 has caused the Debian Bug report #720280, regarding munin-async init script, missing status, has wrong name, doesn't remove pid to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 720280: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720280 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: munin-async Version: 2.0.6-4+deb7u1 Severity: normal Tags: patch Dear Maintainer, I needed a status to run this init under puppet without continious restarts. While adding this (copied from munin-node) I noticed the pid file wasn't remove on stop and the the SCRIPTNAME was wrong. -- System Information: Debian Release: 7.1 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.9.3-x86_64-linode33 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages munin-async depends on: ii adduser 3.113+nmu3 ii munin-common 2.0.6-4+deb7u1 ii munin-node 2.0.6-4+deb7u1 ii perl 5.14.2-21 ii perl-modules 5.14.2-21 munin-async recommends no packages. munin-async suggests no packages. -- Configuration Files: /etc/init.d/munin-async changed: PATH=/sbin:/usr/sbin:/bin:/usr/bin DESC="Munin asynchronous server" NAME=munin-asyncd DAEMON=/usr/share/munin/$NAME DAEMON_ARGS="" DAEMON_USER="munin-async" PIDFILE=/var/run/munin/$NAME.pid SCRIPTNAME=/etc/init.d/munin-async [ -x "$DAEMON" ] || exit 0 [ -r /etc/default/$NAME ] && . /etc/default/$NAME . /lib/init/vars.sh . /lib/lsb/init-functions do_start() { # Return # 0 if daemon has been started # 1 if daemon was already running # 2 if daemon could not be started start-stop-daemon --start --background --make-pidfile --pidfile $PIDFILE --chuid $DAEMON_USER --exec $DAEMON --test > /dev/null \ || return 1 start-stop-daemon --start --background --make-pidfile --pidfile $PIDFILE --chuid $DAEMON_USER --exec $DAEMON -- \ $DAEMON_ARGS \ || return 2 } do_stop() { # killproc() doesn't try hard enough if the pid file is missing, # so create it is gone and the daemon is still running if [ ! -r $PIDFILE ]; then pid=$(pidofproc -p $PIDFILE $DAEMON) if [ -z "$pid" ]; then [ "$VERBOSE" != no ] && log_progress_msg "stopped beforehand" log_end_msg 0 return 0 fi echo $pid 2>/dev/null > $PIDFILE if [ $? -ne 0 ]; then log_end_msg 1 return 1 fi fi killproc -p $PIDFILE /usr/bin/munin-node ret=$? # killproc() isn't thorough enough, ensure the daemon has been # stopped manually attempts=0 until ! pidofproc -p $PIDFILE $DAEMON >/dev/null; do attempts=$(( $attempts + 1 )) sleep 0.05 [ $attempts -lt 20 ] && continue log_end_msg 1 return 1 done rm "$PIDFILE" [ $ret -eq 0 ] && [ "$VERBOSE" != no ] && log_progress_msg "done" log_end_msg $ret return $ret } do_reload() { # # If the daemon can reload its configuration without # restarting (for example, when it is sent a SIGHUP), # then implement that here. # start-stop-daemon --stop --signal 1 --background --make-pidfile --quiet --pidfile $PIDFILE --exec $DAEMON return 0 } case "$1" in start) [ "$VERBOSE" != no ] && log_daemon_msg "Starting $DESC" "$NAME" do_start case "$?" in 0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;; 2) [ "$VERBOSE" != no ] && log_end_msg 1 ;; esac ;; stop) [ "$VERBOSE" != no ] && log_daemon_msg "Stopping $DESC" "$NAME" do_stop case "$?" in 0|1) [ "$VERBOSE" != no ] && log_end_msg 0 ;; 2) [ "$VERBOSE" != no ] && log_end_msg 1 ;; esac ;; #reload|force-reload) # # If do_reload() is not implemented then leave this commented out # and leave 'force-reload' as an alias for 'restart'. # #log_daemon_msg "Reloading $DESC" "$NAME" #do_reload #log_end_msg $? #;; restart|force-reload) # # If the "reload" option is implemented then remove the # 'force-reload' alias # log_daemon_msg "Restarting $DESC" "$NAME" do_stop case "$?" in 0|1) do_start case "$?" in 0) log_end_msg 0 ;; 1) log_end_msg 1 ;; # Old process is still running *) log_end_msg 1 ;; # Failed to start esac ;; *) # Failed to stop log_end_msg 1 ;; esac ;; status) pid=$(pidofproc -p $PIDFILE $DAEMON) ret=$? pid=${pid% } # pidofproc() supplies a trailing space, strip it if [ $ret -eq 0 ]; then log_success_msg "Munin-Async is running (PID: $pid)" exit 0 # the LSB specifies that I in this case (daemon dead + pid file exists) # should return 1, however lsb-base returned 2 in this case up to and # including version 3.1-10 (cf. #381684). Since that bug is present # in Sarge, Ubuntu Dapper, and (at the time of writing) Ubuntu Etch, # and taking into account that later versions of pidofproc() do not # under any circumstance return 2, I'll keep understanding invalid # return code for the time being, even though the LSB specifies it is # to be used for the situation where the "program is dead and /var/lock # lock file exists". elif [ $ret -eq 1 ] || [ $ret -eq 2 ]; then log_failure_msg "Munin-Async is dead, although $PIDFILE exists." exit 1 elif [ $ret -eq 3 ]; then log_warning_msg "Munin-Async is not running." exit 3 fi log_warning_msg "Munin-Async status unknown." exit 4 ;; *) #echo "Usage: $SCRIPTNAME {start|stop|restart|reload|force-reload}" >&2 echo "Usage: $SCRIPTNAME {start|stop|restart|force-reload|status}" >&2 exit 3 ;; esac : -- no debconf information--- munin-async.orig 2013-08-20 02:08:43.000000000 +0000 +++ munin-async 2013-08-20 02:17:01.000000000 +0000 @@ -21,7 +21,7 @@ DAEMON_ARGS="" DAEMON_USER="munin-async" PIDFILE=/var/run/munin/$NAME.pid -SCRIPTNAME=/etc/init.d/$NAME +SCRIPTNAME=/etc/init.d/munin-async # Exit if the package is not installed [ -x "$DAEMON" ] || exit 0 @@ -84,6 +84,7 @@ log_end_msg 1 return 1 done + rm "$PIDFILE" [ $ret -eq 0 ] && [ "$VERBOSE" != no ] && log_progress_msg "done" log_end_msg $ret return $ret @@ -150,9 +151,35 @@ ;; esac ;; + status) + pid=$(pidofproc -p $PIDFILE $DAEMON) + ret=$? + pid=${pid% } # pidofproc() supplies a trailing space, strip it + if [ $ret -eq 0 ]; then + log_success_msg "Munin-Async is running (PID: $pid)" + exit 0 + # the LSB specifies that I in this case (daemon dead + pid file exists) + # should return 1, however lsb-base returned 2 in this case up to and + # including version 3.1-10 (cf. #381684). Since that bug is present + # in Sarge, Ubuntu Dapper, and (at the time of writing) Ubuntu Etch, + # and taking into account that later versions of pidofproc() do not + # under any circumstance return 2, I'll keep understanding invalid + # return code for the time being, even though the LSB specifies it is + # to be used for the situation where the "program is dead and /var/lock + # lock file exists". + elif [ $ret -eq 1 ] || [ $ret -eq 2 ]; then + log_failure_msg "Munin-Async is dead, although $PIDFILE exists." + exit 1 + elif [ $ret -eq 3 ]; then + log_warning_msg "Munin-Async is not running." + exit 3 + fi + log_warning_msg "Munin-Async status unknown." + exit 4 + ;; *) #echo "Usage: $SCRIPTNAME {start|stop|restart|reload|force-reload}" >&2 - echo "Usage: $SCRIPTNAME {start|stop|restart|force-reload}" >&2 + echo "Usage: $SCRIPTNAME {start|stop|restart|force-reload|status}" >&2 exit 3 ;; esac
--- End Message ---
--- Begin Message ---Source: munin Source-Version: 2.0.17-2 We believe that the bug you reported is fixed in the latest version of munin, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Holger Levsen <[email protected]> (supplier of updated munin package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 29 Aug 2013 20:58:58 +0000 Source: munin Binary: munin-node munin-plugins-core munin-plugins-extra munin-plugins-java munin munin-common munin-async munin-doc Architecture: source all Version: 2.0.17-2 Distribution: unstable Urgency: low Maintainer: Munin Debian Maintainers <[email protected]> Changed-By: Holger Levsen <[email protected]> Description: munin - network-wide graphing framework (grapher/gatherer) munin-async - network-wide graphing framework (async master/client) munin-common - network-wide graphing framework (common) munin-doc - network-wide graphing framework (documentation) munin-node - network-wide graphing framework (node) munin-plugins-core - network-wide graphing framework (plugins for node) munin-plugins-extra - network-wide graphing framework (user contributed plugins for nod munin-plugins-java - network-wide graphing framework (java plugins for node) Closes: 684466 718959 720275 720280 Changes: munin (2.0.17-2) unstable; urgency=low . [ Matthias Schmitz ] * Don't remove munin's apache2.4 configuration on removal. This is the behavior as we do with the apache2.2 configuration. * As apache2-maintscript-helper doesn't work if called from a function we now give $@ of the postinst to our apache_install function. (Closes: #718959) . [ Holger Levsen ] * munin-async.init: - provide LSB status command. - fix $SCRIPTNAME. - rm pid file on stop. Thanks to Daniel Black for the patch. (Closes: #720280) * munin-node.cron.d: use munin-run to run plugins. (Closes: #720275) * Provide examples how to configure munin for nginx, thanks to Daniel Dehennin. (Closes: #684466) Checksums-Sha1: f16ea6c9e6225f8963514492878d7e0b834e4edc 2308 munin_2.0.17-2.dsc db7a7e0cf9438a1e32e0f3b22081e7a6e91c4725 52182 munin_2.0.17-2.diff.gz 7a51d59658292e55e1864485a80028fbe3b91649 127806 munin-node_2.0.17-2_all.deb 6a1b87b8202ceacfd45dbda8981a91d754d63484 237508 munin-plugins-core_2.0.17-2_all.deb c6e1839d0529165ff3560c7a2f8337093cce1d7e 144006 munin-plugins-extra_2.0.17-2_all.deb 1c5682e8f7a45d78be9d0f73859d6a9fe9ead671 152484 munin-plugins-java_2.0.17-2_all.deb 6402641d897b7343655d4b7972174562008f54c5 186750 munin_2.0.17-2_all.deb 36b9ae877365eb903180d7b88884f62fe6fca611 98848 munin-common_2.0.17-2_all.deb fe1d3fd5171b16f924ff0cd689b53943e16ba0dc 92664 munin-async_2.0.17-2_all.deb 0e2ea8bcb8839ebb7f6b237e77233e54ad137c49 222250 munin-doc_2.0.17-2_all.deb Checksums-Sha256: b9cefa47c001caac3ed1b33a130c5f0f4e52e2deb8f50c7f03c5d09a232ca5ef 2308 munin_2.0.17-2.dsc d47c66a1532f2e58b9a1e5f70fc072270cdbbf92bfdb8ea304e08014fcd3da8a 52182 munin_2.0.17-2.diff.gz f35dbb000741073779f23a9187895307cf9e4291b81d0f130b341079477246d0 127806 munin-node_2.0.17-2_all.deb 81c9a59413548ca82bb64e46e788ddaeef979cc4df96b1d92784f4c18f9be85c 237508 munin-plugins-core_2.0.17-2_all.deb b9922c8e564872718b02f6c1211e1045647e4c3a7ffb8bb75055f4175bed3e44 144006 munin-plugins-extra_2.0.17-2_all.deb 7023a735f2cdf2b86f999a647c5b355d5074884c767131dfa2e4c11ab3502ea7 152484 munin-plugins-java_2.0.17-2_all.deb 83eb930301a358de20ecc6fddc11ce2c122108a02b20abd0e4379d1c57e5ae4f 186750 munin_2.0.17-2_all.deb ac6a9de74d2dfcad5d5d6ba7182cae1f1334335c3b42dae04b668234f1d923a7 98848 munin-common_2.0.17-2_all.deb 16cd14f0bd368646e0b662a8dc67dbdeadfe93fdee663b4b47b4d470e497d7b4 92664 munin-async_2.0.17-2_all.deb 563e0268b28a36a0a64478d6bb7f338e6b93d757802fb0c993f3618f7adc2def 222250 munin-doc_2.0.17-2_all.deb Files: 3db94f1f6eeaad7c7cdb09d777918fb3 2308 net optional munin_2.0.17-2.dsc 250c5df495a01133116c15aff5a29aef 52182 net optional munin_2.0.17-2.diff.gz cb5d0ddbe4a7b97b1066bb2bd0be8c12 127806 net optional munin-node_2.0.17-2_all.deb 785ccd70ba6744139f17631b04199207 237508 net optional munin-plugins-core_2.0.17-2_all.deb 44342c1df4c62d84175a6614b9dc29d4 144006 net optional munin-plugins-extra_2.0.17-2_all.deb 093eebee07bb73df634458d3087db1b9 152484 net optional munin-plugins-java_2.0.17-2_all.deb 0e249e638b03fbc634a69c6ff2839bd3 186750 net optional munin_2.0.17-2_all.deb 51a5ebe1c66c0778dd4c15ddf88f9ce4 98848 net optional munin-common_2.0.17-2_all.deb 79d3adbb8ea75b38d5bed36ad3a09d04 92664 net optional munin-async_2.0.17-2_all.deb c1fc52f47259226e1accccba9bdeff6f 222250 doc optional munin-doc_2.0.17-2_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIVAwUBUh+44wkauFYGmqocAQiJNg/9FrP/8BFzGPt7FueiJOHlseBFVgfDBK43 aBFFoG/u0EnwjRQDF3xV5n9wULuSHBCOR80hDiB+I2Wauji9gLqtIVxl1u+9RZiw A1fUqhwHwVoCXUZ01boc2qpemA7tZYBTi4W8IMJp8cmELSyOga6uqfCbN7UzVIMD Ah8blutgaaUdq6pXzfkdGJS1FDyAoaQFwFMjXB0nfon4c8rpekdmFW2/Bb8nFpg7 Fx+YZjhdZAFiGviZGBxn834gQlbjMfMbSSeRIsn3ZyRi5Z+Ww0wFwDa2TKVY5rc6 nv6OaHzVLheCS5ydtXwh/ddl1K7Gh0lqJDM/3Zsr9ZhF6T52iFdiR32547lyELLb WnuDYvCAlaTS2eUfP6dI2q4j7pucsAn9MlWAinLPyPQQioPY82c8gHDa6avEAe1D lmzWTd3i+BWczPzjV1cz7o+ILk/LQBkPh+a7pGl5ybCTCIw0EBX3Bx4opNkxLjOo 6hatdO+kLS7MOxP+R0I+PhB26SHp1wUIr3MAZXwcmGRq9MunWRmeb5DXvItiunCl l8Su63eIVxIEU1qywfxXn4xuETo5PQ/M8ZkieWtC17Aou8ZjmRmKpi6D32X1JhNI K8KmnBaILxFyLX2ffD7BnKQfHDr1vGi0e1Phv9SQCXY/rKNlhAld/8sCe7A5Bhn1 vaKh43WmkIE= =nvi+ -----END PGP SIGNATURE-----
--- End Message ---
