Your message dated Sun, 22 Sep 2013 22:19:49 +0000 with message-id <[email protected]> and subject line Bug#723681: fixed in soundtouch 1.7.1-3 has caused the Debian Bug report #723681, regarding libsoundtouch0: breaks ABI on armel to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 723681: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=723681 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: libsoundtouch0 Version: 1.7.1-1 Severity: serious Tags: sid jessie patch Control: affects -1 + src:audacity In version 1.7.1 of soundtouch | #if (defined(__SOFTFP__)) | // For Android compilation: Force use of Integer samples in case that | // compilation uses soft-floating point emulation - soft-fp is way too slow | #undef SOUNDTOUCH_FLOAT_SAMPLES | #define SOUNDTOUCH_INTEGER_SAMPLES 1 | #endif was added to include/STTypes.h [1]. Since __SOFTFP__ is defined on armel, SAMPLETYPE changed from float to short and the signatures of some functions changed. For example, take the following simple program: | #include <soundtouch/FIFOSampleBuffer.h> | int main() | { | soundtouch::FIFOSampleBuffer f; | soundtouch::SAMPLETYPE s = 0; | f.putSamples(&s, 1); | } When compiled and linked against a version prior to 1.7.1 and then upgrading to 1.7.1, the program fails to run: % ./a.out ./a.out: symbol lookup error: ./a.out: undefined symbol: _ZN10soundtouch16FIFOSampleBuffer10putSamplesEPKfj The attached patch reverts this change and restores ABI compatibility. Regards -- Sebastian Ramacherdiff --git a/include/STTypes.h b/include/STTypes.h index ed4231b..8820a53 100644 --- a/include/STTypes.h +++ b/include/STTypes.h @@ -78,13 +78,6 @@ namespace soundtouch //#undef SOUNDTOUCH_INTEGER_SAMPLES //#undef SOUNDTOUCH_FLOAT_SAMPLES - #if (defined(__SOFTFP__)) - // For Android compilation: Force use of Integer samples in case that - // compilation uses soft-floating point emulation - soft-fp is way too slow - #undef SOUNDTOUCH_FLOAT_SAMPLES - #define SOUNDTOUCH_INTEGER_SAMPLES 1 - #endif - #if !(SOUNDTOUCH_INTEGER_SAMPLES || SOUNDTOUCH_FLOAT_SAMPLES) /// Choose either 32bit floating point or 16bit integer sampletype
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---Source: soundtouch Source-Version: 1.7.1-3 We believe that the bug you reported is fixed in the latest version of soundtouch, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Sebastian Ramacher <[email protected]> (supplier of updated soundtouch package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 22 Sep 2013 16:00:23 +0200 Source: soundtouch Binary: libsoundtouch-dev libsoundtouch0 libsoundtouch0-dbg soundstretch soundstretch-dbg Architecture: source amd64 Version: 1.7.1-3 Distribution: unstable Urgency: low Maintainer: Debian Multimedia Maintainers <[email protected]> Changed-By: Sebastian Ramacher <[email protected]> Description: libsoundtouch-dev - Development files for the sound stretching library libsoundtouch0 - Sound stretching library libsoundtouch0-dbg - Debugging symbols for the sound stretching library soundstretch - Stretches and pitch-shifts sound independently soundstretch-dbg - Debugging symbols for the soundstretch program Closes: 707751 723681 Changes: soundtouch (1.7.1-3) unstable; urgency=low . * Team upload. * debian/patches/dont-use-integers-if-softp.patch: Revert ABI breakage on armel. Don't use integers instead of floats if __SOFTP__ is defined. (Closes: #723681) * debian/control: - libsoundtouch-dev: Don't mark as M-A: same. It contains arch-dependent files in /usr/include/soundtouch. (Closes: #707751) - libsoundtouch0: Add Breaks on gstreamer1.0-plugins-bad and yatm (armel only). They have been built against the broken ABI. * debian/rules: Bump shlibs of libsoundtouch0 to >= 1.7.1-3~. Checksums-Sha1: 0bcd42cc50f97c327737e953a46f652efdef5576 2251 soundtouch_1.7.1-3.dsc 30ef24e1f092841fc86a9d5cab26b23d94b8b15e 8332 soundtouch_1.7.1-3.debian.tar.gz 8a222a280396617f3668f162d4a9b0b51be1b116 12256 libsoundtouch-dev_1.7.1-3_amd64.deb f11c9a3518e5d995002de92af46829a7c37e485f 36238 libsoundtouch0_1.7.1-3_amd64.deb 250a486565d36c346ed96d18936d6546f86f7594 84672 libsoundtouch0-dbg_1.7.1-3_amd64.deb 27516461e1acfa9f6323e84bd427bc5ea8ddd810 30008 soundstretch_1.7.1-3_amd64.deb 7b884c4dbbfa1dca94033c45073e6e4556ee08f1 58138 soundstretch-dbg_1.7.1-3_amd64.deb Checksums-Sha256: 464d2d6e34c7ed65fd87e6860f1da03b1882c9d77b1af1c766f019087faa9005 2251 soundtouch_1.7.1-3.dsc e390bd2a4f08b97e61375b9fa0c557c719031f6812b1823ad2c2da5b462576c8 8332 soundtouch_1.7.1-3.debian.tar.gz 5d4f7ffa6c7779cd98eae5a29f183d9267f31ae76325f3e3c99c95c805f38831 12256 libsoundtouch-dev_1.7.1-3_amd64.deb 1851ad3dd479a970f24a126d8390eefc2c473e33ef59e7721185e27a04132d5b 36238 libsoundtouch0_1.7.1-3_amd64.deb 4dc713c804898ea79f7de5769474ed49d5f8f4abc73834ae9d92e4e2490db030 84672 libsoundtouch0-dbg_1.7.1-3_amd64.deb 724a696a10a75f8f299fbede104b89092617b83c20a6078cffb3191097c04fc0 30008 soundstretch_1.7.1-3_amd64.deb 806e375cc4b2befa59f8deca02e3c61a5f8e8d7ab3b35e8ad516fc29e344955e 58138 soundstretch-dbg_1.7.1-3_amd64.deb Files: 668cdff7560468b529d53295710e9ccc 2251 libs optional soundtouch_1.7.1-3.dsc 341a32a1e829015e0fd4ed351c70766c 8332 libs optional soundtouch_1.7.1-3.debian.tar.gz 509a09bb8aa33cd5cb86774b5f0f5dd2 12256 libdevel optional libsoundtouch-dev_1.7.1-3_amd64.deb 892d1eba3b98188d23e06d517fb95d53 36238 libs optional libsoundtouch0_1.7.1-3_amd64.deb 11f89bfcec5c760029b8b87e2728c952 84672 debug extra libsoundtouch0-dbg_1.7.1-3_amd64.deb 054b427293e30dafbf3b5422cda9f4f8 30008 sound optional soundstretch_1.7.1-3_amd64.deb fbf7e9fe285aaa24cbab5e22f978f02e 58138 debug extra soundstretch-dbg_1.7.1-3_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBCAAGBQJSP2kSAAoJEGny/FFupxmTD6sQAJhJAytJ0FlJXyIHg++xf61+ tDuK90jF2mL7hLxVmMSurwT59xwSlYqNsZlHTADAM308f4BVjaAgPaUagCXkCLHa lEHltStwZ8Jt+v4uoYkisWd2EMmB3fZ62H5dApWZtQPufHoZZRqyG4+nHpPyfWJY KYWmwiFkG9fgkfaz8oxUvvQqQvj3md210MqKNYWa+abmnH/xgHw0mDgO8Aml0co8 RdrL8gdaOOkZPwHIXc0NL1QNBQYFFGhQjKL9ld50r1WvGO3G7oSl0TzSe60BeW6D PY3GFxDsDTzuvyNiPtytEf5HvQMjb6HqtunNKIxqrf7oFTs9qE+c6Ej7Dxabl+5s znEiEcnRYZ2ZkWIK4JAdFJ6QrOgzvI7Bc52FGxwvBfpzuI4uEWQpBkWG2XvwxF1J y+aa3YFWdV4RDVzrHAwAGN9vry9ZjmnaGcJ7KONQJuCF5DWkbJQ/uw0AdRnyZVUZ KIOhBeYACdck2QY2EYDG0z0MK3Qyux5Nlrii7Kl0j5osLA3lK9gY+DLNOI4QbMcT IAde60VKez0H6rlGBK0Lcz+eMGKwRoGdPiAAaX6TJoDnFIgY6yqOTjKBIl8uwnkY d4QJbOLm/gOTgA8KJPn6bqoo0JEPDdOcVWqzwBJsJDQgxJ4NXIxvn+ZvnxBZs4zN 6JBG/OsRdlDU/P6mrlUu =S6r/ -----END PGP SIGNATURE-----
--- End Message ---
