Your message dated Sat, 12 Oct 2013 19:48:28 +0000
with message-id <[email protected]>
and subject line Bug#669280: fixed in psgml 1.4.0-2
has caused the Debian Bug report #669280,
regarding psgml: 'local automatically makes hook buffer-local in Emacs,
make-local-hook is only for XEmacs
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
669280: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=669280
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: psgml
Version: 1.3.2-13
Severity: wishlist
Tags: patch
Hi,
psgml contains some unconditional calls to (make-local-hook), but this is
only needed for XEmacs, where 'local does not automatically make hook
buffer-local.
emacs-snapshot currently complains about this, and as soon as new Emacs is
released and reaches Debian, Debian Emacs will complain too.
Please consider attached patch.
Regards,
--
Agustin
>From 5153dd67073ebdb15d71d1fe644d6a3bde639d3a Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo <[email protected]>
Date: Wed, 18 Apr 2012 19:46:12 +0200
Subject: [PATCH 1/2] psgml.el, psgml-parse.el: 'local does not automatically
make hook buffer-local in XEmacs.
---
psgml-parse.el | 6 ++++--
psgml.el | 8 ++++++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/psgml-parse.el b/psgml-parse.el
index 5c14cce..8565558 100644
--- a/psgml-parse.el
+++ b/psgml-parse.el
@@ -2936,8 +2936,10 @@ overrides the entity type in entity look up."
(defun sgml-set-initial-state (dtd)
"Set initial state of parsing."
- (make-local-hook 'before-change-functions)
- (make-local-hook 'after-change-functions)
+ (when (featurep 'xemacs)
+ ;; 'local does not automatically make hook buffer-local in XEmacs
+ (make-local-hook 'before-change-functions)
+ (make-local-hook 'after-change-functions))
(add-hook 'before-change-functions 'sgml-note-change-at nil 'local)
(add-hook 'after-change-functions 'sgml-set-face-after-change nil 'local)
(sgml-set-active-dtd-indicator (sgml-dtd-doctype dtd))
diff --git a/psgml.el b/psgml.el
index 8cd47e0..7d41ba2 100644
--- a/psgml.el
+++ b/psgml.el
@@ -1235,12 +1235,16 @@ All bindings:
(make-local-variable 'text-property-default-nonsticky)
;; see `sgml-set-face-for':
(add-to-list 'text-property-default-nonsticky '(face . t)))
- (make-local-hook 'post-command-hook)
+ (if (featurep 'xemacs)
+ ;; 'local does not automatically make hook buffer-local in XEmacs.
+ (make-local-hook 'post-command-hook))
(add-hook 'post-command-hook 'sgml-command-post 'append 'local)
(unless sgml-running-lucid
;; XEmacs 20.4 doesn't handle local activate-menubar-hook
;; it tries to call the function `t' when using the menubar
- (make-local-hook 'activate-menubar-hook))
+ (if (featurep 'xemacs)
+ ;; 'local does not automatically make hook buffer-local in XEmacs.
+ (make-local-hook 'activate-menubar-hook)))
(add-hook 'activate-menubar-hook 'sgml-update-all-options-menus
nil 'local)
(run-hooks 'text-mode-hook 'sgml-mode-hook)
--
1.7.10
--- End Message ---
--- Begin Message ---
Source: psgml
Source-Version: 1.4.0-2
We believe that the bug you reported is fixed in the latest version of
psgml, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Neil Roeth <[email protected]> (supplier of updated psgml package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 12 Oct 2013 15:20:57 -0400
Source: psgml
Binary: psgml
Architecture: source all
Version: 1.4.0-2
Distribution: unstable
Urgency: low
Maintainer: Neil Roeth <[email protected]>
Changed-By: Neil Roeth <[email protected]>
Description:
psgml - Emacs major mode for editing SGML documents
Closes: 669280
Changes:
psgml (1.4.0-2) unstable; urgency=low
.
* Modified Emacs remove script so that it deletes compiled list files
when package is removed.
* New version no longer uses make-local-hook. (Closes: #669280).
Checksums-Sha1:
097b6fa800b4737ed58a80993bd29b713ded3525 731 psgml_1.4.0-2.dsc
45bbd18e0d6f1cb6a675f9c71a3c06e1b8cd5c35 328321 psgml_1.4.0-2.tar.gz
fd880563e67659ca8eec6e13492094b96612aa75 273784 psgml_1.4.0-2_all.deb
Checksums-Sha256:
826302c7a0bc9967b144644ec6f7a46b67093c8ef9f5c2201dbb0ab0b9490af5 731
psgml_1.4.0-2.dsc
347267d6286202c725bfbb29119ec8b85eae649edd2e42afa28f28c38052d0f3 328321
psgml_1.4.0-2.tar.gz
cee9ce4fb780b1f36103ff1f84006d71e77a34db575e4696621e02da76fec20a 273784
psgml_1.4.0-2_all.deb
Files:
894f201c526ebfb9473d4f92f30f897c 731 text optional psgml_1.4.0-2.dsc
4a57ef8e1c5e9ff89574ede49a315f3d 328321 text optional psgml_1.4.0-2.tar.gz
22f1a3e95570c780368cc72c90005487 273784 text optional psgml_1.4.0-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
iD8DBQFSWaNk6j+skPrutKkRAtySAKCwW4CHwVMA20J8OnQn2QmZEaQl5ACfYL30
EtwJIUSgh+YzFSCNovCzjPI=
=y8mt
-----END PGP SIGNATURE-----
--- End Message ---
