Your message dated Wed, 16 Oct 2013 03:20:24 +0000
with message-id <[email protected]>
and subject line Bug#692504: fixed in pepper 0.3.2-3
has caused the Debian Bug report #692504,
regarding pepper: Build failure with ld --as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
692504: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692504
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pepper
Version: 0.3.2-2
Severity: normal
Tags: patch upstream
User: [email protected]
Usertags: ld-as-needed
pepper fails to build, in Ubuntu, where the ld --as-needed option is
used by default.
The attached patch would fix this issue. I've forwarded it upstream.
https://sourceforge.net/tracker/?func=detail&aid=3584851&group_id=386093&atid=1604686
See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
Thanks for considering the patch.
SR
Description: Build with the ld --as-needed option
Libraries should appear after all objects on the gcc command line, which
generally means using LDADD macros instead of LDFLAGS for libraries
Author: Stefano Rivera <[email protected]>
Bug-Upstream:
https://sourceforge.net/tracker/?func=detail&aid=3584851&group_id=386093&atid=1604686
Last-Updated: 2012-11-06
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -45,7 +45,10 @@
pepper_SOURCES = \
main.cpp
pepper_LDADD = \
- libpepper.a
+ libpepper.a \
+ $(PTHREAD_LIBS) \
+ $(LUA_LIB) \
+ $(FRAMEWORKS)
AM_CXXFLAGS = \
-Wall -W -pipe \
@@ -55,10 +58,7 @@
AM_CPPFLAGS = \
$(LUA_INCLUDE) \
-DDATADIR=\"$(pkgdatadir)\"
-AM_LDFLAGS = \
- $(PTHREAD_LIBS) \
- $(LUA_LIB) \
- $(FRAMEWORKS)
+AM_LDFLAGS =
# Debugging?
if DEBUG
@@ -84,7 +84,7 @@
-DUSE_MERCURIAL
AM_CXXFLAGS += \
$(PYTHON_CPPFLAGS)
-AM_LDFLAGS += \
+pepper_LDADD += \
$(PYTHON_LDFLAGS)
endif
@@ -100,7 +100,8 @@
$(APR_CFLAGS) \
$(SVN_CFLAGS)
AM_LDFLAGS += \
- $(SVN_LDFLAGS) \
+ $(SVN_LDFLAGS)
+pepper_LDADD += \
$(SVN_LIBS) \
$(APR_LIBS)
endif
--- a/m4/configure_backends.m4
+++ b/m4/configure_backends.m4
@@ -70,8 +70,9 @@
AC_CHECK_LIB([svn_diff-1],
[svn_diff_file_diff_2], ,[AC_MSG_ERROR([Neccessary Subversion libraries are
missing])])
AC_CHECK_LIB([svn_delta-1],
[svn_txdelta_apply], ,[AC_MSG_ERROR([Neccessary Subversion libraries are
missing])])
AC_CHECK_LIB([svn_repos-1], [svn_repos_create],
,[AC_MSG_ERROR([Neccessary Subversion libraries are missing])])
+ SVN_LDFLAGS=$LDFLAGS
LDFLAGS=$OLD_LDFLAGS
- SVN_LDFLAGS=$LIBS
+ SVN_LIBS=$LIBS
LIBS=$OLD_LIBS
AC_SUBST(SVN_CFLAGS)
AC_SUBST(SVN_LDFLAGS)
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -104,7 +104,9 @@
@SVN_BACKEND_TRUE@ $(SVN_CFLAGS)
@SVN_BACKEND_TRUE@am__append_12 = \
-@SVN_BACKEND_TRUE@ $(SVN_LDFLAGS) \
+@SVN_BACKEND_TRUE@ $(SVN_LDFLAGS)
+
+@SVN_BACKEND_TRUE@am__append_12b = \
@SVN_BACKEND_TRUE@ $(SVN_LIBS) \
@SVN_BACKEND_TRUE@ $(APR_LIBS)
@@ -359,7 +361,12 @@
main.cpp
pepper_LDADD = \
- libpepper.a
+ libpepper.a \
+ $(PTHREAD_LIBS) \
+ $(LUA_LIB) \
+ $(FRAMEWORKS) \
+ $(am__append_8) \
+ $(am__append_12b)
AM_CXXFLAGS = -Wall -W -pipe $(PTHREAD_CFLAGS) $(am__append_1) \
$(am__append_7) $(am__append_11) $(am__append_16)
@@ -369,8 +376,8 @@
AM_CPPFLAGS = $(LUA_INCLUDE) -DDATADIR=\"$(pkgdatadir)\" \
$(am__append_4) $(am__append_6) $(am__append_10) \
$(am__append_14) $(am__append_18)
-AM_LDFLAGS = $(PTHREAD_LIBS) $(LUA_LIB) $(FRAMEWORKS) $(am__append_2) \
- $(am__append_8) $(am__append_12)
+AM_LDFLAGS = $(am__append_2) \
+ $(am__append_12)
# Last but not least, the CFLAGS
AM_CFLAGS = $(AM_CXXFLAGS)
--- a/configure
+++ b/configure
@@ -8439,8 +8439,9 @@
as_fn_error $? "Neccessary Subversion libraries are missing" "$LINENO" 5
fi
+ SVN_LDFLAGS=$LDFLAGS
LDFLAGS=$OLD_LDFLAGS
- SVN_LDFLAGS=$LIBS
+ SVN_LIBS=$LIBS
LIBS=$OLD_LIBS
--- End Message ---
--- Begin Message ---
Source: pepper
Source-Version: 0.3.2-3
We believe that the bug you reported is fixed in the latest version of
pepper, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Antoine Beaupré <[email protected]> (supplier of updated pepper package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 15 Oct 2013 22:07:53 -0400
Source: pepper
Binary: pepper
Architecture: source amd64
Version: 0.3.2-3
Distribution: unstable
Urgency: low
Maintainer: Antoine Beaupré <[email protected]>
Changed-By: Antoine Beaupré <[email protected]>
Description:
pepper - Source code repository statistics and report tool
Closes: 686232 692504
Changes:
pepper (0.3.2-3) unstable; urgency=low
.
[Stefano Rivera]
* Build with the ld --as-needed option (Closes: #692504)
.
[Antoine Beaupré]
* update standards version to 3.9.4, no change
* Add missing dependencies on gnuplot, fixing: "Missing recommends
dependency on gnuplot-x11", thanks to Carlos Alberto Lopez Perez for
flagging this one (Closes: #686232).
Checksums-Sha1:
a0c6d79bc5d8c97362373e75cb9f6e4f8bbda4bf 1967 pepper_0.3.2-3.dsc
29d5e28fd11926e3937adcadf46aa4236cfe7ee5 4419 pepper_0.3.2-3.debian.tar.gz
c1dd35d48d9c3324d498aa7a12c33a98007981c7 209000 pepper_0.3.2-3_amd64.deb
Checksums-Sha256:
3f9f10cd303d5e31fe07c8863c639e946eb2968244c408ecceca63e542de6e27 1967
pepper_0.3.2-3.dsc
34b70d8963c2b23ec46d1985556ae400e2e6adb8fc14306dd12f51ba84889f41 4419
pepper_0.3.2-3.debian.tar.gz
51582b6614bb6a5665e23fe32f1fd20beefe438d600e8710fd601c377f081969 209000
pepper_0.3.2-3_amd64.deb
Files:
c1fb27d61666fbe758c091193f24a4f6 1967 vcs optional pepper_0.3.2-3.dsc
fae660bcf923116468042cf263add83c 4419 vcs optional pepper_0.3.2-3.debian.tar.gz
6930373ad6a78d2c390e532dc3ca834c 209000 vcs optional pepper_0.3.2-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJSXfjKAAoJEHkhUlJ7dZIe37sP/ilEDA76DQ1282u9MDepHQ6V
PUNyyUB6KJU54dZetTaWVUyJ8BqGjzzRoy7LQRKkkazX5ayvJuCrRtU44N/efR6S
XR+TJeF7RsYV9pPpht9SoD/BozWjW2NuLIeZrK+cy9mhZlajFCFxn5IVzeN2gvxI
JR9EMm0IiI7nhWco9aXHism5KP0h6VoUag6iJZeQRUHRQR7Lju+k2SgCd9k7gwUJ
ROVRg/9PzqRPnJrRrNcC1V4aaq+MSXpBixK7VUWGNpoIq+0S3U/GHb1FIbiltOmf
F64xXVVjxX3r2zizGb1Cqtx4O+RYa74cYIzioXFViPw/cZLzmFmNXA5kfhv1pOoP
WX/9NlbktlzBBqZmSStzljwwCtebOdLKPzYm6Zbl1zRkA0zs0+nWgI8qumQ1Bxv5
4p2WVRFUTbV1Ni9nbWHdZz6QGeqcvCdP4pkVSryrtH971Jp65PCZcuALaQefChUN
10EVjSHTTaztLwgdU+LGz/IcDuxKqu05qSyTAdvil8PGq2wvetGrTrFYGSrdZ30o
GNzMCeIqmLo4jcg+29hX54DNUHrEFYUCokQYaCc705AWvTN0jmyn17F+ejmm0LL5
dZcQpKmG7YQ37rV7lbjPG7q1A7LErXP7XiggqjgKbxm45px6uJKbcy1BKXgc7egI
Fx9a0OJWUj+eFO3t3dDk
=C49r
-----END PGP SIGNATURE-----
--- End Message ---
