Your message dated Sat, 19 Oct 2013 11:35:28 +0200
with message-id <[email protected]>
and subject line Re: libmilter1.0.1: Uninitialised variable in worker.c
has caused the Debian Bug report #524562,
regarding libmilter1.0.1: Uninitialised variable in worker.c
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
524562: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524562
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libmilter1.0.1
Version: 8.14.3-5.1
Severity: normal
==8142== Conditional jump or move depends on uninitialised value(s)
==8142== at 0x41AB9D2: mi_pool_controller (worker.c:365)
==8142== by 0x41E04BF: start_thread (in /lib/i686/cmov/libpthread-2.7.so)
==8142== by 0x45BC6DD: clone (in /lib/i686/cmov/libc-2.7.so)
I get the above error message from Valgrind. Below is the patch to fix it:
diff -ru sendmail-8.14.3/libmilter/worker.c sendmail-8.14.3/libmilter/worker.c
--- sendmail-8.14.3/libmilter/worker.c 2009-04-18 12:48:35.000000000 +1000
+++ sendmail-8.14.3/libmilter/worker.c 2009-04-18 12:49:04.000000000 +1000
@@ -345,12 +345,12 @@
}
dim_pfd = PFD_STEP;
+ time_t lastcheck = time(NULL);
for (;;)
{
SMFICTX_PTR ctx;
int nfd, rfd, i;
time_t now;
- time_t lastcheck;
POOL_LEV_DPRINTF(4, ("Let's %s again...", WAITFN));
-- System Information:
Debian Release: 5.0.1
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=ANSI_X3.4-1968)
(ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/bash
Versions of packages libmilter1.0.1 depends on:
ii libc6 2.7-18 GNU C Library: Shared libraries
libmilter1.0.1 recommends no packages.
libmilter1.0.1 suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Version: 8.14.4-1
On Wednesday, 10. June 2009 14:39:56 Jose-Marcio wrote:
> Sorry, the correct patch is below :
>
> ***************************************************************************
>*** --- worker.c.org 2007-12-03 23:06:05.000000000 +0100
> +++ worker.c 2009-06-10 14:32:05.000000000 +0200
> @@ -328,6 +328,7 @@
> int dim_pfd = 0;
> bool rebuild_set = true;
> int pcnt = 0; /* error count for poll() failures */
> + time_t lastcheck;
>
> Tskmgr.tm_tid = sthread_get_id();
> if (pthread_detach(Tskmgr.tm_tid) != 0)
> @@ -345,12 +346,12 @@
> }
> dim_pfd = PFD_STEP;
>
> + lastcheck = time(NULL);
> for (;;)
> {
> SMFICTX_PTR ctx;
> int nfd, rfd, i;
> time_t now;
> - time_t lastcheck;
>
> POOL_LEV_DPRINTF(4, ("Let's %s again...", WAITFN));
> *********************************************************************
This seems to be fixed in 8.14.4
Andreas
--- End Message ---
