Your message dated Sun, 20 Oct 2013 12:33:18 +0000
with message-id <[email protected]>
and subject line Bug#724062: fixed in opensmtpd 5.3.3p1-4
has caused the Debian Bug report #724062,
regarding syslog prognames truncated
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
724062: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724062
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: opensmtpd
Version: 5.3.3p1-3
Tags: upstream
re: https://github.com/poolpOrg/OpenSMTPD/issues/239
I see now. The git tree I cloned from github has no openbsd-compat
sub-directory. It's unfortunate that the closed tickets don't have
links to the commits.
I'll give this a try later.
On Sun, Sep 22, 2013 at 10:23 AM, Ryan Kavanagh <[email protected]> wrote:
> Thanks for the email. I suspect this is the relevant commit. I'll try to
> test it / upload a fixed package in the next few days.
>From 1bf55e2711b8f1575c8d4775002c3035f13a99a7 Mon Sep 17 00:00:00 2001
From: Eric Faurot <[email protected]>
Date: Fri, 7 Jun 2013 15:56:59 +0200
Subject: [PATCH] setproctile() tweakery alters memory buffer referenced by
__progname, which make the logs look bad. Set __progname to a safe static
buffer early on to make everybody happy. While there, check for overflow to
make gilles happy.
---
openbsd-compat/setproctitle.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/openbsd-compat/setproctitle.c b/openbsd-compat/setproctitle.c
index 2965f68..ae3d92c 100644
--- a/openbsd-compat/setproctitle.c
+++ b/openbsd-compat/setproctitle.c
@@ -64,6 +64,9 @@ static size_t argv_env_len = 0;
#endif /* HAVE_SETPROCTITLE */
+static char altprogname[1024];
+extern char *__progname;
+
void
compat_init_setproctitle(int argc, char *argv[])
{
@@ -73,6 +76,9 @@ compat_init_setproctitle(int argc, char *argv[])
char **envp = environ;
int i;
+ strlcpy(altprogname, __progname, sizeof(altprogname));
+ __progname = altprogname;
+
/*
* NB: This assumes that argv has already been copied out of the
* way. This is true for sshd, but may not be true for other
@@ -125,7 +131,7 @@ setproctitle(const char *fmt, ...)
va_list ap;
char buf[1024], ptitle[1024];
size_t len;
- extern char *__progname;
+ int r;
#if SPT_TYPE == SPT_PSTAT
union pstun pst;
#endif
@@ -137,13 +143,16 @@ setproctitle(const char *fmt, ...)
strlcpy(buf, __progname, sizeof(buf));
+ r = -1;
va_start(ap, fmt);
if (fmt != NULL) {
len = strlcat(buf, ": ", sizeof(buf));
if (len < sizeof(buf))
- vsnprintf(buf + len, sizeof(buf) - len , fmt, ap);
+ r = vsnprintf(buf + len, sizeof(buf) - len , fmt, ap);
}
va_end(ap);
+ if (r == -1 || (size_t)r >= sizeof(buf) - len)
+ return;
strnvis(ptitle, buf, sizeof(ptitle),
VIS_CSTYLE|VIS_NL|VIS_TAB|VIS_OCTAL);
--- End Message ---
--- Begin Message ---
Source: opensmtpd
Source-Version: 5.3.3p1-4
We believe that the bug you reported is fixed in the latest version of
opensmtpd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ryan Kavanagh <[email protected]> (supplier of updated opensmtpd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 20 Oct 2013 08:07:22 -0400
Source: opensmtpd
Binary: opensmtpd
Architecture: source amd64
Version: 5.3.3p1-4
Distribution: unstable
Urgency: low
Maintainer: Ryan Kavanagh <[email protected]>
Changed-By: Ryan Kavanagh <[email protected]>
Description:
opensmtpd - secure, reliable, lean, and easy-to configure SMTP server
Closes: 724062 724343 725103
Changes:
opensmtpd (5.3.3p1-4) unstable; urgency=low
.
* Added French translations (Closes: #724343)
Thanks to Jean-Pierre Giraud <[email protected]>
* Added Swedish translation (Closes: #725103)
Thanks to Martin Bagge <[email protected]>
* Don't truncate process names in syslog, 14_syslog_prognames.diff
(Closes: #724062)
Checksums-Sha1:
a5b5a839d5254414ec93f2a70dc56753762c7b9e 3051 opensmtpd_5.3.3p1-4.dsc
084914938f075fbcd6e82b138d1abcb2ee224583 26809
opensmtpd_5.3.3p1-4.debian.tar.gz
6a46c83a3cb2c749a4fccf07ccae0e14c7318c6d 211868 opensmtpd_5.3.3p1-4_amd64.deb
Checksums-Sha256:
484a22fda850a94006a5182dfd6d6bad985f6523305e0d6bc7e6af799d3aea15 3051
opensmtpd_5.3.3p1-4.dsc
a84698a6f6b9dc51227e9fd25883bf9ed6ba9bb637585f49b878fa79b7b4a636 26809
opensmtpd_5.3.3p1-4.debian.tar.gz
10b817eecede8464fb4840fac7ec988be67104dfa8873eaad09e353e3c25edae 211868
opensmtpd_5.3.3p1-4_amd64.deb
Files:
afee11136051ca4409c369a64645c517 3051 mail extra opensmtpd_5.3.3p1-4.dsc
a8dbdd9d1ef7d88b1803dbc7b17b2d33 26809 mail extra
opensmtpd_5.3.3p1-4.debian.tar.gz
74c8cf05e3e8b6c0e721b1b07cae3956 211868 mail extra
opensmtpd_5.3.3p1-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQUcBAEBCgAGBQJSY8nPAAoJEI97+PxKEcl6t8En+gKHxSt0SQal94BvJCUuU/5q
ftIfGGMa9w0lEUhlefuPLbuEu5oWSgqC1vxSTn2xjhZe/nFXTh6cnL1Lb0aEL/Xx
Dm8R3KkaVPGS/R/CWiQi2eg0N2jgw9EIbEb9uQ6s/dqjNmBuwlXAyYyl+xBQK4vW
ZtBkuk5p9Z7m+5FmsCRf6IOBHdSYVauqUZkkNLOtYr+kJVTnWBZVqv3WPFPO6oqt
aPxzg97vzAgdASwgSRaeljq5L8PiRu5nOX1/DHEEwVgHlCr2ZNJCMdNUAmyRmIzW
owBRHQFta9u2uk2+xeanmN2G3AyKw8VAKWtHZuxUnxBg1321Q/Wy4763PbYCpHIb
bv8xZKWKrtdZv7MN3OlWkFj20zA20RckAbt/VsZDde78HBkzbo0Hyx3Z29pm5WJG
b6NgeHTqICuRls+RaCI/lGjFuxJtzDoE782xFE1Lc3E4nANFKOWFq4f+SDMw0E3D
gcQeOaUSJLHXxOk3msM8uZG6suO1250dQbT3P2Zy5u3D+I/47iqN0DUHRegckirN
O/PhDBGHwGB5iw2olvYqDeClidc/m8JkJ7K5EAnW0JDEb/FWUBF81IrueIj2Hl0J
u8djT3UPtNO3IWb+sgjYje0EF/fPfFtwZ56TF3IUh2N8gjtb4r3R7+UjYTgMGc7O
Dwt5PSFIXHZLn9OYn/iHbII77GUSNk8REsOlDV70AW9jj16MH5vksFqOFQTRECHj
PrhPRb01op/YW0x9rkBguOJnhBBHxyvmFJTs9g2VFIsDp3VXxE9sFhqKVuhXAdAJ
YklXinWANe3HTqPKGBkAL7U3QAwJ9+xUmMIbWOJAzUfAJ9B8j2Hw4/gk7JGdGsR7
9FNDlC2eERWh9nZ+Ck1ucgt9qjok6v7aiXv/pT8qEyqgiqZ8as63qRmrdEIvemN8
3q3Dp6zryinffEHMyPPK0VJhCRc0wDEhkyFQleWnupl2Q77fSOhZNAfTuQTa0tlX
qIX/ioYQVi4khC1YWsbWvAOhGkWj7KMpbYrgWupD03xJ5t87OX5bVpUIEd6ztNQ9
hVsCdOxMjO7lr20P1MRWM85qucM9scrjCZ8PyOXQbvUA4KvWZkeQo+1ref4SH8+J
B5NL5PRn8V2e+DT9ZnR87Vuim54W02q4W4iE2oBQuJ0nQ+ZkSzya7jo/gxddT4Qx
JRuZUL5KsDL2YAGIH2x34c/5VNvHN+ux+iVuKVv4YyNgYJu1sES0qYhdioFHHKMo
jcBHjBNn56EYziVd6jz0kue2p9jYxyDDwqsJrobU0N1LFq+mUg8YU5lT1hALxdru
i5KACZ/H1J5D6mpbqAhzZSzuUoQwKgbRm3ehFGabLEhA9fPtYqlF4M8h3yDM8VCA
Rt2s0CpRZiVp7wIc949QPPZKCtxNSLMV8rY+//w5dzlkJ2OuCNmnPwXWk7hza/7c
RZSKvCc7/v/1n81sBNuH6Kyhl4bfxtG6zsTOqgHuR9DpZIB7n1pXDFat9hBkaNot
/URFX0SUR34/WIWM7vCVldxDA0dCKRSKEzJ+tl1F22fYbB/XZ8qhqRvlbidq3ifM
MyAydSjzb80z4GIkxcBkWZx4g2qeUKA5MR2bKL13HGFt305HU/NrfmNql/eO+2q+
0kFGEvFrSINy67+MkLmVjDr0AltUWP+GErKHHm6aJ25mJs6yO1/iDC6xEP2opgwJ
W4F5suWpcNFZYsVzkCMe
=5odP
-----END PGP SIGNATURE-----
--- End Message ---
