Your message dated Tue, 22 Oct 2013 14:33:57 -0400
with message-id <[email protected]>
and subject line Re: Bug#638928: [buildd-tools-devel] Bug#638928:
/usr/share/perl5/Sbuild/Build.pm: Use UTF-8 for .changes attachment to log mail
has caused the Debian Bug report #638928,
regarding /usr/share/perl5/Sbuild/Build.pm: Use UTF-8 for .changes attachment
to log mail
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
638928: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638928
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libsbuild-perl
Version: 0.62.5-1
Severity: wishlist
File: /usr/share/perl5/Sbuild/Build.pm
Tags: patch
I noticed when building the 2.11.1 devscripts package that the .changes
file attached to the log mail isn't UTF-8 encoded. Since all control
files must be UTF-8 encoded according to policy §5.1, it should be safe
to specify a charset of UTF-8 as per the attached patch.
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (100, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.39-2-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages libsbuild-perl depends on:
ii adduser 3.113 add and remove users and groups
ii apt 0.8.15.6 Advanced front-end for dpkg
ii apt-utils 0.8.15.6 APT utility programs
ii dctrl-tools 2.18 Command-line tools to process Debi
ii devscripts 2.11.0 scripts to make the life of a Debi
ii dpkg-dev 1.16.0.3 Debian package development tools
ii libdpkg-perl 1.16.0.3 Dpkg perl modules
ii libexception-class-perl 1.31-1 module that allows you to declare
ii libfilesys-df-perl 0.92-3+b2 Module to obtain filesystem disk s
ii libmime-lite-perl 3.027-1 module for convenient MIME message
ii perl 5.12.4-4 Larry Wall's Practical Extraction
ii perl-modules [libio-zlib-perl 5.12.4-4 Core Perl modules
ii postfix [mail-transport-agent 2.8.4-1 High-performance mail transport ag
ii schroot 1.4.23-1 Execute commands in a chroot envir
libsbuild-perl recommends no packages.
libsbuild-perl suggests no packages.
-- no debconf information
--
James
GPG Key: 1024D/61326D40 2003-09-02 James Vega <[email protected]>
From d9ec2fe1260e7d3177dfccb3c33c7aec0e696415 Mon Sep 17 00:00:00 2001
From: James Vega <[email protected]>
Date: Mon, 22 Aug 2011 20:45:27 -0400
Subject: [PATCH] Sbuild::Build: Use utf-8 for .changes log attachment
---
lib/Sbuild/Build.pm | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index 3732577..6b1930e 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -2317,11 +2317,13 @@ sub send_mime_build_log {
my $changes = $self->get('Package_SVersion') . '_' . $self->get('Arch') . '.changes';
if ($self->get_status() eq 'successful' && -r $changes) {
- $msg->attach(
+ my $log_part = MIME::Lite->new(
Type => 'text/plain',
Path => $changes,
Filename => basename($changes)
);
+ $log_part->attr('content-type.charset' => 'UTF-8');
+ $msg->attach($log_part);
}
my $stats = '';
--
1.7.5.4
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Version: 0.62.6-1
On Tue, Aug 23, 2011 at 07:33:01AM +0200, Philipp Kern wrote:
> On Mon, Aug 22, 2011 at 08:57:14PM -0400, James Vega wrote:
> > I noticed when building the 2.11.1 devscripts package that the .changes
> > file attached to the log mail isn't UTF-8 encoded. Since all control
> > files must be UTF-8 encoded according to policy §5.1, it should be safe
> > to specify a charset of UTF-8 as per the attached patch.
>
> Yep, that was an oversight of mine. Thanks for the report, I applied
> it to the git.
Closing, as this fix has been released for a while.
Cheers,
--
James
--- End Message ---
