Your message dated Thu, 31 Oct 2013 12:18:21 +0000
with message-id <[email protected]>
and subject line Bug#727537: fixed in aria2 1.18.0-2
has caused the Debian Bug report #727537,
regarding Don't depend on network for autopkgtest
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
727537: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727537
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: aria2
Version: 1.18.0-1
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch trusty
Hello,
thanks for adding an autopkgtest! However, this currently assumes that
it can reach http://www.debian.org/, which may not always be the case
in test environments.
It would be better to run it against a local HTTP server, which also
makes it easier/possible to actually verify the result.
As a proposal I attach a debdiff which I just uploaded to Ubuntu. It
uses "python3 -m http.server" (which is the simplest, least intrusive,
and easiest server which I'm aware of) and compares the downloaded
file against the original one.
Thanks for considering,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru aria2-1.18.0/debian/changelog aria2-1.18.0/debian/changelog
--- aria2-1.18.0/debian/changelog 2013-09-22 19:15:53.000000000 +0200
+++ aria2-1.18.0/debian/changelog 2013-10-24 08:19:12.000000000 +0200
@@ -1,3 +1,10 @@
+aria2 (1.18.0-1ubuntu1) trusty; urgency=low
+
+ * debian/tests/httpfile: Use local http server (with python3 -m http.server)
+ instead of relying on network access, and verify the downloaded result.
+
+ -- Martin Pitt <[email protected]> Thu, 24 Oct 2013 08:18:45 +0200
+
aria2 (1.18.0-1) unstable; urgency=low
[ Kartik Mistry ]
diff -Nru aria2-1.18.0/debian/tests/control aria2-1.18.0/debian/tests/control
--- aria2-1.18.0/debian/tests/control 2013-09-22 14:58:28.000000000 +0200
+++ aria2-1.18.0/debian/tests/control 2013-10-24 08:11:14.000000000 +0200
@@ -1 +1,2 @@
Tests: httpfile
+Depends: @, python3
diff -Nru aria2-1.18.0/debian/tests/httpfile aria2-1.18.0/debian/tests/httpfile
--- aria2-1.18.0/debian/tests/httpfile 2013-09-22 14:58:28.000000000 +0200
+++ aria2-1.18.0/debian/tests/httpfile 2013-10-24 08:18:28.000000000 +0200
@@ -1 +1,14 @@
-aria2c -d /tmp http://www.debian.org
+#!/bin/sh
+set -e
+PORT=43248
+
+# start local http server
+cd /etc
+python3 -m http.server $PORT &
+HTTP_PID=$!
+trap "kill $HTTP_PID" EXIT TERM INT
+
+aria2c -d $ADTTMP http://localhost:$PORT/passwd
+
+# verify that files are identical
+cmp /etc/passwd $ADTTMP/passwd
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: aria2
Source-Version: 1.18.0-2
We believe that the bug you reported is fixed in the latest version of
aria2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Patrick Ruckstuhl <[email protected]> (supplier of updated aria2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 31 Oct 2013 15:54:07 +0530
Source: aria2
Binary: aria2
Architecture: source amd64
Version: 1.18.0-2
Distribution: unstable
Urgency: low
Maintainer: Patrick Ruckstuhl <[email protected]>
Changed-By: Patrick Ruckstuhl <[email protected]>
Description:
aria2 - High speed download utility
Closes: 727537
Changes:
aria2 (1.18.0-2) unstable; urgency=low
.
* debian/tests/httpfile:
+ Do not depend on internet being available. Thanks to Martin Pitt for
patch (Closes: #727537).
Checksums-Sha1:
672bd55ac3d74cce64d761a60b82259a4e4dea30 1436 aria2_1.18.0-2.dsc
c5fd55ee5bcb65f4f89f7b78efa5e421b02f17bf 5681 aria2_1.18.0-2.debian.tar.gz
c96c6d5b81e8d1dc1721002b208c7ae2d5cc8e4b 1105956 aria2_1.18.0-2_amd64.deb
Checksums-Sha256:
2f109a2edc24102c315ddb070e97afe067d04fbf242c39641531390381239b7b 1436
aria2_1.18.0-2.dsc
d9f44405be0a90489829b9d9bc93c4b0c464b2c173c97148228a59ec4c1be1c3 5681
aria2_1.18.0-2.debian.tar.gz
fe60cce865234dc3850d217c6e5ebcdef5969f7ceda6a21ddfa719e98967f080 1105956
aria2_1.18.0-2_amd64.deb
Files:
fd6a8df7b5fd2147a3a42d8507625a2c 1436 net optional aria2_1.18.0-2.dsc
cd1f199521db2d4617c06e6315b8d523 5681 net optional aria2_1.18.0-2.debian.tar.gz
38f7768950ae390ab36a2a26c68c3974 1105956 net optional aria2_1.18.0-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iEYEARECAAYFAlJySEAACgkQoRg/jtECjI0mxACeNuptyG9irBkClmb9efUS4CsB
Y0IAniDMdIWL1OqKzpQvkYXdiYD+KcLV
=qi38
-----END PGP SIGNATURE-----
--- End Message ---
